gsutil.py should have crcmod in its vpython spec |
||
Issue descriptionWhen you download large objects from cloud storage, gsutil.py will tell you that you should install the 'crcmod' python package to get better performance. We don't have that installed by default. gsutil.py in depot_tools uses vpython, so we could in theory just add a crcmod wheel. However, it looks like we don't currently have one built for windows, so we should probably build one, too.
,
Sep 20
Ah, yeah we don't have it for windows (and dockerbuild doesn't know how to build it). I'll modify that CL to only get it on !windows for now.
,
Sep 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9cba9ffdfdc64127ee47561c0bd6a339778599f5 commit 9cba9ffdfdc64127ee47561c0bd6a339778599f5 Author: Dirk Pranke <dpranke@chromium.org> Date: Thu Sep 20 18:20:00 2018 Add the crcmod wheel for gsutil, to get it to shut up. Hopefully this will also actually speed up downloads like it claims it will :). Bug: 875100 Change-Id: I712df6272135b1fa3b1f32095916b18128644718 Reviewed-on: https://chromium-review.googlesource.com/1179078 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/9cba9ffdfdc64127ee47561c0bd6a339778599f5/gsutil.vpython
,
Sep 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2da56e8e8205bb242b385bc725dfefaf4e57e8a6 commit 2da56e8e8205bb242b385bc725dfefaf4e57e8a6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Sep 20 20:06:37 2018 Roll src/third_party/depot_tools a5ac303c5308..9cba9ffdfdc6 (2 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a5ac303c5308..9cba9ffdfdc6 git log a5ac303c5308..9cba9ffdfdc6 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 dpranke@chromium.org Add the crcmod wheel for gsutil, to get it to shut up. 2018-09-20 sdy@chromium.org Suppress URLErrors when uploading metrics. Created with: gclient setdep -r src/third_party/depot_tools@9cba9ffdfdc6 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:875100, chromium:887540 TBR=agable@chromium.org Change-Id: I9e8794867feb346151dffeb261dc9f16089db3c5 Reviewed-on: https://chromium-review.googlesource.com/1236880 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592920} [modify] https://crrev.com/2da56e8e8205bb242b385bc725dfefaf4e57e8a6/DEPS
,
Oct 18
|
||
►
Sign in to add a comment |
||
Comment 1 by dpranke@chromium.org
, Aug 16