Crash happened if trying to snap the "files" app from the top of the display |
||||
Issue descriptionDrag the "files" app from the top of the display to splitscreen when it is maximized or snapped already. Crash happened. Seems the problem of the SetIndicatorState
,
Aug 28
Since we trying to snap a window, which will trigger the window state change here https://cs.chromium.org/chromium/src/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc?rcl=123a64cbf84a55ca88e6a77c1f84f999e96c55d4&l=124. It will disable the immersive fullscreen if window exit fullscreen but not minimized.
,
Aug 29
Tried to upload cl https://chromium-review.googlesource.com/c/chromium/src/+/1188460 to fix it. But the cl merged before here https://chromium-review.googlesource.com/c/chromium/src/+/1194874 fixed this issue too. No crash now. marked as fixed.
,
Aug 29
reopen since https://chromium-review.googlesource.com/c/chromium/src/+/1194874 has been reverted again. Will go to merge my own fix.
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2586387e0cfc4d773795c147c652765dcdf575b commit d2586387e0cfc4d773795c147c652765dcdf575b Author: Min Chen <minch@google.com> Date: Thu Aug 30 01:43:40 2018 Do not disable immersive mode if exit fullscreen in tablet mode. The previous cl https://chromium-review.googlesource.com/c/chromium/src/+/1166254/5 disabled the immersive mode if window exits fullscreen. This should only did for window in clamshell mode, since in tablet mode, we still want to keep immersive mode enabled even window is not in fullscreen mode. Like window is maximized or snapped, the caption of the window should still be hidden and can be dragged from top. Bug: 875098 Change-Id: I9727b15c19b6955467e8db89deb2586421167c80 Reviewed-on: https://chromium-review.googlesource.com/1188460 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#587400} [modify] https://crrev.com/d2586387e0cfc4d773795c147c652765dcdf575b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc [modify] https://crrev.com/d2586387e0cfc4d773795c147c652765dcdf575b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash_browsertest.cc
,
Aug 30
,
Aug 30
Issue 879398 has been merged into this issue. |
||||
►
Sign in to add a comment |
||||
Comment 1 by minch@chromium.org
, Aug 28