New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 875096 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

InputMethod.VirtualKeyboard.Layout records a11y layout even though it's emoji.

Project Member Reported by shend@chromium.org, Aug 16

Issue description

Currently, if we are using the accessibility keyboard, then any layout is considered "a11y", even emoji and handwriting. I think this is a bit confusing, especially since we use the accessibility keyboard for temporarily showing the VK in laptop mode.
 
Cc: shuchen@chromium.org
+shuchen who owns InputMethod.VirtualKeyboard.Layout. Was it intentional that the emoji layout on accessibility keyboard is recorded as "a11y" and not "emoji"? Do you think we should change this?
Cc: yhanada@chromium.org
+yhanada. It's not intentional that we show the accessibility keyboard when we use the IME menu tray to show the VK temporarily right? I recall it was just a limitation of the code, so can we change it to show the non-accessibility keyboard?
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d6e66dc4dc9a7416c67a346b0d0e0057e751276

commit 2d6e66dc4dc9a7416c67a346b0d0e0057e751276
Author: Darren Shen <shend@chromium.org>
Date: Sun Aug 26 23:37:18 2018

[VK] Use non-accessibility keyboard when opening keyboard from tray.

When in laptop mode, we sometimes need to show the virtual keyboard (
e.g. from the IME tray menu). Currently we just temporarily enable the
accessibility virtual keyboard in order to show the keyboard.

However, this has two downsides:
1) It shows the accessibility keyboard, which has a different layout /
   size than the non-accessibility keyboard.
2) Sometimes, there are bugs where the accessibility keyboard is
   accidentaly enabled/disabled permanently.

We add a new switch in keyboard_util to show the virtual keyboard. We
then enable the switch when showing the VK in laptop mode. This solves
both problems.

Bug:  875096 
Change-Id: I712fbe42dbeec99dfea4f1aeddbe1db0cc50ed45
Reviewed-on: https://chromium-review.googlesource.com/1186284
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586172}
[modify] https://crrev.com/2d6e66dc4dc9a7416c67a346b0d0e0057e751276/ash/keyboard/virtual_keyboard_controller.cc
[modify] https://crrev.com/2d6e66dc4dc9a7416c67a346b0d0e0057e751276/ash/keyboard/virtual_keyboard_controller.h
[modify] https://crrev.com/2d6e66dc4dc9a7416c67a346b0d0e0057e751276/ash/keyboard/virtual_keyboard_controller_unittest.cc
[modify] https://crrev.com/2d6e66dc4dc9a7416c67a346b0d0e0057e751276/ui/keyboard/keyboard_util.cc
[modify] https://crrev.com/2d6e66dc4dc9a7416c67a346b0d0e0057e751276/ui/keyboard/keyboard_util.h

Hi Darren, 
Does InputMethod.VirtualKeyboard.Layout record the correct layout now?
"correct" means record "emoji" when showing emoji keyboard.

If it's non-accessibility keyboard, then it's correct layout.
If it's accessibility keyboard, still not correct layout (emoji/hwt etc. are under "a11y").
Components: -UI>Input>Text>IME
Blocking: 884578
Blocking: -884578
Status: Fixed (was: Assigned)

Sign in to add a comment