New issue
Advanced search Search tips

Issue 875083 link

Starred by 1 user
Status: Started
Owner:
mlamouri@chromium.org
Cc:
dalecur...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Media WatchTime takes into account custom control fullscreen

Project Member Reported by mlamouri@chromium.org, Aug 16 
At the moment, we only take into account native controls fullscreen which gives very unrealistic views.

On Android, there is already a mechanism to detect custom controls fullscreen for auto-pip. On desktop, it may require hooking into the code for casting.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0c9d157079ddad20e4a051e458a3114667bec37

commit a0c9d157079ddad20e4a051e458a3114667bec37
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Fri Aug 17 18:46:26 2018

WatchTime: use EffectivelyFullscreen signal for fullscreen watch time.

The custom control fullscreen detection will be used to override
DisplayType so that an inline playback that is "effectively fullscreen"
will be represented as fullscreen with regards to watch time.

Bug: 875083
Change-Id: Ie5ced38ae559cfa3d1cfc046cd94a4a34b139ccb
Reviewed-on: https://chromium-review.googlesource.com/1178998
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584138}
[modify] https://crrev.com/a0c9d157079ddad20e4a051e458a3114667bec37/third_party/blink/public/platform/web_media_player.h
[modify] https://crrev.com/a0c9d157079ddad20e4a051e458a3114667bec37/third_party/blink/renderer/core/html/media/html_video_element.cc
[modify] https://crrev.com/a0c9d157079ddad20e4a051e458a3114667bec37/third_party/blink/renderer/core/html/media/html_video_element.h
[modify] https://crrev.com/a0c9d157079ddad20e4a051e458a3114667bec37/third_party/blink/renderer/core/html/media/html_video_element_test.cc
[modify] https://crrev.com/a0c9d157079ddad20e4a051e458a3114667bec37/third_party/blink/renderer/core/html/media/media_custom_controls_fullscreen_detector.cc
[modify] https://crrev.com/a0c9d157079ddad20e4a051e458a3114667bec37/third_party/blink/renderer/core/html/media/media_custom_controls_fullscreen_detector.h
►

Sign in to add a comment