Issue metadata
Sign in to add a comment
|
Keyboard Accessory covers page input fields |
||||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3522.0 OS: Android What steps will reproduce the problem? (1) Tap on message input field in an application like Twitter Light or Telegram Web. What is the expected result? Keyboard pops up and pushes up the input field. What happens instead? The input field is covered by the "keyboard accessory". This makes these applications nearly impossible to use. Research seems to indicate that this might only be an issue on dev-channel because this feature is not launched to stable. The problem is that there are users who are on dev-channel as their main browser so we shouldn't leave this broken over the long term. I have observed this behavior persist for weeks.
,
Aug 17
,
Aug 17
,
Aug 17
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e6e38295e5939b389f667e7a1b19311a11a6296 commit 1e6e38295e5939b389f667e7a1b19311a11a6296 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Thu Oct 11 16:24:41 2018 [Android] Decouple keyboard accessory from bottom controls The multiple meanings with the bottom controls are a root for multiple issues: * the CCT bottom bar being overlaid (and leaving a white patch) * the PWA bar resizing the viewport deferred * the flakiness of fullscreen applications This CL introduces a solution that provides the bottom bars and the compositor view holder with the "keyboard extension" as new bottom element that is independent from others. Currently, this extension is set on the instance. Long-term, the delegate would only provide a getter that its children inherit. Bug: 885113, 704070, 875077 , 891657, 881536 Change-Id: I59639204823296b7c4ac701d0243aaa751f8b57d Reviewed-on: https://chromium-review.googlesource.com/c/1233716 Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#598792} [modify] https://crrev.com/1e6e38295e5939b389f667e7a1b19311a11a6296/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [add] https://crrev.com/1e6e38295e5939b389f667e7a1b19311a11a6296/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardExtensionSizeManager.java [modify] https://crrev.com/1e6e38295e5939b389f667e7a1b19311a11a6296/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingCoordinator.java [modify] https://crrev.com/1e6e38295e5939b389f667e7a1b19311a11a6296/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java [modify] https://crrev.com/1e6e38295e5939b389f667e7a1b19311a11a6296/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java [modify] https://crrev.com/1e6e38295e5939b389f667e7a1b19311a11a6296/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java [modify] https://crrev.com/1e6e38295e5939b389f667e7a1b19311a11a6296/chrome/android/java_sources.gni |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by mkwst@chromium.org
, Aug 17