New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 875074 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Implement logic to discovery IOS Cable Authenticators

Project Member Reported by hongjunchoi@chromium.org, Aug 16

Issue description

Add parsing/discovery for caBLE advertisements that come from iOS phones.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78356dacbbe0c4cea548538c5d48053b325e3b58

commit 78356dacbbe0c4cea548538c5d48053b325e3b58
Author: Yuankai Yu <yyk@google.com>
Date: Fri Aug 17 19:15:19 2018

Add parsing for caBLE advertisements that come from iOS phones.

Apple doesn't allow advertising with service data, as a result we are
advertising the EID in the form of service UUID in the advertisement.
Chrome on Mac advertises in this form, however Chrome on all platform
needs to parse this form of advertisement as well since iOS phone can
only advertise in this form.

Bug:  875074 
Change-Id: I654d2cfbbf5692cf9b17876b2d05bfad07f7bba2
Reviewed-on: https://chromium-review.googlesource.com/1171253
Commit-Queue: Yuankai Yu <yyk@google.com>
Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584145}
[modify] https://crrev.com/78356dacbbe0c4cea548538c5d48053b325e3b58/device/fido/ble/fido_ble_uuids.cc
[modify] https://crrev.com/78356dacbbe0c4cea548538c5d48053b325e3b58/device/fido/ble/fido_ble_uuids.h
[modify] https://crrev.com/78356dacbbe0c4cea548538c5d48053b325e3b58/device/fido/cable/fido_cable_discovery.cc
[modify] https://crrev.com/78356dacbbe0c4cea548538c5d48053b325e3b58/device/fido/cable/fido_cable_discovery.h
[modify] https://crrev.com/78356dacbbe0c4cea548538c5d48053b325e3b58/device/fido/cable/fido_cable_discovery_unittest.cc
[modify] https://crrev.com/78356dacbbe0c4cea548538c5d48053b325e3b58/device/fido/fido_parsing_utils.cc
[modify] https://crrev.com/78356dacbbe0c4cea548538c5d48053b325e3b58/device/fido/fido_parsing_utils.h

Status: Fixed (was: Started)

Sign in to add a comment