We have 6 findit recipes https://cs.chromium.org/chromium/build/scripts/slave/recipes/findit/ And the code in test.py, compile.py, and flake.py are complex while the findit/api.py recipe module could be improved too
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/d6530f501818f32c8179a81e0564fa68f464786c commit d6530f501818f32c8179a81e0564fa68f464786c Author: Shuotao Gao <stgao@chromium.org> Date: Wed Sep 12 22:50:43 2018 [Findit recipes] Refactor configure_and_sync in findit recipe module. Move the handling of buildbucket info out of configure_and_sync Bug: 875072 Change-Id: I78b79df927be11f29ea2e090e43536f963829dd1 Reviewed-on: https://chromium-review.googlesource.com/1222181 Commit-Queue: Shuotao Gao <stgao@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> [modify] https://crrev.com/d6530f501818f32c8179a81e0564fa68f464786c/scripts/slave/README.recipes.md [modify] https://crrev.com/d6530f501818f32c8179a81e0564fa68f464786c/scripts/slave/recipe_modules/findit/api.py [modify] https://crrev.com/d6530f501818f32c8179a81e0564fa68f464786c/scripts/slave/recipes/findit/chromium/flake.py [modify] https://crrev.com/d6530f501818f32c8179a81e0564fa68f464786c/scripts/slave/recipes/findit/chromium/test.py
Comment 1 by st...@chromium.org
, Aug 16