When a page causes a dialog to be shown, they should lose any HTML5 fullscreen that they have activated. https://docs.google.com/document/d/1UhlQmjVk_AJuDLabB__mERqGQ3pKDtoZ-Qi9zudl424
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d41e77125f3de8d722b6d8303599abaf2a91667 commit 3d41e77125f3de8d722b6d8303599abaf2a91667 Author: Avi Drissman <avi@chromium.org> Date: Mon Aug 27 21:18:08 2018 If a dialog is shown, drop fullscreen. BUG= 875066 , 817809 , 792876, 812769 , 813815 TEST=included Change-Id: Ic3d697fa3c4b01f5d7fea77391857177ada660db Reviewed-on: https://chromium-review.googlesource.com/1185208 Reviewed-by: Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#586418} [modify] https://crrev.com/3d41e77125f3de8d722b6d8303599abaf2a91667/chrome/browser/ui/browser.cc [modify] https://crrev.com/3d41e77125f3de8d722b6d8303599abaf2a91667/chrome/browser/ui/browser_browsertest.cc [modify] https://crrev.com/3d41e77125f3de8d722b6d8303599abaf2a91667/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/3d41e77125f3de8d722b6d8303599abaf2a91667/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/3d41e77125f3de8d722b6d8303599abaf2a91667/content/browser/web_contents/web_contents_impl_browsertest.cc
Comment 1 by a...@chromium.org
, Aug 20