New issue
Advanced search Search tips

Issue 875059 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 6
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocked on:
issue 871908

Blocking:
issue 850674
issue 862689



Sign in to add a comment

VR DFM: Use string reference for title

Project Member Reported by tiborg@chromium.org, Aug 16

Issue description

Same as  issue 871912  but for the VR DFM.
 
Blocking: 862689
Owner: tiborg@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c

commit 4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Thu Sep 06 21:01:04 2018

[android:build] Allow resource reference from feature to base module

Bug:  871908 ,  871912 ,  875059 
Change-Id: I2a071d9a2d9b6cdf449d69e42e5bec8fe68f7884
Reviewed-on: https://chromium-review.googlesource.com/1204601
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589296}
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/build/android/gyp/compile_resources.py
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/build/android/gyp/prepare_resources.py
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/build/android/gyp/util/resource_utils.py
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/build/config/android/internal_rules.gni
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/build/config/android/rules.gni
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/BUILD.gn
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/java/src/org/chromium/chrome/browser/vr/SilenceLintErrors.java
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/modules/ar/AndroidManifest.xml
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/modules/ar/ar_module_tmpl.gni
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/modules/vr/AndroidManifest.xml
[modify] https://crrev.com/4f4887f1a8074ba0a0da57d9cca23eb6cf22ca0c/chrome/android/modules/vr/vr_module_tmpl.gni

Status: Fixed (was: Started)
Labels: VR-DFM

Sign in to add a comment