New issue
Advanced search Search tips

Issue 875053 link

Starred by 4 users
Status: Started
Owner:
nhar...@chromium.org
Cc:
nhar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 855690
Blocking:
issue 903642



Sign in to add a comment

Deprecate and remove Channel ID

Project Member Reported by nhar...@chromium.org, Aug 16
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3724ecc1c6e9c1ec1312c845a1b8395f6df668f8

commit 3724ecc1c6e9c1ec1312c845a1b8395f6df668f8
Author: Nick Harper <nharper@chromium.org>
Date: Thu Aug 30 23:17:47 2018

Disable Channel ID

Bug: 875053
Change-Id: Ia0d4f40619c2d9f7a271e78857a86b9b63a3dc0b
Reviewed-on: https://chromium-review.googlesource.com/1194876
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587833}
[modify] https://crrev.com/3724ecc1c6e9c1ec1312c845a1b8395f6df668f8/components/network_session_configurator/common/network_features.cc

Comment 2 by reillyg@chromium.org, Oct 5 

Is it safe to start removing code outside of //net that relates to Channel ID?

I'm looking at modifying chromeos::ProfileAuthData to work with the Network Service and right now there is no interface for copying channel IDs from the temporary sign-in profile to the user's main profile. Given that the feature has been turned off I assume that GAIA is no longer depending on it and so the code can be removed.

Comment 3 by nhar...@chromium.org, Oct 5 

Since the CL to disable Channel ID landed in M71, I was going to wait until the 71 branches to remove Channel ID code (so that the Channel ID removal lands in 72).

Would waiting until M72 delay your work? If so, go ahead and remove it now (but there could be slightly wonky behavior if someone flips on the channel-id feature via --enable-features command line flag). Otherwise, I'd wait.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e32110255c41e14b2b307ca6b7fd05b77cff1d9

commit 7e32110255c41e14b2b307ca6b7fd05b77cff1d9
Author: Reilly Grant <reillyg@google.com>
Date: Fri Oct 12 23:06:57 2018

Remove channel ID migration from Chrome OS signin

As channel IDs are disabled by default. It is no longer necessary to
copy keys from the sign-in profile to the user profile on first login.
Removing this now (rather than waiting for channel ID support to be
removed entirely unblocks  issue 792678  as no interface for migrating
channel IDs needs to be added to the Network Service.

Bug: 875053
Change-Id: Ia3abef8fa396e41890d8c2ba8fb9083cbcecc71b
Reviewed-on: https://chromium-review.googlesource.com/c/1265998
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599399}
[modify] https://crrev.com/7e32110255c41e14b2b307ca6b7fd05b77cff1d9/chrome/browser/chromeos/login/profile_auth_data.cc
[modify] https://crrev.com/7e32110255c41e14b2b307ca6b7fd05b77cff1d9/chrome/browser/chromeos/login/profile_auth_data.h
[modify] https://crrev.com/7e32110255c41e14b2b307ca6b7fd05b77cff1d9/chrome/browser/chromeos/login/profile_auth_data_unittest.cc
[modify] https://crrev.com/7e32110255c41e14b2b307ca6b7fd05b77cff1d9/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/7e32110255c41e14b2b307ca6b7fd05b77cff1d9/net/ssl/channel_id_store.cc
[modify] https://crrev.com/7e32110255c41e14b2b307ca6b7fd05b77cff1d9/net/ssl/channel_id_store.h
[modify] https://crrev.com/7e32110255c41e14b2b307ca6b7fd05b77cff1d9/net/ssl/default_channel_id_store_unittest.cc

Comment 7 by mmenke@chromium.org, Nov 8

Cc: nhar...@chromium.org
 Issue 835429  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/345667b05547f987b32e25f4b8468a6722c9ca5b

commit 345667b05547f987b32e25f4b8468a6722c9ca5b
Author: Nick Harper <nharper@chromium.org>
Date: Sat Dec 01 00:14:54 2018

Remove Channel ID from chrome/browser/browsing_data

Bug: 875053
Change-Id: If25cd61692ec30ef590c8edf67c6960213196ff4
Reviewed-on: https://chromium-review.googlesource.com/c/1351710
Commit-Queue: Nick Harper <nharper@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612866}
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/BrowsingDataBridgeTest.java
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/BUILD.gn
[delete] https://crrev.com/7709f3583fe23ad59253b5560ae268d7ebca1e38/chrome/browser/browsing_data/browsing_data_channel_id_helper.cc
[delete] https://crrev.com/7709f3583fe23ad59253b5560ae268d7ebca1e38/chrome/browser/browsing_data/browsing_data_channel_id_helper.h
[delete] https://crrev.com/7709f3583fe23ad59253b5560ae268d7ebca1e38/chrome/browser/browsing_data/browsing_data_channel_id_helper_unittest.cc
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/browsing_data/cookies_tree_model.cc
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/browsing_data/cookies_tree_model.h
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/browsing_data/cookies_tree_model_unittest.cc
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/browsing_data/counters/site_data_counting_helper.cc
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/browsing_data/counters/site_data_counting_helper.h
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/browsing_data/local_data_container.cc
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/browsing_data/local_data_container.h
[delete] https://crrev.com/7709f3583fe23ad59253b5560ae268d7ebca1e38/chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.cc
[delete] https://crrev.com/7709f3583fe23ad59253b5560ae268d7ebca1e38/chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.h
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/browsing_data/site_data_size_collector.cc
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/browsing_data/site_data_size_collector.h
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/browsing_data/site_data_size_collector_unittest.cc
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/content_settings/local_shared_objects_container.cc
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/content_settings/local_shared_objects_container.h
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/ui/page_info/page_info.cc
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/ui/views/collected_cookies_views.cc
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/ui/webui/cookies_tree_model_util.cc
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/chrome/test/BUILD.gn
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/ios/chrome/browser/browsing_data/browsing_data_remove_mask.h
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/ios/chrome/browser/browsing_data/browsing_data_remover_impl.mm
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/ios/chrome/browser/browsing_data/browsing_data_remover_impl_unittest.mm
[modify] https://crrev.com/345667b05547f987b32e25f4b8468a6722c9ca5b/ios/chrome/browser/ui/settings/settings_egtest.mm
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7f127dc5c83b6f7ceb091d3eddcbab72c035e61

commit b7f127dc5c83b6f7ceb091d3eddcbab72c035e61
Author: Nick Harper <nharper@chromium.org>
Date: Tue Dec 04 19:54:05 2018

Rename URLRequestContextBuilder::SetCookieAndChannelIdStores

Since Channel ID is disabled, setting a ChannelIDService does nothing.
This removes the ChannelIDService argument and renames the method to
SetCookieStore.

Bug: 875053
Change-Id: Ib8b1a6abf1dac76137a61b249feb2faf9354845f
Reviewed-on: https://chromium-review.googlesource.com/c/1325942
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613659}
[modify] https://crrev.com/b7f127dc5c83b6f7ceb091d3eddcbab72c035e61/android_webview/browser/net/aw_url_request_context_getter.cc
[modify] https://crrev.com/b7f127dc5c83b6f7ceb091d3eddcbab72c035e61/components/cronet/cronet_url_request_context.cc
[modify] https://crrev.com/b7f127dc5c83b6f7ceb091d3eddcbab72c035e61/components/cronet/ios/cronet_environment.mm
[modify] https://crrev.com/b7f127dc5c83b6f7ceb091d3eddcbab72c035e61/content/browser/browser_context.cc
[modify] https://crrev.com/b7f127dc5c83b6f7ceb091d3eddcbab72c035e61/content/shell/browser/shell_url_request_context_getter.cc
[modify] https://crrev.com/b7f127dc5c83b6f7ceb091d3eddcbab72c035e61/net/tools/quic/quic_http_proxy_backend.cc
[modify] https://crrev.com/b7f127dc5c83b6f7ceb091d3eddcbab72c035e61/net/url_request/url_request_context_builder.cc
[modify] https://crrev.com/b7f127dc5c83b6f7ceb091d3eddcbab72c035e61/net/url_request/url_request_context_builder.h
[modify] https://crrev.com/b7f127dc5c83b6f7ceb091d3eddcbab72c035e61/services/network/network_context.cc
[modify] https://crrev.com/b7f127dc5c83b6f7ceb091d3eddcbab72c035e61/services/network/network_context_unittest.cc
[modify] https://crrev.com/b7f127dc5c83b6f7ceb091d3eddcbab72c035e61/webrunner/browser/webrunner_url_request_context_getter.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cef156a36f74d36a47cfc3e5744e8016028de313

commit cef156a36f74d36a47cfc3e5744e8016028de313
Author: Christian Dullweber <dullweber@chromium.org>
Date: Mon Dec 10 16:15:46 2018

Remove channel id from Clear-Site-Data

Clear-Site-Data was still trying to delete channel ids, which lead
to a failed DCHECK because channel ids were removed from
FILERABLE_DATATYPES.

Bug: 875053
Change-Id: I23db6a3f763b19523ca17206c546265247f7e35d
Reviewed-on: https://chromium-review.googlesource.com/c/1370167
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615134}
[modify] https://crrev.com/cef156a36f74d36a47cfc3e5744e8016028de313/content/browser/browsing_data/clear_site_data_handler_browsertest.cc
[modify] https://crrev.com/cef156a36f74d36a47cfc3e5744e8016028de313/content/browser/browsing_data/clear_site_data_utils.cc

Comment 13 by jsb...@chromium.org, Dec 10 

Will content::BrowsingDataRemover::DATA_TYPE_CHANNEL_IDS (and associated logic/tests) be getting fully removed as well?

Comment 14 by nhar...@chromium.org, Dec 10 

Yes.

Comment 15 by jsb...@chromium.org, Dec 10 

Awesome! Happy to review (or put up CLs...)

Sanity check: does code exist to delete previously persisted channels, even when this feature is removed? I didn't dig too deeply; poking about tells me this maybe lives in the 'Origin Bound Certs' sqlite instance. Apologies if this is covered in a design doc/other bugs.

Comment 16 by nhar...@chromium.org, Dec 10

Blocking: 903642
The code doesn't exist yet, but crbug.com/903642 is tracking all of the places where we need to delete them.
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7c0c06fb63d18cb3c351e65d0c45a35ec607336

commit b7c0c06fb63d18cb3c351e65d0c45a35ec607336
Author: Nick Harper <nharper@chromium.org>
Date: Sat Jan 12 01:51:36 2019

Remove Channel ID from //extensions

Bug: 875053
Change-Id: I74c99dea56ae944d85f66d12924286ac1b0fac3e
Reviewed-on: https://chromium-review.googlesource.com/c/1325945
Commit-Queue: Nick Harper <nharper@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622257}
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/chrome/browser/extensions/extension_messages_apitest.cc
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/chrome/renderer/extensions/extension_hooks_delegate_unittest.cc
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/browser/api/messaging/BUILD.gn
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/browser/api/messaging/extension_message_port.cc
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/browser/api/messaging/extension_message_port.h
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/browser/api/messaging/message_port.cc
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/browser/api/messaging/message_port.h
[delete] https://crrev.com/09942f4374744a8849dc7cf9c8e4202ab65f47c6/extensions/browser/api/messaging/message_property_provider.cc
[delete] https://crrev.com/09942f4374744a8849dc7cf9c8e4202ab65f47c6/extensions/browser/api/messaging/message_property_provider.h
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/browser/api/messaging/message_service.cc
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/browser/api/messaging/message_service.h
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/browser/extension_message_filter.cc
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/browser/extension_message_filter.h
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/common/extension_messages.h
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/renderer/dispatcher.h
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/renderer/extension_frame_helper.cc
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/renderer/extension_frame_helper.h
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/renderer/ipc_message_sender.cc
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/renderer/js_renderer_messaging_service.cc
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/renderer/js_renderer_messaging_service.h
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/renderer/messaging_bindings.cc
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/renderer/native_renderer_messaging_service.cc
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/renderer/native_renderer_messaging_service.h
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/renderer/native_renderer_messaging_service_unittest.cc
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/renderer/renderer_messaging_service.cc
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/extensions/renderer/renderer_messaging_service.h
[modify] https://crrev.com/b7c0c06fb63d18cb3c351e65d0c45a35ec607336/tools/metrics/histograms/enums.xml
►

Sign in to add a comment