Issue metadata
Sign in to add a comment
|
"PasswordManagerBrowserTestWithViewsFeature" tests are failing on Win,Win64 and Linux64 official.desktop.continuous builders. |
||||||||||||||||||||||
Issue descriptionLink to builders : https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/90622 https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/builds/38502 https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20trunk/builds/11809 Link to Error log : https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Fwin_trunk%2F90622%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FAll_PasswordManagerBrowserTestWithViewsFeature.NoFillGaiaReauthenticationForm_0%2F0# Error : All/PasswordManagerBrowserTestWithViewsFeature.NoFillGaiaReauthenticationForm/0 (run #1): [ RUN ] All/PasswordManagerBrowserTestWithViewsFeature.NoFillGaiaReauthenticationForm/0 [8024:7072:0816/110546.029:WARNING:chrome_browser_main_win.cc(641)] Command line too long for RegisterApplicationRestart: Suspected Cl :https://chromium.googlesource.com/chromium/src/+/015b85bca4c129d883485862c87ee18ca928d2d8
,
Aug 17
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1981459249f021503ac7caf830c1b0c7202ef38a commit 1981459249f021503ac7caf830c1b0c7202ef38a Author: Vadym Doroshenko <dvadym@chromium.org> Date: Fri Aug 17 10:06:24 2018 [Password Manager] Fix browser test. No need to wait a navigation since NavigateToURL waits for navigation completed (it eventually calls NavigateToURLWithDispositionBlockUntilNavigationsComplete). Bug: 875052 Change-Id: I96ebd7d5ec4ce0f676a82f6714816a7ddefb2b08 Reviewed-on: https://chromium-review.googlesource.com/1179160 Reviewed-by: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#584011} [modify] https://crrev.com/1981459249f021503ac7caf830c1b0c7202ef38a/chrome/browser/password_manager/password_manager_browsertest.cc
,
Aug 17
It was just tests problem. I've fixed them.
,
Aug 17
Just to update: Same issue seen on 70.0.3525.0 - Linux 64,Win Clang,Win 64 clang & Win Asan on official.desktop builder and Win trunk, Win64 trunk & Linux trunk on continuous.desktop builder. Link to the builder: -------------------- https://uberchromegw.corp.google.com/i/official.desktop/builders/linux64/builds/1713 https://uberchromegw.corp.google.com/i/official.desktop/builders/win-asan/builds/1068 https://uberchromegw.corp.google.com/i/official.desktop/builders/win-clang/builds/1343 https://uberchromegw.corp.google.com/i/official.desktop/builders/win64-clang/builds/1342 Trunk builder: -------------- https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/90682 https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/builds/38539 https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20trunk/builds/11824
,
Aug 17
70.0.3525.0 is behind the patch from #3
,
Aug 20
This is the fix for https://chromium-review.googlesource.com/c/chromium/src/+/1174714 which is going to be merged to M-69
,
Aug 20
Approving merge to M69 branch 3497 based on comment #7.
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4ef283d1d894e2fb1f29b5b15ea20d239ee920b commit f4ef283d1d894e2fb1f29b5b15ea20d239ee920b Author: Vadym Doroshenko <dvadym@chromium.org> Date: Mon Aug 20 15:41:40 2018 [Password Manager] Fix browser test. No need to wait a navigation since NavigateToURL waits for navigation completed (it eventually calls NavigateToURLWithDispositionBlockUntilNavigationsComplete). TBR=dvadym@chromium.org (cherry picked from commit 1981459249f021503ac7caf830c1b0c7202ef38a) Bug: 875052 Change-Id: I96ebd7d5ec4ce0f676a82f6714816a7ddefb2b08 Reviewed-on: https://chromium-review.googlesource.com/1179160 Reviewed-by: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#584011} Reviewed-on: https://chromium-review.googlesource.com/1181361 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#711} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/f4ef283d1d894e2fb1f29b5b15ea20d239ee920b/chrome/browser/password_manager/password_manager_browsertest.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pbomm...@chromium.org
, Aug 16