This is a tracking bug for the deprecation and removal of Token Binding. blink-dev Intent thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/OkdLUyYmY1E/discussion The planned timeline is to remove the base::Feature controlling Token Binding in M70, and then remove the Token Binding code in M71.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf5a6c6a39cf3450942309115f78152fd297faba commit cf5a6c6a39cf3450942309115f78152fd297faba Author: Nick Harper <nharper@chromium.org> Date: Mon Aug 20 19:34:03 2018 Remove features::kTokenBinding Bug: 875046 Change-Id: I1926513d3b4ad703306a7ff291ac7a9e7e47966b Reviewed-on: https://chromium-review.googlesource.com/1178980 Reviewed-by: Bence Béky <bnc@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#584532} [modify] https://crrev.com/cf5a6c6a39cf3450942309115f78152fd297faba/chrome/browser/about_flags.cc [modify] https://crrev.com/cf5a6c6a39cf3450942309115f78152fd297faba/chrome/browser/extensions/extension_messages_apitest.cc [modify] https://crrev.com/cf5a6c6a39cf3450942309115f78152fd297faba/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/cf5a6c6a39cf3450942309115f78152fd297faba/chrome/browser/flag_descriptions.h [modify] https://crrev.com/cf5a6c6a39cf3450942309115f78152fd297faba/components/network_session_configurator/browser/network_session_configurator.cc [modify] https://crrev.com/cf5a6c6a39cf3450942309115f78152fd297faba/components/network_session_configurator/browser/network_session_configurator_unittest.cc [modify] https://crrev.com/cf5a6c6a39cf3450942309115f78152fd297faba/components/network_session_configurator/common/network_features.cc [modify] https://crrev.com/cf5a6c6a39cf3450942309115f78152fd297faba/components/network_session_configurator/common/network_features.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2243e8002e3025b3f8386c13be7437fc8b597e2a commit 2243e8002e3025b3f8386c13be7437fc8b597e2a Author: Nick Harper <nharper@chromium.org> Date: Fri Sep 28 20:33:26 2018 Remove support for Token Binding This removes most Token Binding code from chromium. There are a few places that still have Token Binding references (but will go unused) that can possibly be removed in the future. These are: - android_webview/ - net/third_party/quic/ - third_party/tlslite/ There are two UMA histograms in //net that also have TokenBinding in their name; these are (confusingly) used by Channel ID code as part of the work on debugging Channel ID mismatches, and can be removed with the rest of the Channel ID code. Bug: 875046 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ie3d23f8e9580f2d582febfb04e777006f57baa17 Reviewed-on: https://chromium-review.googlesource.com/1248125 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#595197} [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/components/network_session_configurator/browser/network_session_configurator_unittest.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/content/browser/devtools/devtools_url_loader_interceptor.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/content/browser/loader/navigation_url_loader_impl.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/content/browser/service_worker/service_worker_navigation_loader.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/content/common/common_param_traits_unittest.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/content/common/service_worker/service_worker_loader_helpers.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/content/common/service_worker/service_worker_loader_helpers.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/content/renderer/service_worker/service_worker_subresource_loader.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/extensions/browser/api/messaging/message_property_provider.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/headless/test/test_network_interceptor.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/BUILD.gn [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/http/http_basic_stream.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/http/http_basic_stream.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/http/http_network_session.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/http/http_network_session.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/http/http_network_transaction.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/http/http_network_transaction.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/http/http_network_transaction_ssl_unittest.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/http/http_network_transaction_unittest.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/http/http_proxy_client_socket_wrapper_unittest.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/http/http_request_headers.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/http/http_request_headers.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/http/http_request_info.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/http/http_response_body_drainer_unittest.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/http/http_stream.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/http/http_stream_factory_unittest.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/http/http_stream_parser.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/http/http_stream_parser.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/http/proxy_connect_redirect_http_stream.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/http/proxy_connect_redirect_http_stream.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/log/net_log_event_type_list.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/quic/quic_chromium_client_session.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/quic/quic_chromium_client_session.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/quic/quic_end_to_end_unittest.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/quic/quic_stream_factory.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/quic/quic_stream_factory.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/quic/quic_stream_factory_fuzzer.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/quic/quic_stream_factory_test.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/socket/fuzzed_socket_factory.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/socket/socket_test_util.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/socket/socket_test_util.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/socket/ssl_client_socket.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/socket/ssl_client_socket_impl.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/socket/ssl_client_socket_impl.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/socket/ssl_client_socket_unittest.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/socket/stream_socket.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/socket/stream_socket.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/spdy/multiplexed_http_stream.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/spdy/multiplexed_http_stream.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/spdy/multiplexed_session.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/spdy/multiplexed_session.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/spdy/spdy_session.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/spdy/spdy_session.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/spdy/spdy_stream.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/spdy/spdy_stream.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/ssl/ssl_config.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/ssl/ssl_info.h [delete] https://crrev.com/948e60271bbd01695e317c0d2bb8be041e2e73db/net/ssl/token_binding.cc [delete] https://crrev.com/948e60271bbd01695e317c0d2bb8be041e2e73db/net/ssl/token_binding.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/test/spawned_test_server/base_test_server.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/test/spawned_test_server/base_test_server.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/tools/testserver/testserver.py [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/url_request/redirect_info.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/url_request/redirect_info.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/url_request/redirect_info_unittest.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/url_request/url_request.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/url_request/url_request.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/url_request/url_request_http_job.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/url_request/url_request_job.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/url_request/url_request_unittest.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/websockets/websocket_basic_handshake_stream.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/websockets/websocket_basic_handshake_stream.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/websockets/websocket_http2_handshake_stream.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/net/websockets/websocket_http2_handshake_stream.h [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/services/network/public/cpp/net_ipc_param_traits.cc [modify] https://crrev.com/2243e8002e3025b3f8386c13be7437fc8b597e2a/services/network/public/cpp/net_ipc_param_traits.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/892d57c8fd3e5c3148c78136567ba23f4f7a507e commit 892d57c8fd3e5c3148c78136567ba23f4f7a507e Author: Nick Harper <nharper@chromium.org> Date: Wed Nov 28 19:47:16 2018 Remove TokenBinding fieldtrial config The token binding feature was removed in crrev.com/584532 (M70) - this is overdue for being removed. Bug: 875046 Change-Id: I121028692ba02602c54077401dc15eb176c8e67b Reviewed-on: https://chromium-review.googlesource.com/c/1351712 Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#611827} [modify] https://crrev.com/892d57c8fd3e5c3148c78136567ba23f4f7a507e/testing/variations/fieldtrial_testing_config.json
Comment 1 by bugdroid1@chromium.org
, Aug 20