New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 875032 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 837753



Sign in to add a comment

libjingle injected with Profile::GetRequestContext() result via ProfileInvalidationProviderFactory / TiclInvalidationService

Project Member Reported by morlovich@chromium.org, Aug 16

Issue description

There seems to be a code path that uses browser-side URLRequestContextGetter gotten by Profile::GetRequestContext()  and injects it into code in libjingle.

chrome/browser/invalidation/profile_invalidation_provider_factory.cc:
ProfileInvalidationProviderFactory::BuildServiceInstanceFor:
    std::unique_ptr<TiclInvalidationService> service =
        std::make_unique<TiclInvalidationService>(
            ...
            profile->GetRequestContext(),
            ...)

.... This is feature-flag guarded, but the feature that disables this code path is DISABLED_BY_DEFAULT

components/invalidation/impl/ticl_invalidation_service.cc:
TiclInvalidationService::StartInvalidator:
       ...
      options.request_context_getter = request_context_;
      ...
      network_channel_creator =
          syncer::NonBlockingInvalidator::MakePushClientChannelCreator(options)

The options here is a jingle/notifier/base/notifier_options.h; MakePushClientChannelCreator 
wraps the following in a callback:

components/invalidation/impl/sync_system_resources.cc:

std::unique_ptr<SyncNetworkChannel> SyncNetworkChannel::CreatePushClientChannel(
    const notifier::NotifierOptions& notifier_options) {
  std::unique_ptr<notifier::PushClient> push_client(
      notifier::PushClient::CreateDefaultOnIOThread(notifier_options));
  return std::make_unique<PushClientChannel>(std::move(push_client));
}

notifier::PushClient::CreateDefaultOnIOThread is in jingle/notifier/listener/push_client.cc,
and creates an XmppPushClient, wiring the URLRequestContext


(Tentatively marking as important)

 
This looks like to be a libjingle XMPP path. I thought only remoting host (a separate binary) uses it, but looks like it is a dependency of chrome, and I've missed it. 

This needs someone to investigate and remove the URLRequestContext dependency.
Cc: reillyg@chromium.org dxie@chromium.org
@dxie: that's the one that was worriying me. 
@reillyg: the factory has the word "sync" in it, but I don't know what this actually does.


Labels: OS-Windows
Labels: OS-Android OS-Chrome OS-Linux OS-Mac
Components: Services>Sync
The XMPP connection is used to deliver notifications to the browser, I presume when sync data changes.
Owner: morlovich@chromium.org
Status: Assigned (was: Untriaged)
maks, can you help investigate?
Cc: melandory@chromium.org
[+melandory working on invalidations for sync]
Can someone on the bug explain the problem you're looking into a bit?
High-level is that we are working on moving the network stack to a separate process (from browser), so the APIs used for a bunch of things change to different ones (backed by Mojo), which work both in- and out- of process. A good sign of things that are not going to work in the new world is the use of URLRequestContext[Getter] classes.

This code is actually pretty close, since relevant the new API is based on jingle's ProxyResolvingClientSocket in the first place (see https://chromium-review.googlesource.com/763651), it just needs to be changed from directly constructing an instance configured via URLRequestContext and using it via simple calls to building one via a maybe-IPC to a network::mojom::NetworkContext and using a mojo handle to it instead of unique-ptr type things. 

Probably pretty similar to this CL: https://chromium.googlesource.com/chromium/src/+/5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2 (probably a better reference to me than you..)

@dxie: this may actually end up taking a while, the new API is quite a bit lower-level than I expected..
curious: is this code opening sockets or making URLFetcheer requests (or something else)?
Status: Started (was: Assigned)
Sockets, so I need to port code using a net::StreamSocket to one that's using a couple of mojo pipes + a couple of mojo::SimpleWatchers.  Not too big of a deal, but more than what I first expected. 
Cool, thanks for investigating. Sockets work fine from inside the browser process, so similar to  bug 848078  and bug 806817, we can go to canary with them making requests in the browser.
(e.g. so if this isn't done by Friday, no worries)
One of them is a proxy resolving socket, so won't work right with some proxy configurations. 
Labels: -Proj-Servicification-Canary
punting out of canary.
Labels: Hotlist-KnownIssue
So ProfileInvalidationProviderFactory above is suddenly DeprecatedProfileInvalidationProviderFactory; but there seems to be at least one non-test/non-tools used via ChromeOS's AffiliatedInvalidationServiceProviderImpl.  

Status: in progress of adding TLS upgrade capability to proxied sockets, which is a pre-req.

Labels: -Hotlist-KnownIssue
Project Member

Comment 20 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38ff96864e0074164a662be11b0687918984b0fc

commit 38ff96864e0074164a662be11b0687918984b0fc
Author: Maks Orlovich <morlovich@chromium.org>
Date: Wed Sep 05 18:25:57 2018

Add support for TLS upgrade on proxied sockets as well

This is used by the XMPPClient in jingle/

This was done as follows:
1) Split out TLS socket creation from SocketFactory into TLSSocketFactory,
   make SocketFactory own one instead; move some of the upgrade code from
   TCPConnectedSocket into TLSSocketFactory as well.
2) Permit injection of a custom net::HttpNetworkSession::Context into
   TLSSocketFactory
3) Make ProxyResolvingSocketFactoryMojo have a TLSSocketFactory hooked up
   to its HttpNetworkSession.
4) Add an UpgradeToTLS method to proxy_resolving_socket.mojom and implement
   it in ProxyResolvingSocketMojo using TLSSocketFactory

Most of the pre-existing TLSClientSocket tests covering upgrades were then
reworked to test the new ProxyResolvingSocket path along with the pre-existing
TCPConnectedSocket path.

Bug:  875032 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I75d8bb2cd7245e459d46bc70a61dac782c7e355d
Reviewed-on: https://chromium-review.googlesource.com/1191102
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588940}
[modify] https://crrev.com/38ff96864e0074164a662be11b0687918984b0fc/services/network/BUILD.gn
[modify] https://crrev.com/38ff96864e0074164a662be11b0687918984b0fc/services/network/proxy_resolving_client_socket_factory.h
[modify] https://crrev.com/38ff96864e0074164a662be11b0687918984b0fc/services/network/proxy_resolving_socket_factory_mojo.cc
[modify] https://crrev.com/38ff96864e0074164a662be11b0687918984b0fc/services/network/proxy_resolving_socket_factory_mojo.h
[modify] https://crrev.com/38ff96864e0074164a662be11b0687918984b0fc/services/network/proxy_resolving_socket_mojo.cc
[modify] https://crrev.com/38ff96864e0074164a662be11b0687918984b0fc/services/network/proxy_resolving_socket_mojo.h
[modify] https://crrev.com/38ff96864e0074164a662be11b0687918984b0fc/services/network/public/mojom/proxy_resolving_socket.mojom
[modify] https://crrev.com/38ff96864e0074164a662be11b0687918984b0fc/services/network/socket_factory.cc
[modify] https://crrev.com/38ff96864e0074164a662be11b0687918984b0fc/services/network/socket_factory.h
[modify] https://crrev.com/38ff96864e0074164a662be11b0687918984b0fc/services/network/tcp_connected_socket.cc
[modify] https://crrev.com/38ff96864e0074164a662be11b0687918984b0fc/services/network/tcp_connected_socket.h
[modify] https://crrev.com/38ff96864e0074164a662be11b0687918984b0fc/services/network/tls_client_socket_unittest.cc
[add] https://crrev.com/38ff96864e0074164a662be11b0687918984b0fc/services/network/tls_socket_factory.cc
[add] https://crrev.com/38ff96864e0074164a662be11b0687918984b0fc/services/network/tls_socket_factory.h

Labels: -Pri-1 Proj-Servicification-Stable Pri-2
Labels: Hotlist-KnownIssue
Project Member

Comment 23 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45b44c5dd37079cf6fb464e46c82d4c808a007af

commit 45b44c5dd37079cf6fb464e46c82d4c808a007af
Author: Maks Orlovich <morlovich@chromium.org>
Date: Fri Sep 21 19:55:17 2018

ProxyResolvingSocket[Factory]: Add SocketObserver support.

Bug:  875032 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I087bd6a9b62f05ccb853db4e5b04639fab0e4e83
Reviewed-on: https://chromium-review.googlesource.com/1238795
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593307}
[modify] https://crrev.com/45b44c5dd37079cf6fb464e46c82d4c808a007af/google_apis/gcm/base/socket_stream_unittest.cc
[modify] https://crrev.com/45b44c5dd37079cf6fb464e46c82d4c808a007af/google_apis/gcm/engine/connection_factory_impl.cc
[modify] https://crrev.com/45b44c5dd37079cf6fb464e46c82d4c808a007af/google_apis/gcm/engine/connection_handler_impl_unittest.cc
[modify] https://crrev.com/45b44c5dd37079cf6fb464e46c82d4c808a007af/services/network/proxy_resolving_socket_factory_mojo.cc
[modify] https://crrev.com/45b44c5dd37079cf6fb464e46c82d4c808a007af/services/network/proxy_resolving_socket_factory_mojo.h
[modify] https://crrev.com/45b44c5dd37079cf6fb464e46c82d4c808a007af/services/network/proxy_resolving_socket_mojo.cc
[modify] https://crrev.com/45b44c5dd37079cf6fb464e46c82d4c808a007af/services/network/proxy_resolving_socket_mojo.h
[modify] https://crrev.com/45b44c5dd37079cf6fb464e46c82d4c808a007af/services/network/proxy_resolving_socket_mojo_unittest.cc
[modify] https://crrev.com/45b44c5dd37079cf6fb464e46c82d4c808a007af/services/network/public/mojom/proxy_resolving_socket.mojom
[modify] https://crrev.com/45b44c5dd37079cf6fb464e46c82d4c808a007af/services/network/tls_client_socket_unittest.cc

Cc: mmenke@chromium.org sergeyu@chromium.org morlovich@chromium.org zea@chromium.org
 Issue 894089  has been merged into this issue.
Project Member

Comment 25 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9e9707624e31ee919d4ae7724dd45ee9d2b5e21

commit d9e9707624e31ee919d4ae7724dd45ee9d2b5e21
Author: Maks Orlovich <morlovich@chromium.org>
Date: Wed Oct 31 02:05:32 2018

jingle_glue: Prep CL to make migrating to NetworkService easier

This CL's contents are entirely:
cp chrome_async_socket.cc network_service_async_socket.cc
cp chrome_async_socket.h network_service_async_socket.h
cp chrome_async_socket_unittest.cc network_service_async_socket_unittest.cc

... done as a separate change so that the CL making the actual porting
changes gets a usable diff between net and NetworkService versions of code.
The "new" files are not included in compilation and this is meant to be
landed together with
https://chromium-review.googlesource.com/c/chromium/src/+/1232034

Bug:  875032 
Change-Id: Idcdc85125c910662e642258adb71d58406752a64
Reviewed-on: https://chromium-review.googlesource.com/c/1237214
Reviewed-by: Nicolas Zea <zea@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604113}
[add] https://crrev.com/d9e9707624e31ee919d4ae7724dd45ee9d2b5e21/jingle/glue/network_service_async_socket.cc
[add] https://crrev.com/d9e9707624e31ee919d4ae7724dd45ee9d2b5e21/jingle/glue/network_service_async_socket.h
[add] https://crrev.com/d9e9707624e31ee919d4ae7724dd45ee9d2b5e21/jingle/glue/network_service_async_socket_unittest.cc

Hey, just wanted to give a heads up about Ticl* future.

Chrome Sync is migrating out of Ticl*. It's planned to stop using it Q4-2018/Q1-2019

Although, there will be two other clients of Ticl*, I'd expect that they'll migrate out of it by Q1-2018.
Thanks. I think there is some other stuff using XmppPushClient, though?
Project Member

Comment 28 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1b1bcd1a101e9cce0cfe7432af704aed7f11063

commit a1b1bcd1a101e9cce0cfe7432af704aed7f11063
Author: Maks Orlovich <morlovich@chromium.org>
Date: Thu Nov 01 02:25:21 2018

jingle_glue: Add a NetworkService equivalent of ChromeAsyncSocket

The former will have some problems with some proxy setups once the Network Service
is on, so this introduces a replacement. This CL doesn't hook it up to anything,
just builds & tests it. Next steps would require an equivalent to FakeSSLClientSocket,
and then actually hooking those up and wiring the different injected config from
Chrome.

To ease the review of this somewhat, this CL was split in two, with
https://chromium-review.googlesource.com/c/chromium/src/+/1237214
just copying over ChomeAsyncSocket and its tests to new files, to produce something of
a meaningful diff. (Thanks to lassey@ for the idea)

Bug:  875032 
Change-Id: Ic5d4e4276c993e0e70f059d485b9d34aeab41e6d
Reviewed-on: https://chromium-review.googlesource.com/c/1232034
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604490}
[modify] https://crrev.com/a1b1bcd1a101e9cce0cfe7432af704aed7f11063/jingle/BUILD.gn
[modify] https://crrev.com/a1b1bcd1a101e9cce0cfe7432af704aed7f11063/jingle/DEPS
[modify] https://crrev.com/a1b1bcd1a101e9cce0cfe7432af704aed7f11063/jingle/glue/DEPS
[modify] https://crrev.com/a1b1bcd1a101e9cce0cfe7432af704aed7f11063/jingle/glue/network_service_async_socket.cc
[modify] https://crrev.com/a1b1bcd1a101e9cce0cfe7432af704aed7f11063/jingle/glue/network_service_async_socket.h
[modify] https://crrev.com/a1b1bcd1a101e9cce0cfe7432af704aed7f11063/jingle/glue/network_service_async_socket_unittest.cc
[add] https://crrev.com/a1b1bcd1a101e9cce0cfe7432af704aed7f11063/jingle/run_all_unittests.cc

Project Member

Comment 30 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f86fe2027aebb1ae3647a745ccab902e2eb73a5

commit 5f86fe2027aebb1ae3647a745ccab902e2eb73a5
Author: Maks Orlovich <morlovich@chromium.org>
Date: Mon Nov 05 18:55:47 2018

ProxyResolvingSocketFactory: support "fake SSL" mode for XMPP.

This is arguably way too weird to have at this level, but
jingle_glue::FakesSSLClientSocket is already pulled in via
services/network/p2p, and the alternative would require hundreds
of lines of new code to implement rather than basically a single
if statement.

Bug:  875032 
Change-Id: I6fa2007b907378e43f1a619112f812e3d0bbfd50
Reviewed-on: https://chromium-review.googlesource.com/c/1310638
Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605399}
[modify] https://crrev.com/5f86fe2027aebb1ae3647a745ccab902e2eb73a5/google_apis/gcm/base/socket_stream_unittest.cc
[modify] https://crrev.com/5f86fe2027aebb1ae3647a745ccab902e2eb73a5/google_apis/gcm/engine/connection_factory_impl.cc
[modify] https://crrev.com/5f86fe2027aebb1ae3647a745ccab902e2eb73a5/google_apis/gcm/engine/connection_handler_impl_unittest.cc
[modify] https://crrev.com/5f86fe2027aebb1ae3647a745ccab902e2eb73a5/jingle/glue/fake_ssl_client_socket.cc
[modify] https://crrev.com/5f86fe2027aebb1ae3647a745ccab902e2eb73a5/jingle/glue/fake_ssl_client_socket.h
[modify] https://crrev.com/5f86fe2027aebb1ae3647a745ccab902e2eb73a5/jingle/glue/network_service_async_socket.cc
[modify] https://crrev.com/5f86fe2027aebb1ae3647a745ccab902e2eb73a5/jingle/glue/network_service_async_socket.h
[modify] https://crrev.com/5f86fe2027aebb1ae3647a745ccab902e2eb73a5/jingle/glue/network_service_async_socket_unittest.cc
[modify] https://crrev.com/5f86fe2027aebb1ae3647a745ccab902e2eb73a5/services/network/DEPS
[modify] https://crrev.com/5f86fe2027aebb1ae3647a745ccab902e2eb73a5/services/network/proxy_resolving_socket_factory_mojo.cc
[modify] https://crrev.com/5f86fe2027aebb1ae3647a745ccab902e2eb73a5/services/network/proxy_resolving_socket_factory_mojo.h
[modify] https://crrev.com/5f86fe2027aebb1ae3647a745ccab902e2eb73a5/services/network/proxy_resolving_socket_mojo.cc
[modify] https://crrev.com/5f86fe2027aebb1ae3647a745ccab902e2eb73a5/services/network/proxy_resolving_socket_mojo.h
[modify] https://crrev.com/5f86fe2027aebb1ae3647a745ccab902e2eb73a5/services/network/proxy_resolving_socket_mojo_unittest.cc
[modify] https://crrev.com/5f86fe2027aebb1ae3647a745ccab902e2eb73a5/services/network/public/mojom/proxy_resolving_socket.mojom
[modify] https://crrev.com/5f86fe2027aebb1ae3647a745ccab902e2eb73a5/services/network/tls_client_socket_unittest.cc

Blocking: 837753
Project Member

Comment 32 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef5d1c835024b2b35ad3f93578af4b6db1cbb977

commit ef5d1c835024b2b35ad3f93578af4b6db1cbb977
Author: Maks Orlovich <morlovich@chromium.org>
Date: Thu Nov 29 22:01:44 2018

XmppClient: switch to NetworkServiceAsyncSocket

... and adjust clients to pass in the proper configuration for that.
Rather than using URLRequestContextGetter-based ChromeAsyncSocket,
which may not always work right with network service on.

Bug:  875032 
Change-Id: I3f2c19f35c97d770eb63da94755f9d1d42b58bc9
Reviewed-on: https://chromium-review.googlesource.com/c/1315948
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612395}
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/chrome/browser/chromeos/policy/affiliated_invalidation_service_provider_impl.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/chrome/browser/invalidation/deprecated_profile_invalidation_provider_factory.cc
[add] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/chrome/browser/sync/test/integration/DEPS
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/chrome/browser/sync/test/integration/sync_test.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/chrome/service/cloud_print/cloud_print_proxy_backend.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/components/invalidation/impl/DEPS
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/components/invalidation/impl/non_blocking_invalidator_unittest.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/components/invalidation/impl/p2p_invalidation_service.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/components/invalidation/impl/p2p_invalidation_service.h
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/components/invalidation/impl/ticl_invalidation_service.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/components/invalidation/impl/ticl_invalidation_service.h
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/components/invalidation/impl/ticl_invalidation_service_unittest.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/components/invalidation/impl/ticl_profile_settings_provider_unittest.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/ios/chrome/browser/invalidation/ios_chrome_deprecated_profile_invalidation_provider_factory.mm
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/ios/web_view/internal/sync/web_view_profile_invalidation_provider_factory.mm
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/BUILD.gn
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/DEPS
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/glue/DEPS
[delete] https://crrev.com/92925c667f1644dc64e031a120b11c3d86eb3cc6/jingle/glue/chrome_async_socket.cc
[delete] https://crrev.com/92925c667f1644dc64e031a120b11c3d86eb3cc6/jingle/glue/chrome_async_socket.h
[delete] https://crrev.com/92925c667f1644dc64e031a120b11c3d86eb3cc6/jingle/glue/chrome_async_socket_unittest.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/glue/network_service_async_socket.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/glue/network_service_async_socket.h
[add] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/glue/network_service_config.cc
[add] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/glue/network_service_config.h
[add] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/glue/network_service_config_test_util.cc
[add] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/glue/network_service_config_test_util.h
[delete] https://crrev.com/92925c667f1644dc64e031a120b11c3d86eb3cc6/jingle/glue/resolving_client_socket_factory.h
[delete] https://crrev.com/92925c667f1644dc64e031a120b11c3d86eb3cc6/jingle/glue/xmpp_client_socket_factory.cc
[delete] https://crrev.com/92925c667f1644dc64e031a120b11c3d86eb3cc6/jingle/glue/xmpp_client_socket_factory.h
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/notifier/base/notifier_options.h
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/notifier/base/xmpp_connection.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/notifier/base/xmpp_connection.h
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/notifier/base/xmpp_connection_unittest.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/notifier/communicator/login.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/notifier/communicator/login.h
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/notifier/communicator/login_settings.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/notifier/communicator/login_settings.h
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/notifier/communicator/login_settings_unittest.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/notifier/communicator/single_login_attempt.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/notifier/communicator/single_login_attempt_unittest.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/notifier/listener/push_client.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/notifier/listener/push_client_unittest.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/notifier/listener/xmpp_push_client.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/jingle/notifier/listener/xmpp_push_client_unittest.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/remoting/client/BUILD.gn
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/remoting/host/BUILD.gn
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/services/network/transitional_url_loader_factory_owner.cc
[modify] https://crrev.com/ef5d1c835024b2b35ad3f93578af4b6db1cbb977/services/network/transitional_url_loader_factory_owner.h

Status: Fixed (was: Started)

Sign in to add a comment