New issue
Advanced search Search tips

Issue 875021 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 28
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Use time_t for times in data structures

Project Member Reported by zentaro@chromium.org, Aug 16

Issue description

Some of the data structures in our fakes and tests just assume that time_t is 64 bit.

Need to replace them with the correct time_t type and remove the test that has a test value > int32_max
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9ce47d071137e31a67e1901990acf564d5eea034

commit 9ce47d071137e31a67e1901990acf564d5eea034
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Thu Aug 16 23:20:54 2018

smbprovider: Change test date values to fit in 32 bits

- Some of the test values are >int32_max and on some platforms
  time_t is only 32 bits
- Follow up CL will update FakeDirectory and FakeFile to use the
  correct data type (time_t)

BUG= chromium:875021 
TEST=unittests

Change-Id: Ib652c318a7b1d51e2de6e7391456490535270d59
Reviewed-on: https://chromium-review.googlesource.com/1178693
Reviewed-by: May Lippert <maybelle@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>

[modify] https://crrev.com/9ce47d071137e31a67e1901990acf564d5eea034/smbprovider/iterator/directory_iterator_test.cc
[modify] https://crrev.com/9ce47d071137e31a67e1901990acf564d5eea034/smbprovider/fake_samba_test.cc
[modify] https://crrev.com/9ce47d071137e31a67e1901990acf564d5eea034/smbprovider/iterator/caching_iterator_test.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/a7180be99c628adb2c9c33227d769c3dd5fce044

commit a7180be99c628adb2c9c33227d769c3dd5fce044
Author: Zentaro Kavanagh <zentaro@chromium.org>
Date: Fri Aug 17 18:18:07 2018

smbprovider: Use time_t in Fake data structures

- The fakes and tests assumed time was 64 bits
- Replace uint64_t with time_t in fakes/tests

BUG= chromium:875021 
TEST=unittests

Change-Id: If07673be07dcfff8f5793b69749d69e4b49ff7b5
Reviewed-on: https://chromium-review.googlesource.com/1178744
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: May Lippert <maybelle@chromium.org>

[modify] https://crrev.com/a7180be99c628adb2c9c33227d769c3dd5fce044/smbprovider/fake_samba_interface.h
[modify] https://crrev.com/a7180be99c628adb2c9c33227d769c3dd5fce044/smbprovider/iterator/directory_iterator_test.cc
[modify] https://crrev.com/a7180be99c628adb2c9c33227d769c3dd5fce044/smbprovider/fake_samba_interface.cc
[modify] https://crrev.com/a7180be99c628adb2c9c33227d769c3dd5fce044/smbprovider/iterator/caching_iterator_test.cc
[modify] https://crrev.com/a7180be99c628adb2c9c33227d769c3dd5fce044/smbprovider/fake_samba_test.cc

Status: Fixed (was: Started)

Sign in to add a comment