Use time_t for times in data structures |
||
Issue descriptionSome of the data structures in our fakes and tests just assume that time_t is 64 bit. Need to replace them with the correct time_t type and remove the test that has a test value > int32_max
,
Aug 17
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a7180be99c628adb2c9c33227d769c3dd5fce044 commit a7180be99c628adb2c9c33227d769c3dd5fce044 Author: Zentaro Kavanagh <zentaro@chromium.org> Date: Fri Aug 17 18:18:07 2018 smbprovider: Use time_t in Fake data structures - The fakes and tests assumed time was 64 bits - Replace uint64_t with time_t in fakes/tests BUG= chromium:875021 TEST=unittests Change-Id: If07673be07dcfff8f5793b69749d69e4b49ff7b5 Reviewed-on: https://chromium-review.googlesource.com/1178744 Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org> Tested-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: May Lippert <maybelle@chromium.org> [modify] https://crrev.com/a7180be99c628adb2c9c33227d769c3dd5fce044/smbprovider/fake_samba_interface.h [modify] https://crrev.com/a7180be99c628adb2c9c33227d769c3dd5fce044/smbprovider/iterator/directory_iterator_test.cc [modify] https://crrev.com/a7180be99c628adb2c9c33227d769c3dd5fce044/smbprovider/fake_samba_interface.cc [modify] https://crrev.com/a7180be99c628adb2c9c33227d769c3dd5fce044/smbprovider/iterator/caching_iterator_test.cc [modify] https://crrev.com/a7180be99c628adb2c9c33227d769c3dd5fce044/smbprovider/fake_samba_test.cc
,
Aug 28
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Aug 16