New issue
Advanced search Search tips

Issue 875009 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

virtual/enable_wasm_streaming/http/tests/wasm_streaming/wasm_response_apis.html crashes

Project Member Reported by xidac...@chromium.org, Aug 16

Issue description

Components: Blink>JavaScript>WebAssembly
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46148d32d76702d301d09bf3a862c6d795f20685

commit 46148d32d76702d301d09bf3a862c6d795f20685
Author: Xida Chen <xidachen@chromium.org>
Date: Thu Aug 16 19:26:14 2018

Mark virtual/enable_wasm_streaming/http/tests/wasm_streaming/wasm_response_apis.html flaky

TBR=wjmaclean@chromium.org
NOTRY=true

Bug:  875009 
Change-Id: I23b70833a3a328c4a58e788f324d8f17296a50f7
Reviewed-on: https://chromium-review.googlesource.com/1178684
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583770}
[modify] https://crrev.com/46148d32d76702d301d09bf3a862c6d795f20685/third_party/WebKit/LayoutTests/TestExpectations

Owner: bbudge@chromium.org
I'm not working on wasm anymore. Assigning it to bbudge@ for further triaging.
Cc: bbudge@chromium.org
Owner: adamk@chromium.org
Status: Started (was: Assigned)
The flakiness dashboard link doesn't work for me (in the console, I see "No master and builder found for webkit_tests").

That said, the WebAssemblyStreaming runtime flag is "experimental", which means that the virtual test suite virtual/enable_wasm_streaming/ is identical to the non-virtual version.

I'm currently deleting the test suite, and given that I don't see any expectation for the non-virtual version of the test, it seems that this expectation is stale (so I'll remove it as part of removing the suite).
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3

commit 2247aec8d4c5ef9d93009d9e30a135c5d4e587a3
Author: Adam Klein <adamk@chromium.org>
Date: Fri Sep 21 22:53:41 2018

Remove WebAssemblyStreaming runtime flag

This flag has been enabled by default for quite some time now.

Bug:  642912 ,  875009 , v8:8015
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I2d1638c4b93eeff8e864eb7dbdc360b34e02e526
Reviewed-on: https://chromium-review.googlesource.com/1239335
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593362}
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/chrome/browser/about_flags.cc
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/content/child/runtime_features.cc
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/content/public/common/content_features.cc
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/content/public/common/content_features.h
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/337471139a22264cf842b0555117ca70627b9660/third_party/WebKit/LayoutTests/virtual/enable_wasm_streaming/README.txt
[delete] https://crrev.com/337471139a22264cf842b0555117ca70627b9660/third_party/WebKit/LayoutTests/virtual/enable_wasm_streaming/http/tests/wasm_streaming/README.txt
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/third_party/blink/renderer/bindings/core/v8/v8_wasm_response_extensions.cc
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/2247aec8d4c5ef9d93009d9e30a135c5d4e587a3/third_party/blink/renderer/platform/runtime_enabled_features.json5

Status: Fixed (was: Started)

Sign in to add a comment