New issue
Advanced search Search tips

Issue 875008 link

Starred by 0 users
Status: Fixed
Owner:
saklein@chromium.org
Closed: Oct 24
Cc:
vapier@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

install_toolchain: move to chromite

Project Member Reported by vapier@chromium.org, Aug 16 
we should be able to do a straight port to chromite.  steps:
(1) implement chromite/scripts/install_toolchain.py that provides same functionality as src/scripts/install_toolchain
(2) update any callers to use new chromite path (use cs/ to find callers)
(3) delete install_toolchain from src/scripts/

Comment 1 by saklein@chromium.org, Aug 24

Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/9f93b48183984e5a6743180ca6cf451a0f5c0c29

commit 9f93b48183984e5a6743180ca6cf451a0f5c0c29
Author: Alex Klein <saklein@chromium.org>
Date: Tue Oct 02 12:19:34 2018

portage_util: expand CPV handling.

The inclusion of cpv and cp fields in the CPV object allows simplifying
a number of locations thoughout the code, and ensures a consistent
buildout of those fields.

BUG= chromium:875008 
TEST=new tests, run_tests

Change-Id: I207d18d0694e2831741e0bc110e11d1b10c47e02
Reviewed-on: https://chromium-review.googlesource.com/1255182
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/9f93b48183984e5a6743180ca6cf451a0f5c0c29/cbuildbot/stages/sdk_stages_unittest.py
[modify] https://crrev.com/9f93b48183984e5a6743180ca6cf451a0f5c0c29/scripts/cros_check_patches.py
[modify] https://crrev.com/9f93b48183984e5a6743180ca6cf451a0f5c0c29/cli/deploy.py
[modify] https://crrev.com/9f93b48183984e5a6743180ca6cf451a0f5c0c29/lib/portage_util.py
[modify] https://crrev.com/9f93b48183984e5a6743180ca6cf451a0f5c0c29/scripts/cros_extract_deps.py
[modify] https://crrev.com/9f93b48183984e5a6743180ca6cf451a0f5c0c29/cbuildbot/prebuilts.py
[modify] https://crrev.com/9f93b48183984e5a6743180ca6cf451a0f5c0c29/scripts/upload_prebuilts.py
[modify] https://crrev.com/9f93b48183984e5a6743180ca6cf451a0f5c0c29/lib/portage_util_unittest.py
[modify] https://crrev.com/9f93b48183984e5a6743180ca6cf451a0f5c0c29/lib/triage_lib.py
[modify] https://crrev.com/9f93b48183984e5a6743180ca6cf451a0f5c0c29/cbuildbot/afdo_unittest.py
[modify] https://crrev.com/9f93b48183984e5a6743180ca6cf451a0f5c0c29/licensing/licenses_lib.py
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/7078e2599b7b5609a70a6ca6156e1a3040f44705

commit 7078e2599b7b5609a70a6ca6156e1a3040f44705
Author: Alex Klein <saklein@chromium.org>
Date: Thu Oct 11 20:26:01 2018

portage_util: expand CPV handling

Further expand the portage_util.CPV object to include pf - the
fully qualified pacakge format.

BUG= chromium:875008 
TEST=new tests, run_tests, precq

Change-Id: Iffda3d9f3798e0d46927222d9b5a6cc0cc78b915
Reviewed-on: https://chromium-review.googlesource.com/1257188
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/7078e2599b7b5609a70a6ca6156e1a3040f44705/lib/portage_util_unittest.py
[modify] https://crrev.com/7078e2599b7b5609a70a6ca6156e1a3040f44705/cbuildbot/afdo_unittest.py
[modify] https://crrev.com/7078e2599b7b5609a70a6ca6156e1a3040f44705/cbuildbot/commands.py
[modify] https://crrev.com/7078e2599b7b5609a70a6ca6156e1a3040f44705/cli/deploy.py
[modify] https://crrev.com/7078e2599b7b5609a70a6ca6156e1a3040f44705/lib/portage_util.py
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/12724252ffc5f3cf57e1b2486a777b6322cf301c

commit 12724252ffc5f3cf57e1b2486a777b6322cf301c
Author: Alex Klein <saklein@chromium.org>
Date: Tue Oct 23 00:38:05 2018

install_toolchain: simplify libc extraction

Running two extractions to install glibc is unnecessary. Simplify to
a single extraction with two copy operations to put the files in the
correct locations.

BUG= chromium:875008 
TEST=run_tests, manual: setup_board works

Change-Id: Ic0ceb3dea3a04fc2f7a3b993b13baecac3025034
Reviewed-on: https://chromium-review.googlesource.com/1280883
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/12724252ffc5f3cf57e1b2486a777b6322cf301c/lib/toolchain.py
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/6256c0986bfa8fa3c25bdbde787f815a16c6bfe7

commit 6256c0986bfa8fa3c25bdbde787f815a16c6bfe7
Author: Alex Klein <saklein@chromium.org>
Date: Tue Oct 23 00:38:05 2018

Update install_toolchain call.

BUG= chromium:875008 
TEST=precq passes
CQ-DEPEND=CL:1196837

Change-Id: I6943ab138620fd2b2c3fa9d9f872fa5aca3628e5
Reviewed-on: https://chromium-review.googlesource.com/1197212
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/6256c0986bfa8fa3c25bdbde787f815a16c6bfe7/setup_board
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/e2f328c822ac7c81a53a4f2b54a5b7717a2e84b1

commit e2f328c822ac7c81a53a4f2b54a5b7717a2e84b1
Author: Alex Klein <saklein@chromium.org>
Date: Tue Oct 23 00:38:05 2018

install_toolchain: remove bash version of script.

The python version has been implemented and should
be preferred.

BUG= chromium:875008 
TEST=precq
CQ-DEPEND=CL:1196837

Change-Id: I7bf523f10d0a4c9ea92430ae37d88ff6dfa8942f
Reviewed-on: https://chromium-review.googlesource.com/1197213
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/6256c0986bfa8fa3c25bdbde787f815a16c6bfe7/install_toolchain

Comment 8 by saklein@chromium.org, Oct 24

Status: Fixed (was: Started)
►

Sign in to add a comment