archive_hwqual & call_autoserv.py: move to platform/crostestutils/ |
|||
Issue descriptionthis script deals with hw/test related stuff and would better live in platform/crostestutils/ (1) copy it over platform/crostestutils/ (2) rewrite/delete any code relying on the common.sh wrapper, or rewrite in python (prob better that way) (3) update chromite to call script from new path (4) delete src/scripts/ copy
,
Oct 30
,
Nov 6
I don't fully understand how the scripts and archive are used. It seems like it's unpacked and call_autoserv.py is run somewhere. Is call_autoserv.py ever meant to be run outside of the context of one of the archives? I think the symlink to generate_test_report was made to allow the scripts to use it like it's in the same path whether or not you're in the context of an extracted archive, but it's also made it more difficult to tell what's meant to be happening.
,
Nov 6
Nevermind, another pass over it and I'm pretty convinced it's not meant to be run in place. Is the autotest tar archive_hwqual extracts just the third_party/autotest directory? Or can I get a copy of that somewhere to test everything out properly?
,
Nov 6
i believe the artifacts you want are uploaded by builders already. you can check them via the Artifacts link on buildbot summary pages, or via gsutil. for example: $ gsutil ls gs://chromeos-image-archive/fizz-release/R71-11151.3.0/ there's a bunch of autotest/hwqual/test related archives in there.
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crosutils/+/4de4be5e14d0e0760916a897f234c58caa7771c3 commit 4de4be5e14d0e0760916a897f234c58caa7771c3 Author: Alex Klein <saklein@chromium.org> Date: Fri Nov 16 02:49:21 2018 archive_hwqual & call_autoserv: move to crostestutils archive_hwqual deals with hardware/test functionality that would be more at home in platform/crostestutils/. call_autoserv.py is only used by archive_hwqual, and so will move with it. BUG= chromium:875007 TEST=precq CQ-DEPEND=CL:1318471 Change-Id: I269bc7ad756ce4ae8680f0dafb8940d96bee00fb Reviewed-on: https://chromium-review.googlesource.com/1318197 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Alex Klein <saklein@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [delete] https://crrev.com/18c3bc848e6767be302fe13b0b9381d6314bed9b/call_autoserv.py [delete] https://crrev.com/18c3bc848e6767be302fe13b0b9381d6314bed9b/archive_hwqual
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crostestutils/+/871392c475a876c5bf7c47dfb286187efd122079 commit 871392c475a876c5bf7c47dfb286187efd122079 Author: Alex Klein <saklein@chromium.org> Date: Fri Nov 16 02:49:21 2018 archive_hwqual & call_autoserv: move to crostestutils archive_hwqual deals with hardware/test functionality that would be more at home in platform/crostestutils/. call_autoserv.py is only used by archive_hwqual, and so will move with it. This commit will not work on its own. It is a straight script move, and so the scripts still assume they are in src/scripts. BUG= chromium:875007 TEST=None CQ-DEPEND=CL:1318140, CL:1318197, CL:1318472 Change-Id: Iaa203dd043ae332b939a1d17533430fee7aae507 Reviewed-on: https://chromium-review.googlesource.com/1318471 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Alex Klein <saklein@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/871392c475a876c5bf7c47dfb286187efd122079/call_autoserv.py [add] https://crrev.com/871392c475a876c5bf7c47dfb286187efd122079/archive_hwqual
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crostestutils/+/0ca5a93cd6e6c532ba27e0ecfda90f2fb47be48a commit 0ca5a93cd6e6c532ba27e0ecfda90f2fb47be48a Author: Alex Klein <saklein@chromium.org> Date: Fri Nov 16 02:49:21 2018 archive_hwqual: Script update & remove common.sh dependence Update the script to be aware of its new home. Remove the dependency on common.sh. BUG= chromium:875007 TEST=precq CQ-DEPEND=CL:1318140, CL:1318197, CL:1318471 Change-Id: If11094b709404ab869e15f22b475c6e1660636ce Reviewed-on: https://chromium-review.googlesource.com/1318472 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Alex Klein <saklein@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/0ca5a93cd6e6c532ba27e0ecfda90f2fb47be48a/archive_hwqual
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/d6eacbfadd07605628278b36fb4b280e30526c15 commit d6eacbfadd07605628278b36fb4b280e30526c15 Author: Alex Klein <saklein@chromium.org> Date: Fri Nov 16 02:49:20 2018 archive_hwqual: move to crostestutils BUG= chromium:875007 TEST=precq CQ-DEPEND=CL:1318471 Change-Id: Icafa311fa8254fb61516808fae5fb120becf8ce5 Reviewed-on: https://chromium-review.googlesource.com/1318140 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Alex Klein <saklein@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/d6eacbfadd07605628278b36fb4b280e30526c15/cbuildbot/commands.py
,
Nov 16
|
|||
►
Sign in to add a comment |
|||
Comment 1 by vapier@chromium.org
, Aug 16