Create a service for audio focus & media session
Design doc (internal only): https://docs.google.com/document/d/1sOJPo-cJiw1CpPjlXbHsnmwCiY7hSlP5qMJSUBsKgac/edit?ts=5b751b8f#
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00e71553c7788366a0eefd544001a10f84f34628 commit 00e71553c7788366a0eefd544001a10f84f34628 Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Aug 17 19:21:57 2018 [Media Session] Add base service Add the structure for a basic media session service that will control media sessions and audio focus across the entire system. The mojo API is based on the current public content API. BUG=875004 Change-Id: Ie7ab6be5c13ba89e4e8865d9f65fb1533b6925af Reviewed-on: https://chromium-review.googlesource.com/1178681 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#584147} [modify] https://crrev.com/00e71553c7788366a0eefd544001a10f84f34628/services/BUILD.gn [add] https://crrev.com/00e71553c7788366a0eefd544001a10f84f34628/services/media_session/BUILD.gn [add] https://crrev.com/00e71553c7788366a0eefd544001a10f84f34628/services/media_session/OWNERS [add] https://crrev.com/00e71553c7788366a0eefd544001a10f84f34628/services/media_session/README.md [add] https://crrev.com/00e71553c7788366a0eefd544001a10f84f34628/services/media_session/manifest.json [add] https://crrev.com/00e71553c7788366a0eefd544001a10f84f34628/services/media_session/media_session_service.cc [add] https://crrev.com/00e71553c7788366a0eefd544001a10f84f34628/services/media_session/media_session_service.h [add] https://crrev.com/00e71553c7788366a0eefd544001a10f84f34628/services/media_session/media_session_service_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8da7a66a67d81402eb01883fedc95c295e847765 commit 8da7a66a67d81402eb01883fedc95c295e847765 Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Aug 24 21:58:42 2018 [Media Session] Mojoify audio focus observer Move AudioFocusObserver to the media session service and convert it to use mojo. At the moment the observers register themselves with AudioFocusManager but in the future this will be with the Media Sesssion service. Also adds an empty MediaSession mojo type so we can pass it as an arg to AudioFocusObserver. BUG=875004 Change-Id: I4bd09796018833cb9f9714b2296642bd40be48ff Reviewed-on: https://chromium-review.googlesource.com/1180484 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Nick Carter <nick@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#586012} [modify] https://crrev.com/8da7a66a67d81402eb01883fedc95c295e847765/content/browser/media/media_internals.cc [modify] https://crrev.com/8da7a66a67d81402eb01883fedc95c295e847765/content/browser/media/media_internals.h [modify] https://crrev.com/8da7a66a67d81402eb01883fedc95c295e847765/content/browser/media/media_internals_unittest.cc [modify] https://crrev.com/8da7a66a67d81402eb01883fedc95c295e847765/content/browser/media/session/audio_focus_manager.cc [modify] https://crrev.com/8da7a66a67d81402eb01883fedc95c295e847765/content/browser/media/session/audio_focus_manager.h [modify] https://crrev.com/8da7a66a67d81402eb01883fedc95c295e847765/content/browser/media/session/audio_focus_manager_unittest.cc [modify] https://crrev.com/8da7a66a67d81402eb01883fedc95c295e847765/content/browser/media/session/audio_focus_observer.cc [modify] https://crrev.com/8da7a66a67d81402eb01883fedc95c295e847765/content/browser/media/session/audio_focus_observer.h [modify] https://crrev.com/8da7a66a67d81402eb01883fedc95c295e847765/content/browser/media/session/media_session_impl.cc [modify] https://crrev.com/8da7a66a67d81402eb01883fedc95c295e847765/content/browser/media/session/media_session_impl.h [modify] https://crrev.com/8da7a66a67d81402eb01883fedc95c295e847765/content/public/browser/BUILD.gn [modify] https://crrev.com/8da7a66a67d81402eb01883fedc95c295e847765/content/public/browser/DEPS [modify] https://crrev.com/8da7a66a67d81402eb01883fedc95c295e847765/content/public/browser/media_session.h [modify] https://crrev.com/8da7a66a67d81402eb01883fedc95c295e847765/services/media_session/public/mojom/BUILD.gn [modify] https://crrev.com/8da7a66a67d81402eb01883fedc95c295e847765/services/media_session/public/mojom/audio_focus.mojom [add] https://crrev.com/8da7a66a67d81402eb01883fedc95c295e847765/services/media_session/public/mojom/media_session.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f87f52571ee10819ae3ab464d7ce45242e8042b9 commit f87f52571ee10819ae3ab464d7ce45242e8042b9 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Aug 30 18:43:36 2018 [Media Session] Move switches to service Move the media session and audio focus related switches to the media session service. BUG=875004 Change-Id: I54dad1eb47ac6288895ea3cac3824b181080f3e3 Reviewed-on: https://chromium-review.googlesource.com/1188747 Reviewed-by: Stephen Lanham <slan@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#587676} [modify] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/chrome/browser/DEPS [modify] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/chrome/browser/about_flags.cc [modify] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/chrome/browser/chromeos/accessibility/accessibility_manager.cc [modify] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/chromecast/browser/DEPS [modify] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/chromecast/browser/cast_browser_main_parts.cc [modify] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/content/browser/BUILD.gn [modify] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/content/browser/media/media_internals_unittest.cc [modify] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/content/browser/media/session/audio_focus_delegate_default.cc [modify] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/content/browser/media/session/audio_focus_delegate_default_browsertest.cc [modify] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/content/browser/media/session/audio_focus_manager_unittest.cc [modify] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/content/browser/media/session/media_session_browsertest.cc [modify] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/content/browser/media/session/media_session_controllers_manager.cc [modify] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/content/browser/media/session/media_session_controllers_manager_unittest.cc [modify] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/content/browser/media/session/media_session_impl_visibility_browsertest.cc [modify] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/content/browser/media/session/pepper_playback_observer.cc [modify] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/content/browser/media/session/pepper_player_delegate.cc [modify] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/content/public/browser/BUILD.gn [modify] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/media/base/media_switches.cc [modify] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/media/base/media_switches.h [add] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/services/media_session/public/cpp/BUILD.gn [add] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/services/media_session/public/cpp/switches.cc [add] https://crrev.com/f87f52571ee10819ae3ab464d7ce45242e8042b9/services/media_session/public/cpp/switches.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a8d9b9ff2b8ce21c697445a6e0fd1088c4ed859 commit 1a8d9b9ff2b8ce21c697445a6e0fd1088c4ed859 Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Aug 31 18:02:07 2018 [Media Session] Embed media session service Embed the media session service in the browser process. BUG=875004 Change-Id: I757988d0090dfb9bb7974c8dad920c9d758c54f4 Reviewed-on: https://chromium-review.googlesource.com/1188766 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#588089} [modify] https://crrev.com/1a8d9b9ff2b8ce21c697445a6e0fd1088c4ed859/content/browser/BUILD.gn [modify] https://crrev.com/1a8d9b9ff2b8ce21c697445a6e0fd1088c4ed859/content/browser/service_manager/service_manager_context.cc [modify] https://crrev.com/1a8d9b9ff2b8ce21c697445a6e0fd1088c4ed859/services/media_session/public/mojom/BUILD.gn [add] https://crrev.com/1a8d9b9ff2b8ce21c697445a6e0fd1088c4ed859/services/media_session/public/mojom/constants.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6247cd701567556522e451635620518d71050ce commit b6247cd701567556522e451635620518d71050ce Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Sep 17 17:37:39 2018 [Media Session] Rename SuspendType enum values Rename the SuspendType enum values as part of the media session service work. We are moving this to mojo in CL 1187707 and this is a precursor so that the enum is consistent with the mojo enums. BUG=875004 Change-Id: Id9a18d95462bb6c828836769540e03f7ee28b346 Reviewed-on: https://chromium-review.googlesource.com/1211104 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#591725} [modify] https://crrev.com/b6247cd701567556522e451635620518d71050ce/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc [modify] https://crrev.com/b6247cd701567556522e451635620518d71050ce/chrome/browser/ui/ash/media_client.cc [modify] https://crrev.com/b6247cd701567556522e451635620518d71050ce/chromecast/browser/cast_media_blocker.cc [modify] https://crrev.com/b6247cd701567556522e451635620518d71050ce/chromecast/browser/cast_web_contents_manager.cc [modify] https://crrev.com/b6247cd701567556522e451635620518d71050ce/chromecast/browser/extensions/api/automation_internal/automation_internal_api.cc [modify] https://crrev.com/b6247cd701567556522e451635620518d71050ce/content/browser/media/session/audio_focus_delegate_android.cc [modify] https://crrev.com/b6247cd701567556522e451635620518d71050ce/content/browser/media/session/audio_focus_delegate_default_browsertest.cc [modify] https://crrev.com/b6247cd701567556522e451635620518d71050ce/content/browser/media/session/audio_focus_manager.cc [modify] https://crrev.com/b6247cd701567556522e451635620518d71050ce/content/browser/media/session/media_session_android.cc [modify] https://crrev.com/b6247cd701567556522e451635620518d71050ce/content/browser/media/session/media_session_browsertest.cc [modify] https://crrev.com/b6247cd701567556522e451635620518d71050ce/content/browser/media/session/media_session_impl.cc [modify] https://crrev.com/b6247cd701567556522e451635620518d71050ce/content/browser/media/session/media_session_impl_browsertest.cc [modify] https://crrev.com/b6247cd701567556522e451635620518d71050ce/content/browser/media/session/media_session_impl_uma_unittest.cc [modify] https://crrev.com/b6247cd701567556522e451635620518d71050ce/content/public/browser/media_session.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c commit 2d9db2d8181a5c70a17bd8e094d6fd708e68b34c Author: Becca Hughes <beccahughes@chromium.org> Date: Wed Oct 03 19:13:00 2018 [Media Session] Convert AudioFocusManager to use Mojo This CL converts AudioFocusManager to use mojo MediaSessions and converts the required methods. We also add a mojo MediaSessionObserver to keep track of MediaSession state. This changes the AudioFocusManager logic slightly so we recieve a request ID when we get focus. This is used to identify the MediaSession in the future when we want to abandon or request a different audio focus type. Adds GetMediaSessionInfo which gets session state in a struct to avoid needing multiple calls over Mojo. Makes GetDebugInfo public which is needed by Mojo media session implementations. The next step will be to move AudioFocusManager to the media session service. BUG=875004 Change-Id: Ideb7c761c647bb057ab988f0af9bf867688df3fe Reviewed-on: https://chromium-review.googlesource.com/c/1187707 Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#596313} [modify] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/chromecast/browser/cast_media_blocker_unittest.cc [modify] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/content/browser/media/media_internals.cc [modify] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/content/browser/media/media_internals.h [modify] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/content/browser/media/media_internals_proxy.cc [modify] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/content/browser/media/media_internals_unittest.cc [modify] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/content/browser/media/session/audio_focus_delegate_default.cc [modify] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/content/browser/media/session/audio_focus_delegate_default_browsertest.cc [modify] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/content/browser/media/session/audio_focus_manager.cc [modify] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/content/browser/media/session/audio_focus_manager.h [modify] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/content/browser/media/session/audio_focus_manager_unittest.cc [modify] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/content/browser/media/session/audio_focus_observer.h [add] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/content/browser/media/session/audio_focus_test_util.cc [add] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/content/browser/media/session/audio_focus_test_util.h [modify] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/content/browser/media/session/media_session_impl.cc [modify] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/content/browser/media/session/media_session_impl.h [add] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/content/browser/media/session/media_session_impl_unittest.cc [modify] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/content/public/browser/media_session.h [modify] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/content/test/BUILD.gn [modify] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/services/media_session/public/mojom/audio_focus.mojom [modify] https://crrev.com/2d9db2d8181a5c70a17bd8e094d6fd708e68b34c/services/media_session/public/mojom/media_session.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/608b2a8922748aa74c0b97b53e72b1b630168547 commit 608b2a8922748aa74c0b97b53e72b1b630168547 Author: Becca Hughes <beccahughes@chromium.org> Date: Wed Oct 03 21:20:18 2018 [Media Session] Move AudioFocusManager to //services Move AudioFocusManager and its unit tests to //services. This CL does not remove the existing AudioFocusManager in //content as this will be done in a follow up CL with some mojo work. BUG=875004 Change-Id: Ife982e671d21ca7be29a6bed38097e842937b35f Reviewed-on: https://chromium-review.googlesource.com/c/1197351 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#596367} [modify] https://crrev.com/608b2a8922748aa74c0b97b53e72b1b630168547/services/media_session/BUILD.gn [add] https://crrev.com/608b2a8922748aa74c0b97b53e72b1b630168547/services/media_session/audio_focus_manager.cc [add] https://crrev.com/608b2a8922748aa74c0b97b53e72b1b630168547/services/media_session/audio_focus_manager.h [add] https://crrev.com/608b2a8922748aa74c0b97b53e72b1b630168547/services/media_session/audio_focus_manager_unittest.cc [add] https://crrev.com/608b2a8922748aa74c0b97b53e72b1b630168547/services/media_session/public/cpp/test/BUILD.gn [add] https://crrev.com/608b2a8922748aa74c0b97b53e72b1b630168547/services/media_session/public/cpp/test/audio_focus_test_util.cc [add] https://crrev.com/608b2a8922748aa74c0b97b53e72b1b630168547/services/media_session/public/cpp/test/audio_focus_test_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d55bc9fec5527decf5d253ad146325e4c900bf85 commit d55bc9fec5527decf5d253ad146325e4c900bf85 Author: Becca Hughes <beccahughes@chromium.org> Date: Wed Oct 03 21:27:28 2018 [Media Session] Allow async audio focus requests For cross process audio focus requests we need to support async audio focus requests in MediaSessionImpl. This adds support and test coverage but does not yet fully convert them to async. BUG=875004 Change-Id: Ie4236b5e78d63593d9ec3bf0968e03bef36ee1fc Reviewed-on: https://chromium-review.googlesource.com/c/1192105 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#596371} [modify] https://crrev.com/d55bc9fec5527decf5d253ad146325e4c900bf85/content/browser/media/session/audio_focus_delegate.h [modify] https://crrev.com/d55bc9fec5527decf5d253ad146325e4c900bf85/content/browser/media/session/audio_focus_delegate_android.cc [modify] https://crrev.com/d55bc9fec5527decf5d253ad146325e4c900bf85/content/browser/media/session/audio_focus_delegate_android.h [modify] https://crrev.com/d55bc9fec5527decf5d253ad146325e4c900bf85/content/browser/media/session/audio_focus_delegate_default.cc [modify] https://crrev.com/d55bc9fec5527decf5d253ad146325e4c900bf85/content/browser/media/session/media_session_impl.cc [modify] https://crrev.com/d55bc9fec5527decf5d253ad146325e4c900bf85/content/browser/media/session/media_session_impl.h [modify] https://crrev.com/d55bc9fec5527decf5d253ad146325e4c900bf85/content/browser/media/session/media_session_impl_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17349ec7291ee0b3e237992d006447db5e91fadf commit 17349ec7291ee0b3e237992d006447db5e91fadf Author: Becca Hughes <beccahughes@chromium.org> Date: Wed Oct 03 22:36:56 2018 [Media Session] Add AudioFocus mojo API Adds a mojo AudioFocus API that can be used to access AudioFocusManager inside the media session service. This also removes the RequestId when requesting or abandoning audio focus and replaces it with a AudioFocusRequestClient interface. We still keep the ID around though as it is useful for testing and identifying requests. BUG=875004 Change-Id: I88374a08a14171f747a120beaa380c3b126bfb4f Reviewed-on: https://chromium-review.googlesource.com/c/1199923 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#596404} [modify] https://crrev.com/17349ec7291ee0b3e237992d006447db5e91fadf/content/public/app/BUILD.gn [modify] https://crrev.com/17349ec7291ee0b3e237992d006447db5e91fadf/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/17349ec7291ee0b3e237992d006447db5e91fadf/services/media_session/audio_focus_manager.cc [modify] https://crrev.com/17349ec7291ee0b3e237992d006447db5e91fadf/services/media_session/audio_focus_manager.h [modify] https://crrev.com/17349ec7291ee0b3e237992d006447db5e91fadf/services/media_session/audio_focus_manager_unittest.cc [modify] https://crrev.com/17349ec7291ee0b3e237992d006447db5e91fadf/services/media_session/manifest.json [modify] https://crrev.com/17349ec7291ee0b3e237992d006447db5e91fadf/services/media_session/media_session_service.cc [modify] https://crrev.com/17349ec7291ee0b3e237992d006447db5e91fadf/services/media_session/public/mojom/audio_focus.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e179a32450992300d575fde8601e7ea357d11d33 commit e179a32450992300d575fde8601e7ea357d11d33 Author: Becca Hughes <beccahughes@chromium.org> Date: Wed Oct 03 23:11:07 2018 [Media Session] Add AudioFocus debug API Add a separate AudioFocusManagerDebug API to isolate the privileged GetDebugInfoForRequest method. BUG=875004 Change-Id: I587a73a78edf7aba3fce3f8dc722d2914098013f Reviewed-on: https://chromium-review.googlesource.com/c/1242036 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#596414} [modify] https://crrev.com/e179a32450992300d575fde8601e7ea357d11d33/services/media_session/audio_focus_manager.cc [modify] https://crrev.com/e179a32450992300d575fde8601e7ea357d11d33/services/media_session/audio_focus_manager.h [modify] https://crrev.com/e179a32450992300d575fde8601e7ea357d11d33/services/media_session/audio_focus_manager_unittest.cc [modify] https://crrev.com/e179a32450992300d575fde8601e7ea357d11d33/services/media_session/manifest.json [modify] https://crrev.com/e179a32450992300d575fde8601e7ea357d11d33/services/media_session/media_session_service.cc [modify] https://crrev.com/e179a32450992300d575fde8601e7ea357d11d33/services/media_session/public/mojom/audio_focus.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87b17ae6748bc0aa14bf918e3d717e07bae1da2c commit 87b17ae6748bc0aa14bf918e3d717e07bae1da2c Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Oct 04 00:35:42 2018 [Audio Focus] Add no enforce flag Adds an audio focus flag that enables audio focus manager but disables enforcement of a single media session. This gives us the option of enabling audio focus tracking without the user facing change of enforcing a single media session. BUG=875004 Change-Id: I5415ec76db7b22d4d91ea98c92e3f1515d9df97b Reviewed-on: https://chromium-review.googlesource.com/c/1231915 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#596446} [modify] https://crrev.com/87b17ae6748bc0aa14bf918e3d717e07bae1da2c/chrome/browser/about_flags.cc [modify] https://crrev.com/87b17ae6748bc0aa14bf918e3d717e07bae1da2c/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/87b17ae6748bc0aa14bf918e3d717e07bae1da2c/chrome/browser/flag_descriptions.h [modify] https://crrev.com/87b17ae6748bc0aa14bf918e3d717e07bae1da2c/services/media_session/BUILD.gn [modify] https://crrev.com/87b17ae6748bc0aa14bf918e3d717e07bae1da2c/services/media_session/audio_focus_manager.cc [modify] https://crrev.com/87b17ae6748bc0aa14bf918e3d717e07bae1da2c/services/media_session/audio_focus_manager.h [modify] https://crrev.com/87b17ae6748bc0aa14bf918e3d717e07bae1da2c/services/media_session/audio_focus_manager_unittest.cc [modify] https://crrev.com/87b17ae6748bc0aa14bf918e3d717e07bae1da2c/services/media_session/public/cpp/switches.cc [modify] https://crrev.com/87b17ae6748bc0aa14bf918e3d717e07bae1da2c/services/media_session/public/cpp/switches.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f7072ffff307c184dc25700eebd16078cbb72b8 commit 2f7072ffff307c184dc25700eebd16078cbb72b8 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Oct 04 00:58:40 2018 [Media Session] Switch content to using the service Switch the content MediaSession code to using the audio focus service on non-Android platforms. BUG=875004 Change-Id: I8171a7351a7d64065564fe5f75937e1abaef8e7c Reviewed-on: https://chromium-review.googlesource.com/c/1207657 Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#596456} [modify] https://crrev.com/2f7072ffff307c184dc25700eebd16078cbb72b8/content/browser/media/media_internals.cc [modify] https://crrev.com/2f7072ffff307c184dc25700eebd16078cbb72b8/content/browser/media/media_internals.h [modify] https://crrev.com/2f7072ffff307c184dc25700eebd16078cbb72b8/content/browser/media/media_internals_unittest.cc [modify] https://crrev.com/2f7072ffff307c184dc25700eebd16078cbb72b8/content/browser/media/session/audio_focus_delegate.h [modify] https://crrev.com/2f7072ffff307c184dc25700eebd16078cbb72b8/content/browser/media/session/audio_focus_delegate_android.h [modify] https://crrev.com/2f7072ffff307c184dc25700eebd16078cbb72b8/content/browser/media/session/audio_focus_delegate_default.cc [modify] https://crrev.com/2f7072ffff307c184dc25700eebd16078cbb72b8/content/browser/media/session/audio_focus_delegate_default_browsertest.cc [modify] https://crrev.com/2f7072ffff307c184dc25700eebd16078cbb72b8/content/browser/media/session/audio_focus_manager_unittest.cc [modify] https://crrev.com/2f7072ffff307c184dc25700eebd16078cbb72b8/content/browser/media/session/audio_focus_observer.cc [modify] https://crrev.com/2f7072ffff307c184dc25700eebd16078cbb72b8/content/browser/media/session/audio_focus_observer.h [modify] https://crrev.com/2f7072ffff307c184dc25700eebd16078cbb72b8/content/browser/media/session/media_session_controllers_manager_unittest.cc [modify] https://crrev.com/2f7072ffff307c184dc25700eebd16078cbb72b8/content/browser/media/session/media_session_impl.cc [modify] https://crrev.com/2f7072ffff307c184dc25700eebd16078cbb72b8/content/browser/media/session/media_session_impl.h [modify] https://crrev.com/2f7072ffff307c184dc25700eebd16078cbb72b8/content/browser/media/session/media_session_impl_browsertest.cc [modify] https://crrev.com/2f7072ffff307c184dc25700eebd16078cbb72b8/content/browser/media/session/media_session_impl_unittest.cc [modify] https://crrev.com/2f7072ffff307c184dc25700eebd16078cbb72b8/content/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd936bf790f6112757f4709e5c0c394b6b50e85f commit bd936bf790f6112757f4709e5c0c394b6b50e85f Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Oct 04 17:24:51 2018 [Media Session] Remove audio focus manager Remove AudioFocusManager in content as it has been moved to //services/media_session. BUG=875004 Change-Id: Iba9136c8b3854d5936067b86fead4e0d67659f0c Reviewed-on: https://chromium-review.googlesource.com/c/1207913 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#596728} [modify] https://crrev.com/bd936bf790f6112757f4709e5c0c394b6b50e85f/content/browser/BUILD.gn [delete] https://crrev.com/6facfc105221c380cc24631b42e46106dad93874/content/browser/media/session/audio_focus_manager.cc [delete] https://crrev.com/6facfc105221c380cc24631b42e46106dad93874/content/browser/media/session/audio_focus_manager.h [delete] https://crrev.com/6facfc105221c380cc24631b42e46106dad93874/content/browser/media/session/audio_focus_manager_unittest.cc [delete] https://crrev.com/6facfc105221c380cc24631b42e46106dad93874/content/browser/media/session/audio_focus_test_util.cc [delete] https://crrev.com/6facfc105221c380cc24631b42e46106dad93874/content/browser/media/session/audio_focus_test_util.h [modify] https://crrev.com/bd936bf790f6112757f4709e5c0c394b6b50e85f/content/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae6e692853d655dce5ec633357b4a0796c2d4dd1 commit ae6e692853d655dce5ec633357b4a0796c2d4dd1 Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Oct 05 21:02:24 2018 [Audio Focus] Add a source name Adds a source name to the AudioFocusManager API that can be used to identify a client to the media session service. This adds more granularity than service_manager::Identity so we can differentiate between ARC and Content. It will be used to identify a client when recording metrics and for tweaking the UI based on where the media session originated from. BUG=875004 Change-Id: I4a78fd2bf17189de503aa507d51a7260f62ac7ee Reviewed-on: https://chromium-review.googlesource.com/c/1239258 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#597287} [modify] https://crrev.com/ae6e692853d655dce5ec633357b4a0796c2d4dd1/components/arc/media_session/arc_media_session_bridge.cc [modify] https://crrev.com/ae6e692853d655dce5ec633357b4a0796c2d4dd1/services/media_session/audio_focus_manager.cc [modify] https://crrev.com/ae6e692853d655dce5ec633357b4a0796c2d4dd1/services/media_session/audio_focus_manager.h [modify] https://crrev.com/ae6e692853d655dce5ec633357b4a0796c2d4dd1/services/media_session/audio_focus_manager_unittest.cc [modify] https://crrev.com/ae6e692853d655dce5ec633357b4a0796c2d4dd1/services/media_session/public/mojom/audio_focus.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5d142b69a32ad1f2acd14243cc25a84b999d81d commit d5d142b69a32ad1f2acd14243cc25a84b999d81d Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Oct 05 21:18:44 2018 [Media Session] Add audio focus source name Add a source name in AudioFocusDelegateDefault for "web". BUG=875004 Change-Id: Id80b828ee7b717d8f9c0b624974bc3758db1c858 Reviewed-on: https://chromium-review.googlesource.com/c/1239540 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#597303} [modify] https://crrev.com/d5d142b69a32ad1f2acd14243cc25a84b999d81d/content/browser/media/session/audio_focus_delegate_default.cc [modify] https://crrev.com/d5d142b69a32ad1f2acd14243cc25a84b999d81d/content/browser/media/session/audio_focus_delegate_default_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/caba7fce8f5f8e2898740da59af1d0a7a86e8183 commit caba7fce8f5f8e2898740da59af1d0a7a86e8183 Author: Becca Hughes <beccahughes@chromium.org> Date: Wed Oct 10 22:32:35 2018 [Audio Focus] Remove singleton from AFM Remove singleton status from AudioFocusManager. This was needed before the move to the service but now AFM should be tied to the lifecycle of MediaSessionService. BUG=875004 Change-Id: I255a81577a251f60cd3cca5f540cc256e569939f Reviewed-on: https://chromium-review.googlesource.com/c/1272121 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#598545} [modify] https://crrev.com/caba7fce8f5f8e2898740da59af1d0a7a86e8183/services/media_session/audio_focus_manager.cc [modify] https://crrev.com/caba7fce8f5f8e2898740da59af1d0a7a86e8183/services/media_session/audio_focus_manager.h [modify] https://crrev.com/caba7fce8f5f8e2898740da59af1d0a7a86e8183/services/media_session/audio_focus_manager_unittest.cc [modify] https://crrev.com/caba7fce8f5f8e2898740da59af1d0a7a86e8183/services/media_session/media_session_service.cc [modify] https://crrev.com/caba7fce8f5f8e2898740da59af1d0a7a86e8183/services/media_session/media_session_service.h [modify] https://crrev.com/caba7fce8f5f8e2898740da59af1d0a7a86e8183/services/media_session/mock_media_session.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64a37a5d86783ab6a7fd816346e1f3c00c938f54 commit 64a37a5d86783ab6a7fd816346e1f3c00c938f54 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Oct 23 16:18:13 2018 [Audio Focus] Add OnFocusGained call on abandon If a session abandons audio focus the top most session in the stack will acquire focus. However, we do not call OnFocusGained for the new session (only on request). This changes the behaviour so we will call OnFocusLost and then OnFocusGained. BUG=875004 Change-Id: Iceea56c55ca629ac35b5a66ff79a2ace8c73361f Reviewed-on: https://chromium-review.googlesource.com/c/1289950 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#601977} [modify] https://crrev.com/64a37a5d86783ab6a7fd816346e1f3c00c938f54/services/media_session/audio_focus_manager.cc [modify] https://crrev.com/64a37a5d86783ab6a7fd816346e1f3c00c938f54/services/media_session/audio_focus_manager_unittest.cc [modify] https://crrev.com/64a37a5d86783ab6a7fd816346e1f3c00c938f54/services/media_session/public/cpp/test/audio_focus_test_util.cc [modify] https://crrev.com/64a37a5d86783ab6a7fd816346e1f3c00c938f54/services/media_session/public/cpp/test/audio_focus_test_util.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1aa4e67ae24303f300be543c3e65611a13c078e9 commit 1aa4e67ae24303f300be543c3e65611a13c078e9 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Oct 23 22:09:08 2018 [Audio Focus] Move logic to helper Move audio focus media internals to helper class. Move logic from content::AudioFocusObserver (which we want to remove) to this helper class. BUG=875004 Change-Id: I7c80f6b680bd23e71193438c32b68e55ea05b58e Reviewed-on: https://chromium-review.googlesource.com/c/1286904 Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#602125} [modify] https://crrev.com/1aa4e67ae24303f300be543c3e65611a13c078e9/content/browser/BUILD.gn [modify] https://crrev.com/1aa4e67ae24303f300be543c3e65611a13c078e9/content/browser/media/OWNERS [modify] https://crrev.com/1aa4e67ae24303f300be543c3e65611a13c078e9/content/browser/media/media_internals.cc [modify] https://crrev.com/1aa4e67ae24303f300be543c3e65611a13c078e9/content/browser/media/media_internals.h [add] https://crrev.com/1aa4e67ae24303f300be543c3e65611a13c078e9/content/browser/media/media_internals_audio_focus_helper.cc [add] https://crrev.com/1aa4e67ae24303f300be543c3e65611a13c078e9/content/browser/media/media_internals_audio_focus_helper.h [modify] https://crrev.com/1aa4e67ae24303f300be543c3e65611a13c078e9/content/browser/media/media_internals_unittest.cc [delete] https://crrev.com/62396dd247b8f5d069706ddfd561148ef2f6d27b/content/browser/media/session/audio_focus_observer.cc [delete] https://crrev.com/62396dd247b8f5d069706ddfd561148ef2f6d27b/content/browser/media/session/audio_focus_observer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc6dc3aea0a05fc262346eba797d6199bf893fd9 commit dc6dc3aea0a05fc262346eba797d6199bf893fd9 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Nov 01 18:17:31 2018 [Audio Focus] Add common debug info to internals Debug information that is common across all media session types should be populated by media internals instead of the sessions themselves. This removes the need for duplicating logic across session types. Test: MediaInternalsAudioFocusTest BUG=875004 Change-Id: I0395e49423593d255973464658dbe41a3aa15b66 Reviewed-on: https://chromium-review.googlesource.com/c/1300103 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#604640} [modify] https://crrev.com/dc6dc3aea0a05fc262346eba797d6199bf893fd9/content/browser/media/media_internals_audio_focus_helper.cc [modify] https://crrev.com/dc6dc3aea0a05fc262346eba797d6199bf893fd9/content/browser/media/media_internals_audio_focus_helper.h [modify] https://crrev.com/dc6dc3aea0a05fc262346eba797d6199bf893fd9/content/browser/media/session/media_session_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93ee1837006400a4fde789787d70a7f09905cce8 commit 93ee1837006400a4fde789787d70a7f09905cce8 Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Nov 05 21:50:35 2018 [Media Session] [1/4] Move MediaMetadata to service This CL moves the MediaMetadata and MediaImage mojo types from Blink to the Media Session service along with their mapped types in content. This is the first of four parts. BUG=875004 Change-Id: Ie862229bbeb474a60ccc4d2f82d8c4e1f8017b74 Reviewed-on: https://chromium-review.googlesource.com/c/1227401 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#605481} [modify] https://crrev.com/93ee1837006400a4fde789787d70a7f09905cce8/mojo/public/tools/bindings/chromium_bindings_configuration.gni [modify] https://crrev.com/93ee1837006400a4fde789787d70a7f09905cce8/services/BUILD.gn [add] https://crrev.com/93ee1837006400a4fde789787d70a7f09905cce8/services/media_session/DEPS [modify] https://crrev.com/93ee1837006400a4fde789787d70a7f09905cce8/services/media_session/public/cpp/BUILD.gn [add] https://crrev.com/93ee1837006400a4fde789787d70a7f09905cce8/services/media_session/public/cpp/OWNERS [add] https://crrev.com/93ee1837006400a4fde789787d70a7f09905cce8/services/media_session/public/cpp/android/BUILD.gn [add] https://crrev.com/93ee1837006400a4fde789787d70a7f09905cce8/services/media_session/public/cpp/android/java/src/org/chromium/services/media_session/MediaMetadata.java [add] https://crrev.com/93ee1837006400a4fde789787d70a7f09905cce8/services/media_session/public/cpp/media_metadata.cc [add] https://crrev.com/93ee1837006400a4fde789787d70a7f09905cce8/services/media_session/public/cpp/media_metadata.h [add] https://crrev.com/93ee1837006400a4fde789787d70a7f09905cce8/services/media_session/public/cpp/media_metadata_android.cc [add] https://crrev.com/93ee1837006400a4fde789787d70a7f09905cce8/services/media_session/public/cpp/media_session.typemap [add] https://crrev.com/93ee1837006400a4fde789787d70a7f09905cce8/services/media_session/public/cpp/media_session_mojom_traits.cc [add] https://crrev.com/93ee1837006400a4fde789787d70a7f09905cce8/services/media_session/public/cpp/media_session_mojom_traits.h [add] https://crrev.com/93ee1837006400a4fde789787d70a7f09905cce8/services/media_session/public/cpp/typemaps.gni [modify] https://crrev.com/93ee1837006400a4fde789787d70a7f09905cce8/services/media_session/public/mojom/BUILD.gn [modify] https://crrev.com/93ee1837006400a4fde789787d70a7f09905cce8/services/media_session/public/mojom/media_session.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0475617fe96a82edc816f083b76085450d4fb85e commit 0475617fe96a82edc816f083b76085450d4fb85e Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Nov 05 22:36:58 2018 [Media Session] [2/4] Move Metadata to service This CL moves any existing uses in Android of MediaMetadata to the new version in the media_session service. BUG=875004 Binary-Size: Adding duplicate classes that will be removed in https://crrev.com/c/1241554 Change-Id: I8ed9afd45a37e515ae89d5d82a542a6f4c139136 Reviewed-on: https://chromium-review.googlesource.com/c/1241466 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#605498} [modify] https://crrev.com/0475617fe96a82edc816f083b76085450d4fb85e/chrome/android/BUILD.gn [modify] https://crrev.com/0475617fe96a82edc816f083b76085450d4fb85e/chrome/android/DEPS [modify] https://crrev.com/0475617fe96a82edc816f083b76085450d4fb85e/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java [modify] https://crrev.com/0475617fe96a82edc816f083b76085450d4fb85e/chrome/android/java/src/org/chromium/chrome/browser/media/router/CastSessionUtil.java [modify] https://crrev.com/0475617fe96a82edc816f083b76085450d4fb85e/chrome/android/java/src/org/chromium/chrome/browser/media/router/caf/CafNotificationController.java [modify] https://crrev.com/0475617fe96a82edc816f083b76085450d4fb85e/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java [modify] https://crrev.com/0475617fe96a82edc816f083b76085450d4fb85e/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java [modify] https://crrev.com/0475617fe96a82edc816f083b76085450d4fb85e/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java [modify] https://crrev.com/0475617fe96a82edc816f083b76085450d4fb85e/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java [modify] https://crrev.com/0475617fe96a82edc816f083b76085450d4fb85e/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaImageManagerTest.java [modify] https://crrev.com/0475617fe96a82edc816f083b76085450d4fb85e/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerNotificationTest.java [modify] https://crrev.com/0475617fe96a82edc816f083b76085450d4fb85e/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerServiceLifecycleTest.java [modify] https://crrev.com/0475617fe96a82edc816f083b76085450d4fb85e/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerTestBase.java [modify] https://crrev.com/0475617fe96a82edc816f083b76085450d4fb85e/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationTestTabHolder.java [modify] https://crrev.com/0475617fe96a82edc816f083b76085450d4fb85e/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationTitleUpdatedTest.java [modify] https://crrev.com/0475617fe96a82edc816f083b76085450d4fb85e/content/public/android/BUILD.gn [modify] https://crrev.com/0475617fe96a82edc816f083b76085450d4fb85e/content/public/android/DEPS [modify] https://crrev.com/0475617fe96a82edc816f083b76085450d4fb85e/content/public/android/java/src/org/chromium/content/browser/MediaSessionImpl.java [modify] https://crrev.com/0475617fe96a82edc816f083b76085450d4fb85e/content/public/android/java/src/org/chromium/content_public/browser/MediaSessionObserver.java [delete] https://crrev.com/44e0b0ba6ea98bd88e7c41abc1a987bd53c5d6d7/content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e8742cdbef2b71d88fc483f0cef4dfcd8763387 commit 0e8742cdbef2b71d88fc483f0cef4dfcd8763387 Author: Dmitry Titov <dimich@chromium.org> Date: Mon Nov 05 23:16:38 2018 Revert "[Media Session] [2/4] Move Metadata to service" This reverts commit 0475617fe96a82edc816f083b76085450d4fb85e. Reason for revert: Broke compile: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/4072 Original change's description: > [Media Session] [2/4] Move Metadata to service > > This CL moves any existing uses in Android of MediaMetadata > to the new version in the media_session service. > > BUG=875004 > > Binary-Size: Adding duplicate classes that will be removed > in https://crrev.com/c/1241554 > > Change-Id: I8ed9afd45a37e515ae89d5d82a542a6f4c139136 > Reviewed-on: https://chromium-review.googlesource.com/c/1241466 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605498} TBR=mlamouri@chromium.org,tedchoc@chromium.org,beccahughes@chromium.org Change-Id: I0a9477b6cbc90bc7379e4ce5c30283c42d82ecc8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 875004 Reviewed-on: https://chromium-review.googlesource.com/c/1318738 Reviewed-by: Dmitry Titov <dimich@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#605510} [modify] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/chrome/android/BUILD.gn [modify] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/chrome/android/DEPS [modify] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java [modify] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/chrome/android/java/src/org/chromium/chrome/browser/media/router/CastSessionUtil.java [modify] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/chrome/android/java/src/org/chromium/chrome/browser/media/router/caf/CafNotificationController.java [modify] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java [modify] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java [modify] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java [modify] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java [modify] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaImageManagerTest.java [modify] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerNotificationTest.java [modify] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerServiceLifecycleTest.java [modify] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerTestBase.java [modify] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationTestTabHolder.java [modify] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationTitleUpdatedTest.java [modify] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/content/public/android/BUILD.gn [modify] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/content/public/android/DEPS [modify] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/content/public/android/java/src/org/chromium/content/browser/MediaSessionImpl.java [modify] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/content/public/android/java/src/org/chromium/content_public/browser/MediaSessionObserver.java [add] https://crrev.com/0e8742cdbef2b71d88fc483f0cef4dfcd8763387/content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/febac5acd00932b5dc89fa05e4a1dcd9fed985aa commit febac5acd00932b5dc89fa05e4a1dcd9fed985aa Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Tue Nov 06 00:17:20 2018 Revert "[Media Session] [1/4] Move MediaMetadata to service" This reverts commit 93ee1837006400a4fde789787d70a7f09905cce8. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 605481 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzkzZWUxODM3MDA2NDAwYTRmZGU3ODk3ODdkNzBhN2YwOTkwNWNjZTgM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/8731 Sample Failed Step: compile Original change's description: > [Media Session] [1/4] Move MediaMetadata to service > > This CL moves the MediaMetadata and MediaImage mojo types > from Blink to the Media Session service along with their > mapped types in content. > > This is the first of four parts. > > BUG=875004 > > Change-Id: Ie862229bbeb474a60ccc4d2f82d8c4e1f8017b74 > Reviewed-on: https://chromium-review.googlesource.com/c/1227401 > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605481} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=875004 Change-Id: Ica72191d2b5700c793fbdcf61ce680faa938f0d5 Reviewed-on: https://chromium-review.googlesource.com/c/1318747 Cr-Commit-Position: refs/heads/master@{#605520} [modify] https://crrev.com/febac5acd00932b5dc89fa05e4a1dcd9fed985aa/mojo/public/tools/bindings/chromium_bindings_configuration.gni [modify] https://crrev.com/febac5acd00932b5dc89fa05e4a1dcd9fed985aa/services/BUILD.gn [delete] https://crrev.com/609317412066bcfa6278d2d83dfa02c2b4fbfd5b/services/media_session/DEPS [modify] https://crrev.com/febac5acd00932b5dc89fa05e4a1dcd9fed985aa/services/media_session/public/cpp/BUILD.gn [delete] https://crrev.com/609317412066bcfa6278d2d83dfa02c2b4fbfd5b/services/media_session/public/cpp/OWNERS [delete] https://crrev.com/609317412066bcfa6278d2d83dfa02c2b4fbfd5b/services/media_session/public/cpp/android/BUILD.gn [delete] https://crrev.com/609317412066bcfa6278d2d83dfa02c2b4fbfd5b/services/media_session/public/cpp/android/java/src/org/chromium/services/media_session/MediaMetadata.java [delete] https://crrev.com/609317412066bcfa6278d2d83dfa02c2b4fbfd5b/services/media_session/public/cpp/media_metadata.cc [delete] https://crrev.com/609317412066bcfa6278d2d83dfa02c2b4fbfd5b/services/media_session/public/cpp/media_metadata.h [delete] https://crrev.com/609317412066bcfa6278d2d83dfa02c2b4fbfd5b/services/media_session/public/cpp/media_metadata_android.cc [delete] https://crrev.com/609317412066bcfa6278d2d83dfa02c2b4fbfd5b/services/media_session/public/cpp/media_session.typemap [delete] https://crrev.com/609317412066bcfa6278d2d83dfa02c2b4fbfd5b/services/media_session/public/cpp/media_session_mojom_traits.cc [delete] https://crrev.com/609317412066bcfa6278d2d83dfa02c2b4fbfd5b/services/media_session/public/cpp/media_session_mojom_traits.h [delete] https://crrev.com/609317412066bcfa6278d2d83dfa02c2b4fbfd5b/services/media_session/public/cpp/typemaps.gni [modify] https://crrev.com/febac5acd00932b5dc89fa05e4a1dcd9fed985aa/services/media_session/public/mojom/BUILD.gn [modify] https://crrev.com/febac5acd00932b5dc89fa05e4a1dcd9fed985aa/services/media_session/public/mojom/media_session.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071 commit e6a6d2073d9c5d8dfd61fc882aebd23fec63c071 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Nov 06 18:56:11 2018 [Media Session] Move enum to //services Move the MediaSessionAction enum from blink to //services. BUG=875004 Change-Id: I29a13b696b0d27facbb1fbf98a162f827d9a476e Reviewed-on: https://chromium-review.googlesource.com/c/1302694 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Sergey Volk <servolk@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#605764} [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/chrome/android/BUILD.gn [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationActionsUpdatedTest.java [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationButtonComputationTest.java [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerServiceActionsTest.java [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/chromecast/browser/cast_media_blocker_unittest.cc [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/content/browser/media/session/media_session_android.cc [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/content/browser/media/session/media_session_android.h [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/content/browser/media/session/media_session_impl.cc [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/content/browser/media/session/media_session_impl.h [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/content/browser/media/session/media_session_impl_browsertest.cc [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/content/browser/media/session/media_session_impl_service_routing_unittest.cc [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/content/browser/media/session/media_session_impl_uma_unittest.cc [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/content/browser/media/session/media_session_service_impl.cc [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/content/browser/media/session/media_session_service_impl.h [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/content/browser/media/session/media_session_service_impl_browsertest.cc [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/content/browser/media/session/media_session_uma_helper.h [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/content/browser/media/session/mock_media_session_observer.h [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/content/public/browser/media_session.h [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/content/public/browser/media_session_observer.h [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/services/media_session/public/mojom/media_session.mojom [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/third_party/WebKit/LayoutTests/media/mediasession/mojo/callback-alive-after-gc.html [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-action-reaches-client.html [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-set-handler-notifies-service.html [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/third_party/blink/public/BUILD.gn [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/third_party/blink/public/platform/modules/mediasession/media_session.mojom [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/third_party/blink/renderer/modules/mediasession/media_session.cc [modify] https://crrev.com/e6a6d2073d9c5d8dfd61fc882aebd23fec63c071/third_party/blink/renderer/modules/mediasession/media_session.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c185420af301cda24b0a9e1951d04b4de31d601c commit c185420af301cda24b0a9e1951d04b4de31d601c Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Nov 29 18:02:04 2018 Reland "[Media Session] [1/4] Move MediaMetadata to service" This is a reland of 93ee1837006400a4fde789787d70a7f09905cce8 This includes a fix to //ash:ash_unittests which was throwing a linker error which resulted in the original being reverted. Original change's description: > [Media Session] [1/4] Move MediaMetadata to service > > This CL moves the MediaMetadata and MediaImage mojo types > from Blink to the Media Session service along with their > mapped types in content. > > This is the first of four parts. > > BUG=875004 > > Change-Id: Ie862229bbeb474a60ccc4d2f82d8c4e1f8017b74 > Reviewed-on: https://chromium-review.googlesource.com/c/1227401 > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605481} Bug: 875004 Change-Id: Id04143a89594a523f323ac16a54d93f1f2447367 Reviewed-on: https://chromium-review.googlesource.com/c/1318802 Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#612269} [modify] https://crrev.com/c185420af301cda24b0a9e1951d04b4de31d601c/ash/BUILD.gn [modify] https://crrev.com/c185420af301cda24b0a9e1951d04b4de31d601c/mojo/public/tools/bindings/chromium_bindings_configuration.gni [modify] https://crrev.com/c185420af301cda24b0a9e1951d04b4de31d601c/services/BUILD.gn [add] https://crrev.com/c185420af301cda24b0a9e1951d04b4de31d601c/services/media_session/DEPS [modify] https://crrev.com/c185420af301cda24b0a9e1951d04b4de31d601c/services/media_session/public/cpp/BUILD.gn [add] https://crrev.com/c185420af301cda24b0a9e1951d04b4de31d601c/services/media_session/public/cpp/OWNERS [add] https://crrev.com/c185420af301cda24b0a9e1951d04b4de31d601c/services/media_session/public/cpp/android/BUILD.gn [add] https://crrev.com/c185420af301cda24b0a9e1951d04b4de31d601c/services/media_session/public/cpp/android/java/src/org/chromium/services/media_session/MediaMetadata.java [add] https://crrev.com/c185420af301cda24b0a9e1951d04b4de31d601c/services/media_session/public/cpp/media_metadata.cc [add] https://crrev.com/c185420af301cda24b0a9e1951d04b4de31d601c/services/media_session/public/cpp/media_metadata.h [add] https://crrev.com/c185420af301cda24b0a9e1951d04b4de31d601c/services/media_session/public/cpp/media_metadata_android.cc [add] https://crrev.com/c185420af301cda24b0a9e1951d04b4de31d601c/services/media_session/public/cpp/media_session.typemap [add] https://crrev.com/c185420af301cda24b0a9e1951d04b4de31d601c/services/media_session/public/cpp/media_session_mojom_traits.cc [add] https://crrev.com/c185420af301cda24b0a9e1951d04b4de31d601c/services/media_session/public/cpp/media_session_mojom_traits.h [add] https://crrev.com/c185420af301cda24b0a9e1951d04b4de31d601c/services/media_session/public/cpp/typemaps.gni [modify] https://crrev.com/c185420af301cda24b0a9e1951d04b4de31d601c/services/media_session/public/mojom/BUILD.gn [modify] https://crrev.com/c185420af301cda24b0a9e1951d04b4de31d601c/services/media_session/public/mojom/media_session.mojom [modify] https://crrev.com/c185420af301cda24b0a9e1951d04b4de31d601c/third_party/blink/renderer/platform/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2ad0f87db14644b44c1baa7e17d5094aeef23ce commit d2ad0f87db14644b44c1baa7e17d5094aeef23ce Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Nov 30 01:46:20 2018 Reland "[Media Session] [2/4] Move Metadata to service" This is a reland of 0475617fe96a82edc816f083b76085450d4fb85e Binary-Size: Adding duplicate classes that will be removed in https://crrev.com/c/1241554 TBR=mlamouri@chromium.org,tedchoc@chromium.org Original change's description: > [Media Session] [2/4] Move Metadata to service > > This CL moves any existing uses in Android of MediaMetadata > to the new version in the media_session service. > > BUG=875004 > > Binary-Size: Adding duplicate classes that will be removed > in https://crrev.com/c/1241554 > > Change-Id: I8ed9afd45a37e515ae89d5d82a542a6f4c139136 > Reviewed-on: https://chromium-review.googlesource.com/c/1241466 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605498} Bug: 875004 Change-Id: I4689ac36b9dcf6b0582d4789016e238811b498e2 Reviewed-on: https://chromium-review.googlesource.com/c/1318809 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#612490} [modify] https://crrev.com/d2ad0f87db14644b44c1baa7e17d5094aeef23ce/chrome/android/BUILD.gn [modify] https://crrev.com/d2ad0f87db14644b44c1baa7e17d5094aeef23ce/chrome/android/DEPS [modify] https://crrev.com/d2ad0f87db14644b44c1baa7e17d5094aeef23ce/chrome/android/java/src/org/chromium/chrome/browser/media/remote/CastNotificationControl.java [modify] https://crrev.com/d2ad0f87db14644b44c1baa7e17d5094aeef23ce/chrome/android/java/src/org/chromium/chrome/browser/media/router/CastSessionUtil.java [modify] https://crrev.com/d2ad0f87db14644b44c1baa7e17d5094aeef23ce/chrome/android/java/src/org/chromium/chrome/browser/media/router/caf/CafNotificationController.java [modify] https://crrev.com/d2ad0f87db14644b44c1baa7e17d5094aeef23ce/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java [modify] https://crrev.com/d2ad0f87db14644b44c1baa7e17d5094aeef23ce/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java [modify] https://crrev.com/d2ad0f87db14644b44c1baa7e17d5094aeef23ce/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java [modify] https://crrev.com/d2ad0f87db14644b44c1baa7e17d5094aeef23ce/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java [modify] https://crrev.com/d2ad0f87db14644b44c1baa7e17d5094aeef23ce/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaImageManagerTest.java [modify] https://crrev.com/d2ad0f87db14644b44c1baa7e17d5094aeef23ce/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerNotificationTest.java [modify] https://crrev.com/d2ad0f87db14644b44c1baa7e17d5094aeef23ce/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerServiceLifecycleTest.java [modify] https://crrev.com/d2ad0f87db14644b44c1baa7e17d5094aeef23ce/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerTestBase.java [modify] https://crrev.com/d2ad0f87db14644b44c1baa7e17d5094aeef23ce/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationTestTabHolder.java [modify] https://crrev.com/d2ad0f87db14644b44c1baa7e17d5094aeef23ce/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationTitleUpdatedTest.java [modify] https://crrev.com/d2ad0f87db14644b44c1baa7e17d5094aeef23ce/content/public/android/BUILD.gn [modify] https://crrev.com/d2ad0f87db14644b44c1baa7e17d5094aeef23ce/content/public/android/DEPS [modify] https://crrev.com/d2ad0f87db14644b44c1baa7e17d5094aeef23ce/content/public/android/java/src/org/chromium/content/browser/MediaSessionImpl.java [modify] https://crrev.com/d2ad0f87db14644b44c1baa7e17d5094aeef23ce/content/public/android/java/src/org/chromium/content_public/browser/MediaSessionObserver.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11e0d834bbfd7d58fb5d12b53676739ded252272 commit 11e0d834bbfd7d58fb5d12b53676739ded252272 Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Nov 30 18:26:51 2018 [Media Session] [3/4] Move Metadata to service This CL moves any existing uses of content::MediaMetadata to the new media_session::MediaMetadata. BUG=875004 Change-Id: If4b2f889ffb2264daa2bc2f5d9403e9e18586856 Reviewed-on: https://chromium-review.googlesource.com/c/1241572 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#612704} [modify] https://crrev.com/11e0d834bbfd7d58fb5d12b53676739ded252272/content/browser/android/web_contents_observer_proxy.cc [modify] https://crrev.com/11e0d834bbfd7d58fb5d12b53676739ded252272/content/browser/media/session/media_metadata_sanitizer.cc [modify] https://crrev.com/11e0d834bbfd7d58fb5d12b53676739ded252272/content/browser/media/session/media_metadata_sanitizer.h [modify] https://crrev.com/11e0d834bbfd7d58fb5d12b53676739ded252272/content/browser/media/session/media_session_android.cc [modify] https://crrev.com/11e0d834bbfd7d58fb5d12b53676739ded252272/content/browser/media/session/media_session_android.h [modify] https://crrev.com/11e0d834bbfd7d58fb5d12b53676739ded252272/content/browser/media/session/media_session_impl.cc [modify] https://crrev.com/11e0d834bbfd7d58fb5d12b53676739ded252272/content/browser/media/session/media_session_impl.h [modify] https://crrev.com/11e0d834bbfd7d58fb5d12b53676739ded252272/content/browser/media/session/media_session_impl_browsertest.cc [modify] https://crrev.com/11e0d834bbfd7d58fb5d12b53676739ded252272/content/browser/media/session/media_session_impl_service_routing_unittest.cc [modify] https://crrev.com/11e0d834bbfd7d58fb5d12b53676739ded252272/content/browser/media/session/media_session_service_impl.cc [modify] https://crrev.com/11e0d834bbfd7d58fb5d12b53676739ded252272/content/browser/media/session/media_session_service_impl.h [modify] https://crrev.com/11e0d834bbfd7d58fb5d12b53676739ded252272/content/browser/media/session/mock_media_session_observer.h [modify] https://crrev.com/11e0d834bbfd7d58fb5d12b53676739ded252272/content/public/browser/media_session_observer.h [modify] https://crrev.com/11e0d834bbfd7d58fb5d12b53676739ded252272/services/media_session/public/cpp/media_metadata.h [modify] https://crrev.com/11e0d834bbfd7d58fb5d12b53676739ded252272/services/media_session/public/cpp/media_metadata_android.cc [modify] https://crrev.com/11e0d834bbfd7d58fb5d12b53676739ded252272/third_party/blink/public/platform/modules/mediasession/media_session.mojom [modify] https://crrev.com/11e0d834bbfd7d58fb5d12b53676739ded252272/third_party/blink/renderer/modules/mediasession/DEPS [modify] https://crrev.com/11e0d834bbfd7d58fb5d12b53676739ded252272/third_party/blink/renderer/modules/mediasession/media_metadata_sanitizer.cc [modify] https://crrev.com/11e0d834bbfd7d58fb5d12b53676739ded252272/third_party/blink/renderer/modules/mediasession/media_metadata_sanitizer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88c43d22c352b4d49dc0398b20407dde4cae80e6 commit 88c43d22c352b4d49dc0398b20407dde4cae80e6 Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Nov 30 20:12:32 2018 [Media Session] Add metadata changed to observer Add the MediaSessionMetadataChanged event to the observer that will be fired if the metadata associated with the media session changes. This will be used for the notification to display metadata of the currently playing media. BUG=875004 Change-Id: I17d4e2af8b1d3b5b6213ec2eaaf0c29eb58c5937 Reviewed-on: https://chromium-review.googlesource.com/c/1316659 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#612749} [modify] https://crrev.com/88c43d22c352b4d49dc0398b20407dde4cae80e6/ash/media/media_notification_controller.cc [modify] https://crrev.com/88c43d22c352b4d49dc0398b20407dde4cae80e6/ash/media/media_notification_controller.h [modify] https://crrev.com/88c43d22c352b4d49dc0398b20407dde4cae80e6/content/browser/media/session/audio_focus_delegate_default_browsertest.cc [modify] https://crrev.com/88c43d22c352b4d49dc0398b20407dde4cae80e6/content/browser/media/session/media_session_impl.cc [modify] https://crrev.com/88c43d22c352b4d49dc0398b20407dde4cae80e6/content/browser/media/session/media_session_impl_browsertest.cc [modify] https://crrev.com/88c43d22c352b4d49dc0398b20407dde4cae80e6/content/browser/media/session/media_session_impl_service_routing_unittest.cc [modify] https://crrev.com/88c43d22c352b4d49dc0398b20407dde4cae80e6/services/media_session/media_controller.cc [modify] https://crrev.com/88c43d22c352b4d49dc0398b20407dde4cae80e6/services/media_session/media_controller.h [modify] https://crrev.com/88c43d22c352b4d49dc0398b20407dde4cae80e6/services/media_session/media_controller_unittest.cc [modify] https://crrev.com/88c43d22c352b4d49dc0398b20407dde4cae80e6/services/media_session/public/cpp/test/mock_media_session.cc [modify] https://crrev.com/88c43d22c352b4d49dc0398b20407dde4cae80e6/services/media_session/public/cpp/test/mock_media_session.h [modify] https://crrev.com/88c43d22c352b4d49dc0398b20407dde4cae80e6/services/media_session/public/mojom/media_session.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d055280094302e0fa9ebd9034f5c58949742db09 commit d055280094302e0fa9ebd9034f5c58949742db09 Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Nov 30 20:13:10 2018 [Media Session] [4/4] Move Metadata to service This CL deletes the old content::MediaMetadata types. BUG=875004 Change-Id: Ia6c5fa76090d2e848261207d6a0dc28e782a4db3 Reviewed-on: https://chromium-review.googlesource.com/c/1241554 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#612750} [modify] https://crrev.com/d055280094302e0fa9ebd9034f5c58949742db09/content/common/BUILD.gn [delete] https://crrev.com/88c43d22c352b4d49dc0398b20407dde4cae80e6/content/common/android/media_metadata_android.cc [delete] https://crrev.com/88c43d22c352b4d49dc0398b20407dde4cae80e6/content/common/android/media_metadata_android.h [delete] https://crrev.com/88c43d22c352b4d49dc0398b20407dde4cae80e6/content/common/media/media_session.typemap [delete] https://crrev.com/88c43d22c352b4d49dc0398b20407dde4cae80e6/content/common/media/media_session_struct_traits.h [modify] https://crrev.com/d055280094302e0fa9ebd9034f5c58949742db09/content/common/typemaps.gni [modify] https://crrev.com/d055280094302e0fa9ebd9034f5c58949742db09/content/public/android/BUILD.gn [delete] https://crrev.com/88c43d22c352b4d49dc0398b20407dde4cae80e6/content/public/android/java/src/org/chromium/content_public/common/MediaMetadata.java [modify] https://crrev.com/d055280094302e0fa9ebd9034f5c58949742db09/content/public/common/BUILD.gn [delete] https://crrev.com/88c43d22c352b4d49dc0398b20407dde4cae80e6/content/public/common/media_metadata.cc [delete] https://crrev.com/88c43d22c352b4d49dc0398b20407dde4cae80e6/content/public/common/media_metadata.h
Comment 1 by beccahughes@chromium.org
, Aug 16