New issue
Advanced search Search tips

Issue 875003 link

Starred by 0 users
Status: Fixed
Owner:
saklein@chromium.org
Closed: Nov 15
Cc:
vapier@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocked on:
issue 893754


Sign in to add a comment

security_test_image: move to chromite

Project Member Reported by vapier@chromium.org, Aug 16 
we should be able to do a straight port to chromite.  steps:
(1) implement chromite/scripts/security_test_image.py that provides same functionality as src/scripts/security_test_image
(2) update single caller in chromite to use new security_test_image.py
(3) delete security_test_image from src/scripts/

Comment 1 by vapier@chromium.org, Oct 9

Blockedon: 893754

Comment 2 by saklein@chromium.org, Oct 22

Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/c2e13fd6594226881b2830e9d6428069fdfa2cee

commit c2e13fd6594226881b2830e9d6428069fdfa2cee
Author: Alex Klein <saklein@chromium.org>
Date: Wed Nov 07 14:34:13 2018

security_test_image: delete bash script

New python version in chromite should be preferred.

BUG= chromium:875003 
TEST=precq
CQ-DEPEND=CL:1302253

Change-Id: Ia56b2af2403893797929a80ab92af6cb324c160f
Reviewed-on: https://chromium-review.googlesource.com/1302273
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/c924c2c400cff1aee041b776c22908cadb443604/security_test_image
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/fa719c9e6f78a861d7b0c975baac0414cb2980b1

commit fa719c9e6f78a861d7b0c975baac0414cb2980b1
Author: Alex Klein <saklein@chromium.org>
Date: Wed Nov 07 14:34:13 2018

security_test_image: port to chromite

BUG= chromium:875003 
TEST=new tests, run_tests
TEST=build_packages --board=reef && build_image --board=reef && \
     mod_image_for_recovery.sh --board=reef && security_test_image --board=reef
CQ-DEPEND=CL:1302273

Change-Id: I78f64a66cce28ec11b4e732ed87a61db1568c5ba
Reviewed-on: https://chromium-review.googlesource.com/1302253
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/fa719c9e6f78a861d7b0c975baac0414cb2980b1/lib/image_lib_unittest.py
[add] https://crrev.com/fa719c9e6f78a861d7b0c975baac0414cb2980b1/scripts/security_test_image_unittest
[modify] https://crrev.com/fa719c9e6f78a861d7b0c975baac0414cb2980b1/cbuildbot/commands.py
[add] https://crrev.com/fa719c9e6f78a861d7b0c975baac0414cb2980b1/lib/signing_unittest
[modify] https://crrev.com/fa719c9e6f78a861d7b0c975baac0414cb2980b1/lib/failure_message_lib_unittest.py
[add] https://crrev.com/fa719c9e6f78a861d7b0c975baac0414cb2980b1/scripts/security_test_image.py
[modify] https://crrev.com/fa719c9e6f78a861d7b0c975baac0414cb2980b1/lib/signing.py
[add] https://crrev.com/fa719c9e6f78a861d7b0c975baac0414cb2980b1/bin/security_test_image
[add] https://crrev.com/fa719c9e6f78a861d7b0c975baac0414cb2980b1/lib/signing_unittest.py
[modify] https://crrev.com/fa719c9e6f78a861d7b0c975baac0414cb2980b1/lib/image_lib.py
[add] https://crrev.com/fa719c9e6f78a861d7b0c975baac0414cb2980b1/scripts/security_test_image_unittest.py

Comment 5 by saklein@chromium.org, Nov 15

Status: Fixed (was: Started)
►

Sign in to add a comment