New issue
Advanced search Search tips

Issue 875002 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Steady State Elisions: Reset URL doesn't work if user has unelided the URL

Project Member Reported by tommycli@chromium.org, Aug 16

Issue description

Currently, if the user has unelided the URL, the URL won't reset on navigation.

Instead, we should only only preserve the URL if the user has actually made modifications, rather than merely uneliding the URL.
 
Summary: Steady State Elisions: Reset URL doesn't work if user has unelided the URL (was: Steady State Elisions: Reset URL doesn't work if user has unelided the RUL)
Do you have a set of repro steps?
Repro steps:

1. Go to: https://www.w3schools.com/code/tryit.asp?filename=FUC3XIOWU1Y3
2. Press the Run over the code
3. Press the "Try it" button in the right pane.
4. Within 3 seconds, make a partial selection in the Omnibox so the URL become unelided.
5. Notice that after the tab redirects to yahoo.com, the URL is not updated.

--

This bug is noticeable if the website performs a navigation while the user has unelided (but not edited) the URL.
Components: UI>Browser>Omnibox
Labels: M-70
I agree with the P3 rating here.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02035ae5926720d49bcd4a1bae42df4ffd6ac158

commit 02035ae5926720d49bcd4a1bae42df4ffd6ac158
Author: Tommy C. Li <tommycli@chromium.org>
Date: Fri Aug 17 14:14:52 2018

Omnibox: Steady State Elisions - Reset URL unless user has edited it

Currently, if the user has unelided the URL, the URL won't reset on
navigation.

Instead, we should only only preserve the URL if the user has actually
made modifications, rather than merely uneliding the URL.

Bug:  875002 
Change-Id: Ie138ee9a0b4cf7d7d903d600a739deb2378de29c
Reviewed-on: https://chromium-review.googlesource.com/1178631
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584056}
[modify] https://crrev.com/02035ae5926720d49bcd4a1bae42df4ffd6ac158/components/omnibox/browser/omnibox_edit_model.cc

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 6

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c346669c9ad660bee51869367a07b38116dd9b2

commit 9c346669c9ad660bee51869367a07b38116dd9b2
Author: Tommy C. Li <tommycli@chromium.org>
Date: Thu Sep 06 15:00:53 2018

Omnibox: Steady State Elisions - Reset URL unless user has edited it

Currently, if the user has unelided the URL, the URL won't reset on
navigation.

Instead, we should only only preserve the URL if the user has actually
made modifications, rather than merely uneliding the URL.

Bug:  875002 
Change-Id: Ie138ee9a0b4cf7d7d903d600a739deb2378de29c
Reviewed-on: https://chromium-review.googlesource.com/1178631
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#584056}(cherry picked from commit 02035ae5926720d49bcd4a1bae42df4ffd6ac158)
Reviewed-on: https://chromium-review.googlesource.com/1210542
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#892}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/9c346669c9ad660bee51869367a07b38116dd9b2/components/omnibox/browser/omnibox_edit_model.cc

Labels: CommitLog-Audit-Violation Merge-Without-Approval M-69
Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision 9c346669c9ad660bee51869367a07b38116dd9b2 was merged to refs/branch-heads/3497 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!

Sign in to add a comment