New issue
Advanced search Search tips

Issue 874992 link

Starred by 1 user
Status: Fixed
Owner:
saklein@chromium.org
Closed: Oct 4
Cc:
vapier@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

image_test: add support for blacklisted packages

Project Member Reported by vapier@chromium.org, Aug 16 
we currently have a helper named "check_blacklist" in build_image.  this just checks the image to see if a few packages are installed and if so, fails the build.  we should be able to move this to chromite easily.

steps:
(1) update chromite/cros/test/image_test.py to check for blacklisted packages (maybe add a new TestBlacklistedPackages to BlacklistTest) and blacklisted (maybe add a new TestBlacklistedFiles to BlacklistTest)
(2) add all the packages listed in build_library/chromeos_blacklist to the Packages test
(3) add some main program binary names to the Files test (e.g. /usr/bin/perl)
(4) delete check_blacklist, chromeos_blacklist, and get_package_list from src/scripts/
(5) delete all skip_blacklist_check from all overlays

Comment 1 Deleted

Comment 2 Deleted

Comment 3 Deleted

Comment 4 by saklein@chromium.org, Sep 20

Status: Started (was: Available)

Comment 5 by saklein@chromium.org, Sep 26 

Many of the skip_blacklist_check instances make note that it's there to allow python. Is that just something we don't need to worry about?

A few of them also have skip_test_image_content, but I can't find anywhere that that's checked. Has that been deprecated? There's a few board_specific_setup files that can be deleted all together if that's not used.

Comment 6 by vapier@chromium.org, Sep 27 

i deleted skip_test_image_content semi-recently, so any code that still sets it should be cleaned up (i was just lazy with this knob and prob missed some)

for the boards that set skip_blacklist_check, might want to check to see if they also set image_test=False in chromite/config/chromeos_config.py.  from what i vaguely remember, there's a large overlap.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/533eb6586de69501fe2b3675356c1648aa75e16d

commit 533eb6586de69501fe2b3675356c1648aa75e16d
Author: Alex Klein <saklein@chromium.org>
Date: Thu Oct 04 00:38:02 2018

build_image: move package blacklist to chromite

The blacklisted packages check more appropriately fits in chromite's
image_test.

BUG= chromium:874992 
TEST=precq
CQ-DEPEND=CL:1252350

Change-Id: Id1484994184fb7c81e1a6ffdb5b4e1e182a53c4d
Reviewed-on: https://chromium-review.googlesource.com/1252561
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/533eb6586de69501fe2b3675356c1648aa75e16d/build_library/build_image_util.sh
[delete] https://crrev.com/fd9652be987081cf975a03af3d63ec376b50d56b/get_package_list
[modify] https://crrev.com/533eb6586de69501fe2b3675356c1648aa75e16d/build_image
[delete] https://crrev.com/fd9652be987081cf975a03af3d63ec376b50d56b/build_library/chromeos_blacklist
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f8aa25fa1e19a8a50e9b8a3517fa6fd855e33dc8

commit f8aa25fa1e19a8a50e9b8a3517fa6fd855e33dc8
Author: Alex Klein <saklein@chromium.org>
Date: Thu Oct 04 00:38:03 2018

image_test: adding blacklist support

The blacklist packages were checked in build_image. This is more
appropriately placed with in image_test with a number of other
checks that test the image validity.

BUG= chromium:874992 
TEST=precq
CQ-DEPEND=CL:1252561

Change-Id: Ie661711a3374ee76067ea5ed4c8b39519e01263a
Reviewed-on: https://chromium-review.googlesource.com/1252350
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/f8aa25fa1e19a8a50e9b8a3517fa6fd855e33dc8/cros/test/image_test.py
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/c4a8180ee9d19f08edea626edbb451a7bdad7804

commit c4a8180ee9d19f08edea626edbb451a7bdad7804
Author: Alex Klein <saklein@chromium.org>
Date: Thu Oct 04 07:37:08 2018

build_image: remove skip_blacklist_check from overlays

The blacklist tests have been moved to chromite, and so the bash
variant and the associated skip_blacklist_check are no longer
necessary.

BUG= chromium:874992 
TEST=precq
CQ-DEPEND=CL:1252350, CL:1252561
RELEASE_NOTE=None

Change-Id: Ie61ecb96c7194df4fe87a605f6e44d96a6c1081a
Reviewed-on: https://chromium-review.googlesource.com/1252562
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c4a8180ee9d19f08edea626edbb451a7bdad7804/overlay-sama5d3/scripts/board_specific_setup.sh
[modify] https://crrev.com/c4a8180ee9d19f08edea626edbb451a7bdad7804/overlay-beaglebone/scripts/board_specific_setup.sh
[delete] https://crrev.com/14bc5719f48b0064b94fa5562ca8efc41b1d50e7/overlay-mipsel-o32-generic/scripts/board_specific_setup.sh
[modify] https://crrev.com/c4a8180ee9d19f08edea626edbb451a7bdad7804/overlay-lakitu/scripts/board_specific_setup.sh
[delete] https://crrev.com/14bc5719f48b0064b94fa5562ca8efc41b1d50e7/overlay-variant-daisy-embedded/scripts/board_specific_setup.sh
[delete] https://crrev.com/14bc5719f48b0064b94fa5562ca8efc41b1d50e7/project-mobbase/scripts/board_specific_setup.sh
[modify] https://crrev.com/c4a8180ee9d19f08edea626edbb451a7bdad7804/overlay-raspberrypi/scripts/board_specific_setup.sh

Comment 10 by saklein@chromium.org, Oct 4

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-storm-private/+/513e7bb7b94a9b3ee5a884a34a2078de049b03fc

commit 513e7bb7b94a9b3ee5a884a34a2078de049b03fc
Author: Alex Klein <saklein@chromium.org>
Date: Thu Oct 04 16:54:31 2018
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-metis-private/+/9706d33928310874157dbfa91a7ab1a5b06b8d93

commit 9706d33928310874157dbfa91a7ab1a5b06b8d93
Author: Alex Klein <saklein@chromium.org>
Date: Fri Oct 05 00:09:09 2018
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-arkham-private/+/75985c2c6f76147c2f590010aa6a652470da78ce

commit 75985c2c6f76147c2f590010aa6a652470da78ce
Author: Alex Klein <saklein@chromium.org>
Date: Fri Oct 05 00:09:18 2018
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-loonix-private/+/dd9ded0cb6bf8444319a2fee2d5d2126e5d2abe6

commit dd9ded0cb6bf8444319a2fee2d5d2126e5d2abe6
Author: Alex Klein <saklein@chromium.org>
Date: Fri Oct 05 00:09:10 2018
►

Sign in to add a comment