New issue
Advanced search Search tips

Issue 874988 link

Starred by 0 users
Status: Fixed
Owner:
saklein@chromium.org
Closed: Oct 2
Cc:
vapier@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

run_chroot_version_hooks: move to chromite

Project Member Reported by vapier@chromium.org, Aug 16 
we should be able to do a straight port to chromite.  steps:
(1) implement chromite/scripts/run_chroot_version_hooks.py that provides same functionality as src/scripts/run_chroot_version_hooks
(1a) leave chroot_version_hooks.d in src/scripts/ for now
(2) make sure nothing references run_chroot_version_hooks via absolute path (everything should only use $PATH).  can use cs/ to find users.
(3) delete run_chroot_version_hooks from src/scripts/

Comment 1 by saklein@chromium.org, Sep 10

Status: Started (was: Available)
I don't see any usages of the --version or --skipfirst flags.
Are those deprecated, or just meant to only be used manually?

If not deprecated:

Is skipfirst just meant to let you skip the current one if you run it and one of the scripts doesn't work?

Since there's not a warning about it being dangerous, I'm assuming --version is meant to be used to let you rerun scripts rather than arbitrarily skip ahead.
Is that right? 
Should that be enforced at all? Maybe a warning+exit and a force flag to go with it, or just prompt for confirmation?

Comment 2 by vapier@chromium.org, Sep 10 

nothing seems to user either flag.  so you could land a CL in src/scripts/ to delete the flags so we know for sure.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/5d2671442a5a09ec0ba335aab1c4e859d9cb610f

commit 5d2671442a5a09ec0ba335aab1c4e859d9cb610f
Author: Alex Klein <saklein@chromium.org>
Date: Tue Sep 11 07:40:54 2018

run_chroot_version_hooks: removing unused arguments.

In preparation for porting the script to python, unused arguments
are being removed to confirm their non-use before the transition.

BUG= chromium:874988 
TEST=manual, precq

Change-Id: I555837b1c2c9d159e5e6709e619a820de7110c25
Reviewed-on: https://chromium-review.googlesource.com/1216806
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/5d2671442a5a09ec0ba335aab1c4e859d9cb610f/run_chroot_version_hooks
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/998ad81680e0a34ae88a3f6a46546f237493bca0

commit 998ad81680e0a34ae88a3f6a46546f237493bca0
Author: Alex Klein <saklein@chromium.org>
Date: Fri Sep 21 04:30:07 2018

cros_sdk_lib: Remove unused argument

The buildroot argument for the version function and chroot ready
check is not used. Eliminate it to simplify.

BUG= chromium:874988 
TEST=run_tests

Change-Id: I5db8d9a44a89bcedb15621317e6fe0bc596fce49
Reviewed-on: https://chromium-review.googlesource.com/1236535
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/998ad81680e0a34ae88a3f6a46546f237493bca0/lib/cros_sdk_lib.py
[modify] https://crrev.com/998ad81680e0a34ae88a3f6a46546f237493bca0/cbuildbot/stages/workspace_stages.py
[modify] https://crrev.com/998ad81680e0a34ae88a3f6a46546f237493bca0/cbuildbot/stages/build_stages.py
[modify] https://crrev.com/998ad81680e0a34ae88a3f6a46546f237493bca0/lib/cros_sdk_lib_unittest.py
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/e66c64dd5f203dc484f53a6005a27fda7f2863ed

commit e66c64dd5f203dc484f53a6005a27fda7f2863ed
Author: Alex Klein <saklein@chromium.org>
Date: Tue Oct 02 12:19:11 2018

run_chroot_version_hooks: port to python/chromite

Port the src/scripts bash version of the run_chroot_version_hooks
update script to python and relocate to chromite.

BUG= chromium:874988 
TEST=new tests
CQ-DEPEND=CL:1236535, CL:1236781, CL:1236782

Change-Id: Ib71ffd632d3a55ffc448038868753d8b0b669c4b
Reviewed-on: https://chromium-review.googlesource.com/1236536
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/e66c64dd5f203dc484f53a6005a27fda7f2863ed/lib/cros_sdk_lib.py
[modify] https://crrev.com/e66c64dd5f203dc484f53a6005a27fda7f2863ed/lib/chroot_util.py
[modify] https://crrev.com/e66c64dd5f203dc484f53a6005a27fda7f2863ed/lib/cros_sdk_lib_unittest.py
[add] https://crrev.com/e66c64dd5f203dc484f53a6005a27fda7f2863ed/bin/run_chroot_version_hooks
[add] https://crrev.com/e66c64dd5f203dc484f53a6005a27fda7f2863ed/scripts/run_chroot_version_hooks.py
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/e5e0ea9b908fb175459447430159cbbdfad2f674

commit e5e0ea9b908fb175459447430159cbbdfad2f674
Author: Alex Klein <saklein@chromium.org>
Date: Tue Oct 02 12:19:10 2018

run_chroot_version_hooks: update usages

The run_chroot_version_hooks script has been ported to chromite,
and old references need to be updated.

BUG= chromium:874988 
TEST=precq
CQ-DEPEND=CL:1236536

Change-Id: Ifbd8810bf3f89a415ccb191f247fc88273178c6c
Reviewed-on: https://chromium-review.googlesource.com/1236781
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/e5e0ea9b908fb175459447430159cbbdfad2f674/update_chroot
[modify] https://crrev.com/e5e0ea9b908fb175459447430159cbbdfad2f674/sdk_lib/make_chroot.sh
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/8c2031297ccc1dffa635c16c52977c9add7c34cf

commit 8c2031297ccc1dffa635c16c52977c9add7c34cf
Author: Alex Klein <saklein@chromium.org>
Date: Tue Oct 02 12:19:10 2018

run_chroot_version_hooks: remove bash script.

The run_chroot_version_hooks script has been ported to a chromite
python script. Remove the bash version of the script in favor of
the new python version.

BUG= chromium:874988 
TEST=precq
CQ-DEPEND=CL:1236536

Change-Id: I30307b247d9688a9c7a162b6ed5ab9711ad8a80e
Reviewed-on: https://chromium-review.googlesource.com/1236782
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/e5e0ea9b908fb175459447430159cbbdfad2f674/run_chroot_version_hooks

Comment 8 by saklein@chromium.org, Oct 2

Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/38750c37387c1cf327f004bd52d8600eb1416148

commit 38750c37387c1cf327f004bd52d8600eb1416148
Author: Alex Klein <saklein@chromium.org>
Date: Wed Nov 07 14:34:36 2018

run_chroot_version_hooks: cleanup vestigal method

The switch to a full chroot update on builders rather than simple
run version hooks leaves an unused method. Remove it.

BUG= chromium:874988 
TEST=run_tests

Change-Id: I90ec94f438064a1ee9428a1827026c0549817901
Reviewed-on: https://chromium-review.googlesource.com/1315769
Commit-Ready: Alex Klein <saklein@chromium.org>
Tested-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/38750c37387c1cf327f004bd52d8600eb1416148/cbuildbot/commands.py
►

Sign in to add a comment