EvictDelegatedFrame should evict the last activated surface, not the fallback |
||||
Issue descriptionThe fallback does not necessarily even exist, so EvictDelegatedFrame should evict the last SurfaceId passed to OnFirstSurfaceActivation instead.
,
Aug 16
Can you link code search?
,
Aug 26
,
Sep 14
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/241d50b9c1c7b7a625eba75314afde3ee42200bb commit 241d50b9c1c7b7a625eba75314afde3ee42200bb Author: Saman Sami <samans@chromium.org> Date: Tue Sep 18 00:25:28 2018 Evict the last activated surface instead of fallback Last activated surface and fallback are no longer the same thing. Taking the SurfaceId from the SurfaceLayer's fallback no longer works properly. Bug: 874983 Change-Id: I772e69f7e009935086e090c859c1300caec6283e Reviewed-on: https://chromium-review.googlesource.com/1225990 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by: Khushal <khushalsagar@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#591894} [modify] https://crrev.com/241d50b9c1c7b7a625eba75314afde3ee42200bb/ui/android/delegated_frame_host_android.cc
,
Sep 18
|
||||
►
Sign in to add a comment |
||||
Comment 1 by akaba@chromium.org
, Aug 16Isn't fallback being set to this SurfaceId via: client_->DelegatedFrameHostGetLayer()->SetFallbackSurfaceId( surface_info.id()); ?