New issue
Advanced search Search tips

Issue 874968 link

Starred by 1 user
Status: Fixed
Owner:
siggi@chromium.org
Closed: Sep 27
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 755840



Sign in to add a comment

chrome://discards page should have a DB view

Project Member Reported by siggi@chromium.org, Aug 16 
For the purposes of diagnosis and bug reporting, it's nice to have a DB view in the chrome://discards page.
This should show:
1. The number of entries in the DB.
2. The amount of disk space consumed by the DB.
3. All in-memory DB entries listed by their origin.
4. A way to lookup and display the entry associated with a specified origin.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8233a668ea1aba041c9fc937b31159dbb935a0a9

commit 8233a668ea1aba041c9fc937b31159dbb935a0a9
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Fri Aug 24 15:07:05 2018

RC: Add an inspection interface to DB implementation.

Bug:  874968 
Change-Id: I32c3ab375b033f64436f47cc1fa2186a5b63178a
Reviewed-on: https://chromium-review.googlesource.com/1187181
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585840}
[modify] https://crrev.com/8233a668ea1aba041c9fc937b31159dbb935a0a9/chrome/browser/BUILD.gn
[modify] https://crrev.com/8233a668ea1aba041c9fc937b31159dbb935a0a9/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
[modify] https://crrev.com/8233a668ea1aba041c9fc937b31159dbb935a0a9/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/8233a668ea1aba041c9fc937b31159dbb935a0a9/chrome/browser/resource_coordinator/local_site_characteristics_data_store.cc
[modify] https://crrev.com/8233a668ea1aba041c9fc937b31159dbb935a0a9/chrome/browser/resource_coordinator/local_site_characteristics_data_store.h
[modify] https://crrev.com/8233a668ea1aba041c9fc937b31159dbb935a0a9/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory.cc
[add] https://crrev.com/8233a668ea1aba041c9fc937b31159dbb935a0a9/chrome/browser/resource_coordinator/local_site_characteristics_data_store_inspector.cc
[add] https://crrev.com/8233a668ea1aba041c9fc937b31159dbb935a0a9/chrome/browser/resource_coordinator/local_site_characteristics_data_store_inspector.h
[modify] https://crrev.com/8233a668ea1aba041c9fc937b31159dbb935a0a9/chrome/browser/resource_coordinator/local_site_characteristics_data_store_unittest.cc
[modify] https://crrev.com/8233a668ea1aba041c9fc937b31159dbb935a0a9/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.cc
[modify] https://crrev.com/8233a668ea1aba041c9fc937b31159dbb935a0a9/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.h
[modify] https://crrev.com/8233a668ea1aba041c9fc937b31159dbb935a0a9/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be5b1d8ad4cfd4393221368004c400d8af1fbce8

commit be5b1d8ad4cfd4393221368004c400d8af1fbce8
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Fri Aug 31 20:39:08 2018

RC: Expand chrome://discards page with a database view.

Bug:  874968 
Change-Id: I05a6fb88d7a013c7df74234f4ece03d53c275789
Reviewed-on: https://chromium-review.googlesource.com/1178236
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588155}
[modify] https://crrev.com/be5b1d8ad4cfd4393221368004c400d8af1fbce8/chrome/browser/browser_resources.grd
[modify] https://crrev.com/be5b1d8ad4cfd4393221368004c400d8af1fbce8/chrome/browser/resource_coordinator/local_site_characteristics_data_store.cc
[modify] https://crrev.com/be5b1d8ad4cfd4393221368004c400d8af1fbce8/chrome/browser/resource_coordinator/local_site_characteristics_data_store.h
[modify] https://crrev.com/be5b1d8ad4cfd4393221368004c400d8af1fbce8/chrome/browser/resource_coordinator/local_site_characteristics_data_store_inspector.h
[modify] https://crrev.com/be5b1d8ad4cfd4393221368004c400d8af1fbce8/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.cc
[modify] https://crrev.com/be5b1d8ad4cfd4393221368004c400d8af1fbce8/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.h
[add] https://crrev.com/be5b1d8ad4cfd4393221368004c400d8af1fbce8/chrome/browser/resources/discards/database_tab.html
[modify] https://crrev.com/be5b1d8ad4cfd4393221368004c400d8af1fbce8/chrome/browser/resources/discards/discards.css
[modify] https://crrev.com/be5b1d8ad4cfd4393221368004c400d8af1fbce8/chrome/browser/resources/discards/discards.html
[modify] https://crrev.com/be5b1d8ad4cfd4393221368004c400d8af1fbce8/chrome/browser/resources/discards/discards.js
[add] https://crrev.com/be5b1d8ad4cfd4393221368004c400d8af1fbce8/chrome/browser/resources/discards/discards_tab.html
[modify] https://crrev.com/be5b1d8ad4cfd4393221368004c400d8af1fbce8/chrome/browser/ui/webui/discards/discards.mojom
[modify] https://crrev.com/be5b1d8ad4cfd4393221368004c400d8af1fbce8/chrome/browser/ui/webui/discards/discards_ui.cc
[modify] https://crrev.com/be5b1d8ad4cfd4393221368004c400d8af1fbce8/chrome/browser/ui/webui/discards/discards_ui.h
[modify] https://crrev.com/be5b1d8ad4cfd4393221368004c400d8af1fbce8/chrome/test/data/webui/discards/discards_browsertest.js
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fa87f7580a7855a9220d531c015f5ad1494f93d

commit 1fa87f7580a7855a9220d531c015f5ad1494f93d
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Wed Sep 19 19:24:50 2018

RC: Add the load duration to the chrome://discards page.

Also drop some unused styles while I was in there.

Bug:  874968 
Change-Id: I44881e7b5eefd63db4d9999c37958ba825fe1cbf
Reviewed-on: https://chromium-review.googlesource.com/1228775
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592514}
[modify] https://crrev.com/1fa87f7580a7855a9220d531c015f5ad1494f93d/chrome/browser/resources/discards/database_tab.html
[modify] https://crrev.com/1fa87f7580a7855a9220d531c015f5ad1494f93d/chrome/browser/resources/discards/database_tab.js
[modify] https://crrev.com/1fa87f7580a7855a9220d531c015f5ad1494f93d/chrome/browser/ui/webui/discards/discards.mojom
[modify] https://crrev.com/1fa87f7580a7855a9220d531c015f5ad1494f93d/chrome/browser/ui/webui/discards/discards_ui.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/903c89b78cbc47452ec1c869285eb51111650e76

commit 903c89b78cbc47452ec1c869285eb51111650e76
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Fri Sep 21 14:27:54 2018

RC: Better presentation and sorting for chrome://discards DB tab.

Bug:  874968 
Change-Id: Ie7b655ece8e9a98c73bb529181a79e3d9a7b7586
Reviewed-on: https://chromium-review.googlesource.com/1231922
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593172}
[modify] https://crrev.com/903c89b78cbc47452ec1c869285eb51111650e76/chrome/browser/browser_resources.grd
[modify] https://crrev.com/903c89b78cbc47452ec1c869285eb51111650e76/chrome/browser/resources/discards/BUILD.gn
[modify] https://crrev.com/903c89b78cbc47452ec1c869285eb51111650e76/chrome/browser/resources/discards/database_tab.html
[modify] https://crrev.com/903c89b78cbc47452ec1c869285eb51111650e76/chrome/browser/resources/discards/database_tab.js
[modify] https://crrev.com/903c89b78cbc47452ec1c869285eb51111650e76/chrome/browser/resources/discards/discards_tab.html
[modify] https://crrev.com/903c89b78cbc47452ec1c869285eb51111650e76/chrome/browser/resources/discards/discards_tab.js
[add] https://crrev.com/903c89b78cbc47452ec1c869285eb51111650e76/chrome/browser/resources/discards/sorted_table_behavior.html
[add] https://crrev.com/903c89b78cbc47452ec1c869285eb51111650e76/chrome/browser/resources/discards/sorted_table_behavior.js
[modify] https://crrev.com/903c89b78cbc47452ec1c869285eb51111650e76/chrome/browser/ui/webui/discards/discards_ui.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da256090b19203068eb6c2208be1ef491efef52c

commit da256090b19203068eb6c2208be1ef491efef52c
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Fri Sep 21 14:43:25 2018

RC: Expose the dirty bit for DB entries in chrome://discards.

Bug:  874968 
Change-Id: Id87498398908bfe8cf7e6c7ab596074b0575325a
Reviewed-on: https://chromium-review.googlesource.com/1236499
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593178}
[modify] https://crrev.com/da256090b19203068eb6c2208be1ef491efef52c/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/da256090b19203068eb6c2208be1ef491efef52c/chrome/browser/resource_coordinator/local_site_characteristics_data_store.cc
[modify] https://crrev.com/da256090b19203068eb6c2208be1ef491efef52c/chrome/browser/resource_coordinator/local_site_characteristics_data_store.h
[modify] https://crrev.com/da256090b19203068eb6c2208be1ef491efef52c/chrome/browser/resource_coordinator/local_site_characteristics_data_store_inspector.h
[modify] https://crrev.com/da256090b19203068eb6c2208be1ef491efef52c/chrome/browser/resource_coordinator/local_site_characteristics_data_store_unittest.cc
[modify] https://crrev.com/da256090b19203068eb6c2208be1ef491efef52c/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.cc
[modify] https://crrev.com/da256090b19203068eb6c2208be1ef491efef52c/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.h
[modify] https://crrev.com/da256090b19203068eb6c2208be1ef491efef52c/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store_unittest.cc
[modify] https://crrev.com/da256090b19203068eb6c2208be1ef491efef52c/chrome/browser/ui/webui/discards/discards_ui.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/525954c021bfdae0f91b53b67c67485189ef7892

commit 525954c021bfdae0f91b53b67c67485189ef7892
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Mon Sep 24 18:35:04 2018

RC: Implement the GetDatabaseSize interface.

A subsequent CL will plumb this out to the chrome://discards page.

Bug:  874968 
Change-Id: I18496f73a4a76cfe05151b67fb7cce4d9e256064
Reviewed-on: https://chromium-review.googlesource.com/1239002
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593607}
[modify] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.cc
[modify] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.h
[modify] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/resource_coordinator/leveldb_site_characteristics_database_unittest.cc
[modify] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/resource_coordinator/local_site_characteristics_data_unittest_utils.cc
[modify] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/resource_coordinator/local_site_characteristics_data_unittest_utils.h
[modify] https://crrev.com/525954c021bfdae0f91b53b67c67485189ef7892/chrome/browser/resource_coordinator/local_site_characteristics_database.h
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f83a361304c7f27ee2c6dbd29945196f1982359a

commit f83a361304c7f27ee2c6dbd29945196f1982359a
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Wed Sep 26 16:49:20 2018

RC: Fix the DB inspector for incognito tabs.

Bug:  874968 
Change-Id: Ifefec30eb6701cd6da584c54682fd4488a7e3527
Reviewed-on: https://chromium-review.googlesource.com/1246282
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594347}
[modify] https://crrev.com/f83a361304c7f27ee2c6dbd29945196f1982359a/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory.cc
[modify] https://crrev.com/f83a361304c7f27ee2c6dbd29945196f1982359a/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ccf732e873522d8013eb25478e8b76965b88833

commit 8ccf732e873522d8013eb25478e8b76965b88833
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Wed Sep 26 21:22:02 2018

RC: Allow quering for extra origins in chrome://discards.

Bug:  874968 
Change-Id: I289e12b23e3bac144615ca5cfbe861e22404170a
Reviewed-on: https://chromium-review.googlesource.com/1244497
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594476}
[modify] https://crrev.com/8ccf732e873522d8013eb25478e8b76965b88833/chrome/browser/resources/discards/database_tab.html
[modify] https://crrev.com/8ccf732e873522d8013eb25478e8b76965b88833/chrome/browser/resources/discards/database_tab.js

Comment 10 by siggi@chromium.org, Sep 27

Status: Fixed (was: Started)
I'm calling this fixed, as the features enumerated are done by Chrome 71.0.3563.0.
►

Sign in to add a comment