New issue
Advanced search Search tips

Issue 874954 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 28
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 877557



Sign in to add a comment

KeyboardOperations/FilesAppBrowserTest.Test/renameNewFolderDownloads_GuestMode fails

Project Member Reported by xidac...@chromium.org, Aug 16

Issue description

Owner: noel@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/382b4d0a9f86283bcb9fcfdfe2a437205d8386cb

commit 382b4d0a9f86283bcb9fcfdfe2a437205d8386cb
Author: Xida Chen <xidachen@chromium.org>
Date: Thu Aug 16 17:03:10 2018

Disable KeyboardOperations/FilesAppBrowserTest.Test/renameNewFolderDownloads_GuestMode

TBR=wjmaclean@chromium.org
NOTRY=true

Bug:  874954 
Change-Id: I197eddaa975cca5edb0db359fc44c127e6d64fec
Reviewed-on: https://chromium-review.googlesource.com/1178113
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583698}
[modify] https://crrev.com/382b4d0a9f86283bcb9fcfdfe2a437205d8386cb/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30a80e48d4ca9a4751340b2e2713b5915381f76a

commit 30a80e48d4ca9a4751340b2e2713b5915381f76a
Author: Noel Gordon <noel@chromium.org>
Date: Fri Aug 17 06:10:35 2018

Disable renameNewFolderDownloads* on Mash

Bug reported these tests flaking on Mash, but these tests got disabled
on all bots. Disable them on Mash, not everywhere.

Tbr: xidachen@chromium.org
Bug:  874954 ,  410163 
Change-Id: I80eb7b2cb185063d2e3e752fa0ae47d39fc97035
Reviewed-on: https://chromium-review.googlesource.com/1179427
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583973}
[modify] https://crrev.com/30a80e48d4ca9a4751340b2e2713b5915381f76a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/30a80e48d4ca9a4751340b2e2713b5915381f76a/testing/buildbot/filters/mash.browser_tests.filter

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96e58815e52961e857d8ad1eb9d9ce65f41099e8

commit 96e58815e52961e857d8ad1eb9d9ce65f41099e8
Author: Jennifer Apacible <apacible@chromium.org>
Date: Fri Aug 17 20:31:59 2018

Disable renameNewFolderDownloads_GuestMode on all platforms.

These are being disabled on all bots now as they fail on more bots than
just Mash.

TBR=noel@chromium.org
NOTRY=true (disabling test)

Bug:  874954 
Change-Id: I3b0f4076e7aa4f43abd52040e0120f0bcc8b8ca1
Reviewed-on: https://chromium-review.googlesource.com/1180277
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584178}
[modify] https://crrev.com/96e58815e52961e857d8ad1eb9d9ce65f41099e8/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/96e58815e52961e857d8ad1eb9d9ce65f41099e8/testing/buildbot/filters/mash.browser_tests.filter

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24056c1bd58950370f03fa3c1d1733271ad4ea51

commit 24056c1bd58950370f03fa3c1d1733271ad4ea51
Author: Noel Gordon <noel@chromium.org>
Date: Sat Aug 25 05:36:04 2018

Improve KeyboardOperations test: renameNewFolderDownloads

Test is flaky on the slower bots MSAN/ASAN with selection failures. Add
more steps, add step result checking. Use more precise selectors on the
file list operations. Do an initial focus on the file list. Load photos
only in SetUpAndWaitUntilReady (for more speed). Check that the renamed
folder is shown in the directory tree and the file list.

The new steps are cargo-culted from the create_new_folder.js test which
is a similar test, with similar selection flakes (fixed on CL:1186008).

Tbr: lucmult
Bug:  874954 , 877557 
Change-Id: Ib9f988e0dadafd0a52bd509ae664aa3cbfe395fb
Reviewed-on: https://chromium-review.googlesource.com/1188178
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586122}
[modify] https://crrev.com/24056c1bd58950370f03fa3c1d1733271ad4ea51/ui/file_manager/integration_tests/file_manager/keyboard_operations.js

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26603d47dc649ae7ba318d8c55064534e2f8a2d5

commit 26603d47dc649ae7ba318d8c55064534e2f8a2d5
Author: Noel Gordon <noel@chromium.org>
Date: Mon Aug 27 01:22:44 2018

Deflake KeyboardOperations renameNewFolderDownloads test

Sending Enter to the file-list container after sending an Enter key to
the list renaming text input element causes flaky failures on the bots
due to [renaming] complete racing with the processing of the file-list
container Enter key handling.

To verify that the Folder cannot be entered while it is being renamed,
send Enter to the file-list container before sending Enter to the text
input [renaming] element.

Bug:  874954 , 877557 , 410163 
Change-Id: Icf8ec215b4a4658e16940ab8ce9b1778f19f6235
Reviewed-on: https://chromium-review.googlesource.com/1188726
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586180}
[modify] https://crrev.com/26603d47dc649ae7ba318d8c55064534e2f8a2d5/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/26603d47dc649ae7ba318d8c55064534e2f8a2d5/ui/file_manager/integration_tests/file_manager/keyboard_operations.js

Blocking: 877557
Labels: OS-Chrome
Status: Fixed (was: Assigned)
Re-enabled on  issue 877557 , and is all-green so, so far, so good.

Sign in to add a comment