New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 874938 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug



Sign in to add a comment

SimpleChrome failing to compile with Assistant

Project Member Reported by josa...@google.com, Aug 16

Issue description

PFQ failing for all poppy devices due libassistant failures 

log snippet:
[9225/45666] ACTION //chromeos/assistant/internal:build_libassistant(//build/toolchain/cros:target)
FAILED: obj/chromeos/assistant/internal/libassistant.so libassistant.so 
python ../../chromeos/assistant/internal/build_libassistant.py --root_out_dir . --target_out_dir obj/chromeos/assistant/internal
________ running '/b/swarming/w/ir/kitchen-workdir/python_bin/python third_party/depot_tools/download_from_google_storage.py --no_resume --platform=linux* --no_auth --bucket chromium-gn -s buildtools/linux64/gn.sha1' in '/b/swarming/w/ir/cache/cbuild/repository/.cache/distfiles/target-master/chrome-src-internal/src/chromeos/assistant/libassistant/src'
________ running '/b/swarming/w/ir/kitchen-workdir/python_bin/python third_party/depot_tools/download_from_google_storage.py --no_resume --platform=linux* --no_auth --bucket chromium-clang-format -s buildtools/linux64/clang-format.sha1' in '/b/swarming/w/ir/cache/cbuild/repository/.cache/distfiles/target-master/chrome-src-internal/src/chromeos/assistant/libassistant/src'
________ running 'build/libassistant/install-sysroot.py --running-as-hook' in '/b/swarming/w/ir/cache/cbuild/repository/.cache/distfiles/target-master/chrome-src-internal/src/chromeos/assistant/libassistant/src'
Done. Made 423 targets from 190 files in 2678ms
ninja: Entering directory `obj/chromeos/assistant/internal'
[1/2130] STAMP obj/build/buildflag_header_h.stamp
[2/2130] STAMP obj/build/config/exe_and_shlib_deps.stamp
[3/2130] ACTION //base:build_date(//build/toolchain/cros:target)
[4/2130] CC obj/base/third_party/dynamic_annotations/dynamic_annotations/dynamic_annotations.o
FAILED: obj/base/third_party/dynamic_annotations/dynamic_annotations/dynamic_annotations.o 

full log:
https://luci-logdog.appspot.com/v/?s=chromeos/buildbucket/cr-buildbucket.appspot.com/8938049215227386208/+/steps/TestSimpleChromeWorkflow/0/stdout
 
Owner: xiaoh...@chromium.org
Status: Assigned (was: Unconfirmed)
This seems to be related to Issue 869510
Cc: tikuta@chromium.org manojgupta@chromium.org
Suepct CL: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1170712
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/fccde774f4800a42beee92116fe572afc1c4d047

commit fccde774f4800a42beee92116fe572afc1c4d047
Author: Manoj Gupta <manojgupta@chromium.org>
Date: Thu Aug 16 16:02:26 2018

Revert "cros_chrome_sdk: Invoke compiler in relative form"

This reverts commit 25c5ebd6302c7ed72f9475934ca8cacbbf5edbe9.

Reason for revert: Suspect that it caused chromium:874938

BUG= chromium:874938 

Original change's description:
> cros_chrome_sdk: Invoke compiler in relative form
> 
> This is retry of
> https://chromium-review.googlesource.com/1086958
> 
> Instead of enforcing relative path, I call compiler in relative path.
> 
> This is a part of effort for build cache sharing when using goma by
> removing absolute path from compile result.
> 
> This is one of following patch series to call compiler in relative path.
> https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1166926
> https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1170666
> https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1170712
> https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1170663
> 
> BUG=chromium:846610
> Change-Id: I950ffef918c67bd889dbe520d0e055ac583945d5
> Reviewed-on: https://chromium-review.googlesource.com/1170712
> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
> Tested-by: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
> Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
> Reviewed-by: Mike Frysinger <vapier@chromium.org>

Bug: chromium:846610
Change-Id: I1b82cb1011c76a887f06abbdbf333e1f653fe3d1
Reviewed-on: https://chromium-review.googlesource.com/1178021
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/fccde774f4800a42beee92116fe572afc1c4d047/cli/cros/cros_chrome_sdk.py

re #1, this is not related to Issue 869510.

The error is clang not found. Manoj already reverted the culprit cl. Let me know if there is anything else I need to do.  In the long term I will talk to Takuto to see how to adapt libassitant.so compilation to the new infra change.

/bin/sh: 1: ../../../../../../../../../../tmp/t/cbuildbot-tmpEUr3pc/chrome-sdk-cache6T0Q0f/cache/chrome-sdk/tarballs/eve+__b__swarming__w__ir__cache__cbuild__repository__buildbot_archive__eve-chrome-pfq__R70-10973.0.0-rc2+target_toolchain/bin/x86_64-cros-linux-gnu-clang: not found


Owner: manojgupta@chromium.org
Status: Verified (was: Assigned)
The error is gone from current eve/nocturne PFQ runs after the revert.

https://ci.chromium.org/p/chromeos/builders/luci.chromeos.general/Prod/b8938020678863402912
https://ci.chromium.org/p/chromeos/builders/luci.chromeos.general/Prod/b8938020682556945360
Sorry for breakage and thank you for revert.
I'll check internal build next time.

Sign in to add a comment