Consider removing VaapiJpegDecodeAccelerator::DecodeRequest |
||
Issue descriptionVaapiJpegDecodeAccelerator defines a DecodeRequest struct [1] which is only used to send data to DecodeTask() [2,3]. This struct is superfluous and only adds crud to the file. Consider removing it and just sending the 3 parameters directly to DecodeTask() (that'll need to change signature). [1] https://cs.chromium.org/chromium/src/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.cc?g=0&l=85 [2] https://cs.chromium.org/chromium/src/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.h?g=0&l=58 [3] https://cs.chromium.org/chromium/src/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.cc?g=0&l=330
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e92d897302d2c6f6770e76942ccdbbd83cfbff9 commit 1e92d897302d2c6f6770e76942ccdbbd83cfbff9 Author: Andres Calderon Jaramillo <andrescj@chromium.org> Date: Thu Aug 16 17:41:21 2018 Cleanup: remove DecodeRequest in VaapiJpegDecodeAccelerator. This CL simplifies VaapiJpegDecodeAccelerator by getting rid of the DecodeRequest struct: all the parameters that used to be in a DecodeRequest are now passed directly to the DecodeTask function. Bug: 874933 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0b09b15e5fd610eb02a9c83d90898e8619ea35af Reviewed-on: https://chromium-review.googlesource.com/1177907 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#583713} [modify] https://crrev.com/1e92d897302d2c6f6770e76942ccdbbd83cfbff9/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.cc [modify] https://crrev.com/1e92d897302d2c6f6770e76942ccdbbd83cfbff9/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.h
,
Aug 16
Good job! |
||
►
Sign in to add a comment |
||
Comment 1 by andrescj@chromium.org
, Aug 16