New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 874930 link

Starred by 1 user
Status: Fixed
Owner:
andrescj@chromium.org
Closed: Aug 17
Cc:
dcasta...@chromium.org
mcasas@chromium.org
█ mbarowsky+gpuimage@chromium.org
andrescj@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Fix error calls threading in VaapiJpegDecodeAccelerator

Project Member Reported by mcasas@chromium.org, Aug 16 
VaapiJpegDecodeAccelerator::Decode() runs on |io_task_runner_| [1]
but has a bunch of calls to NotifyErrorFromDecoderThread() (e.g. [2])
which wants to be on another thread. 

Possibly this has never been an issue because we don't build
with dcheck_always_on=true ...?


[1] https://cs.chromium.org/chromium/src/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.cc?g=0&l=307
[2] https://cs.chromium.org/chromium/src/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.cc?g=0&l=319

Comment 1 by mcasas@chromium.org, Aug 16

Owner: andrescj@chromium.org
andrescj@ could you take a look as you go? Thanks.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af572cbd797746cbf48e5173ed4988cdaada360b

commit af572cbd797746cbf48e5173ed4988cdaada360b
Author: Andres Calderon Jaramillo <andrescj@chromium.org>
Date: Fri Aug 17 16:48:15 2018

Fix DCHECK in VaapiJpegDecodeAccelerator::NotifyErrorFromDecoderThread.

This CL fixes the referenced bug by getting rid of the
VaapiJpegDecodeAccelerator::NotifyErrorFromDecoderThread function
entirely and ensuring that VaapiJpegDecodeAccelerator::NotifyError
notifies the client on the expected thread regardless of the thread
from which VaapiJpegDecodeAccelerator::NotifyError is called

Also, adds some documentation.

Bug:  874930 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id0556da800dd8d93e0c993d69aaa2ae041abf67d
Reviewed-on: https://chromium-review.googlesource.com/1178805
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584103}
[modify] https://crrev.com/af572cbd797746cbf48e5173ed4988cdaada360b/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.cc
[modify] https://crrev.com/af572cbd797746cbf48e5173ed4988cdaada360b/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.h

Comment 3 by andrescj@chromium.org, Aug 17

Status: Fixed (was: Assigned)
►

Sign in to add a comment