New issue
Advanced search Search tips

Issue 874918 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 17
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

31.6%-147.4% regression in rendering.mobile at 582172:582191

Project Member Reported by tdres...@chromium.org, Aug 16

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=874918

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=02b242fd0448a634d0dfb7d738468077f4fbcb77ea55b07db99b986e9f6fb1ce


Bot(s) for this bug's original alert(s):

Android Nexus5X WebView Perf
Cc: cduvall@chromium.org
Owner: cduvall@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/11a30742640000

Enable subresource redirects to all schemes with network service by cduvall@chromium.org
https://chromium.googlesource.com/chromium/src/+/b2680c227c2594e12eaab1962fc9d9e350616a19
0.6675 → 1.614 (+0.9462)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/16838234640000

Fix perf regression from ThrottlingURLLoader changes by cduvall@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1178576/1
1.664 → 0.6938 (-0.97)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/13a30742640000

Fix perf regression from ThrottlingURLLoader changes by cduvall@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/1178576/3
1.664 → 0.6712 (-0.9929)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46fc006bf8bf8a19730b72b57f4868ad31724da7

commit 46fc006bf8bf8a19730b72b57f4868ad31724da7
Author: Clark DuVall <cduvall@chromium.org>
Date: Fri Aug 17 15:49:32 2018

Fix perf regression from ThrottlingURLLoader changes

It looks like some of the changes to ThrottlingURLLoader in
http://crrev.com/c/1157549 caused some perf regressions on mobile. This
fixes the regressions. Something with how StartInfo was created and
passed around before was causing problems.

See bugs for more info. Confirmed regressions fixed with this CL using
pinpoint.

Bug: 874902,  873881 ,  874918 
Change-Id: I34397b8f97cffa82857f87ed19ac6ef5b61a7cac
Reviewed-on: https://chromium-review.googlesource.com/1178576
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584086}
[modify] https://crrev.com/46fc006bf8bf8a19730b72b57f4868ad31724da7/content/common/throttling_url_loader.cc
[modify] https://crrev.com/46fc006bf8bf8a19730b72b57f4868ad31724da7/content/common/throttling_url_loader.h

Status: Fixed (was: Assigned)

Sign in to add a comment