New issue
Advanced search Search tips

Issue 874913 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

User menu items show focus ring on hover

Project Member Reported by maxwalker@chromium.org, Aug 16

Issue description

Chrome Version: 70.0.3524.0 
OS: macOS

What steps will reproduce the problem?
1) Open the user menu
2) Mouse-hover over menu items or navigate menu with the keyboard

What is the expected result?
The hovered/focused item should have a grey background (like list items in the Chrome menu or page info).

What happens instead?
The hovered/focused item has a blue focus ring (and a grey background). The focus ring should not be used when hovering over list items. It should only be used when focusing components like buttons or text fields.
 
Hover Menu.png
278 KB View Download
Cc: ellyjo...@chromium.org
Components: Internals>Views
Owner: lgrey@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06afc98194be0026ace8ff394dbeea498ca7ca01

commit 06afc98194be0026ace8ff394dbeea498ca7ca01
Author: Leonard Grey <lgrey@chromium.org>
Date: Thu Aug 16 18:57:51 2018

Don't install focus rings on hover buttons

Since these focus on hover, we pretty much never want to do this (..right?)

Bug:  874913 
Change-Id: I68c129184e0cf6e5895923696158b10cbefd3adc
Reviewed-on: https://chromium-review.googlesource.com/1177914
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583762}
[modify] https://crrev.com/06afc98194be0026ace8ff394dbeea498ca7ca01/chrome/browser/ui/views/hover_button.cc

Status: Fixed (was: Assigned)
Labels: TE-Verified-70.0.3525.0 TE-Verified-M70
Able to reproduce the issue on chrome version 70.0.3524.0 (build without fix) as per the comment #0.
Verified the fix on Mac 10.13.6 using Chrome version # 70.0.3525.0.
Attaching screen-cast for reference.
Observed that " grey background on User menu items " 
The fix is working as expected, adding Verified labels

Thanks...! 
874913.mp4
1.3 MB View Download

Sign in to add a comment