New issue
Advanced search Search tips

Issue 874868 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 24
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 877173
issue 874222



Sign in to add a comment

Increase maximum value for cache_storage timing histograms

Project Member Reported by wanderview@chromium.org, Aug 16

Issue description

Many of the cache_storage timing histograms are hitting the default 10 second cap at the 95th percentile.  Lets change these to use the LONG_TIME macros so we can measure how bad it really is.

 
Blocking: 877173
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e68ba128cd909c88bb23f0b27a76a9a82f95155

commit 1e68ba128cd909c88bb23f0b27a76a9a82f95155
Author: Ben Kelly <wanderview@chromium.org>
Date: Fri Aug 24 19:39:30 2018

Use UMA_HISTOGRAM_LONG_TIMES() in cache_storage.

Many of the timing histograms in cache_storage have been hitting the
default 10 second cap.  Convert the histograms to use LONG_TIMES to
increase the maximum to 1 hour so that we can see real values.

R=jsbell@chromium.org

Bug:  874868 
Change-Id: Ida097a80aee2f8181a4eb2526d1f55e0aa8da77c
Reviewed-on: https://chromium-review.googlesource.com/1186822
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585943}
[modify] https://crrev.com/1e68ba128cd909c88bb23f0b27a76a9a82f95155/third_party/blink/renderer/modules/cache_storage/cache.cc
[modify] https://crrev.com/1e68ba128cd909c88bb23f0b27a76a9a82f95155/third_party/blink/renderer/modules/cache_storage/cache_storage.cc
[modify] https://crrev.com/1e68ba128cd909c88bb23f0b27a76a9a82f95155/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment