Scripts: git log does not always have svn revision number |
||
Issue descriptionNot sure if this is due to the recent changes in CQ or because some developers submit changes bypassing CQ, but our parsing of revision number is not always working now: e.g. https://chromium-review.googlesource.com/c/chromium/src/+/1169127 $ git log -n 5 commit 8c125d449f30cb622e0f8f4b919ad45b4b05bbb9 Author: Ned Nguyen <nednguyen@google.com> Date: Thu Aug 9 15:07:32 2018 +0000 Add perf/core/bot_platforms.py file that contain metadata about all perf builders Bug:871746,863768 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: If2a9f5344d4226aa56b71dabf094cc49c5006bb8 Reviewed-on: https://chromium-review.googlesource.com/1169127 Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> commit dfc0e36093e5c5818a613dc7782aa15f8c171694 Author: Bence Béky <bnc@chromium.org> Date: Thu Aug 9 14:52:09 2018 +0000 Revert "Use CompletionOnceCallback in //content/browser/appcache." This reverts commit 6b2ace6e0bb70c5c5f6d35f84e62c84207059ac0. Reason for revert: Inadvertently submitted without CQ. New UI is confusing. Change-Id: Ie9b9ca30b5f456cb75ca1813041b6cba9904dd27 Reviewed-on: https://chromium-review.googlesource.com/1169442 Reviewed-by: Bence Béky <bnc@chromium.org> commit 04cc9b724bba95508a992ad5c71e2b475e8f613a Author: Bence Béky <bnc@chromium.org> Date: Thu Aug 9 14:51:15 2018 +0000 Revert "Use OnceCallback for SnapshotFileCallback." This reverts commit 23c8024e5a0d7c6b46f91691cb146ed32badff43. Reason for revert: Inadvertently submitted without CQ. New UI is confusing. Change-Id: I966465c0498944811bc9f7078d1f508306a2ae6f Reviewed-on: https://chromium-review.googlesource.com/1169344 Reviewed-by: Bence Béky <bnc@chromium.org> commit 23c8024e5a0d7c6b46f91691cb146ed32badff43 Author: Bence Béky <bnc@chromium.org> Date: Thu Aug 9 14:49:41 2018 +0000 Use OnceCallback for SnapshotFileCallback. Define SnapshotFileCallback as a OnceCallback<> instead of a Callback<>. While this CL does not directly touch any net::CompletionCallbacks, it is a prerequisite for transitioning to net::CompletionOnceCallbacks in //storage/browser/fileapi. Bug: 807724 Change-Id: I73817841265e7e324f114efd5623e71a755db9a9 Reviewed-on: https://chromium-review.googlesource.com/1165828 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> commit 83ee4594f33d5e84da4e8573238b8ae5420f3565 Author: Miguel Casas <mcasas@chromium.org> Date: Thu Aug 9 14:47:12 2018 +0000 Simplify OffscreenCanvasResourceProvider This CL simplifies OffscreenCanvasResourceProvider: - Removes the unused member variables |width_|, |height_| and |frame_provider_|. - Removes superfluous method Reshape(). - Forward declares a few data types ISO including files. - Uses early return for easier indenting. This is inspired by junov@'s crrev.com/c/1103011 (in the follow up CL crrev.com/c/1167907 I'll fold OffscreenCanvasResourceProvider into CanvasResourceDispatcher, but it's easier to review in two steps). Bug: 839970 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie41059f647a57a85427ce5a8398a73d708503b37 Reviewed-on: https://chromium-review.googlesource.com/1167474 Reviewed-by: Fernando Serboncini <fserb@chromium.org>
,
Aug 16
Deployed the new version and scheduled bot restarts.
,
Aug 16
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/code-coverage/+/9b1be5a40c5b169800b68b28ef7a9fda57c7be47 commit 9b1be5a40c5b169800b68b28ef7a9fda57c7be47 Author: Max Moroz <mmoroz@google.com> Date: Thu Aug 16 20:07:21 2018 |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Aug 16