Add back ability to disallow indirect dependencies |
|||
Issue descriptionOne of the error-prone updates required that we allow all indirect dependencies in java code, i.e. using javac-full-classpath rather than javac-classpath. This promotes loose dependencies in gn, i.e. rather than explicitly depending on new dependencies, just assume they are provided by existing dependencies. This will become more important as we break up more java components out of chrome_java, see issue 846440.
,
Oct 25
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12368f3e465b7935b88ae1ccb57c61f06267dc53 commit 12368f3e465b7935b88ae1ccb57c61f06267dc53 Author: Sam Maier <smaier@chromium.org> Date: Fri Oct 26 19:25:36 2018 Bytecode rewriter validating direct class path This also suppresses issues brought up by the checks that aren't easily fixable. Timing without change on chrome_java: real 0m3.142s user 0m7.278s sys 0m0.563s Timing with change on chrome_java: real 0m3.429s user 0m8.035s sys 0m0.687s TBR=trivial third_party changes Bug: 898251 , 874854 Change-Id: Ifcb10f260e80a542ab26a470bb53426e1404e9f0 Reviewed-on: https://chromium-review.googlesource.com/c/1297233 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#603164} [modify] https://crrev.com/12368f3e465b7935b88ae1ccb57c61f06267dc53/build/android/bytecode/BUILD.gn [modify] https://crrev.com/12368f3e465b7935b88ae1ccb57c61f06267dc53/build/android/bytecode/java/org/chromium/bytecode/ByteCodeProcessor.java [add] https://crrev.com/12368f3e465b7935b88ae1ccb57c61f06267dc53/build/android/bytecode/java/org/chromium/bytecode/ClassPathValidator.java [modify] https://crrev.com/12368f3e465b7935b88ae1ccb57c61f06267dc53/build/android/gyp/bytecode_processor.py [modify] https://crrev.com/12368f3e465b7935b88ae1ccb57c61f06267dc53/build/config/android/internal_rules.gni [modify] https://crrev.com/12368f3e465b7935b88ae1ccb57c61f06267dc53/third_party/accessibility_test_framework/BUILD.gn [modify] https://crrev.com/12368f3e465b7935b88ae1ccb57c61f06267dc53/third_party/espresso/BUILD.gn [modify] https://crrev.com/12368f3e465b7935b88ae1ccb57c61f06267dc53/third_party/google-truth/BUILD.gn [modify] https://crrev.com/12368f3e465b7935b88ae1ccb57c61f06267dc53/third_party/netty4/BUILD.gn [modify] https://crrev.com/12368f3e465b7935b88ae1ccb57c61f06267dc53/tools/android/errorprone_plugin/BUILD.gn
,
Oct 26
This is done with the above change. It might get reverted, but if it does I'll fix it up and merge it back in. Considering this done.
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0301a791b80b0456594e0f0e9108e7a3cf316fe9 commit 0301a791b80b0456594e0f0e9108e7a3cf316fe9 Author: Sam Maier <smaier@chromium.org> Date: Fri Nov 02 22:12:17 2018 Android: turning on bytecode checker This arg was defaulting to false when it should have defaulted to true. TBR=turning off bytecode checks for certain dirs Bug: 874854 Change-Id: I248ccab0ed52079106b07e43a302927bfa4414c8 Reviewed-on: https://chromium-review.googlesource.com/c/1309973 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#605068} [modify] https://crrev.com/0301a791b80b0456594e0f0e9108e7a3cf316fe9/build/config/android/internal_rules.gni [modify] https://crrev.com/0301a791b80b0456594e0f0e9108e7a3cf316fe9/components/data_reduction_proxy/core/common/BUILD.gn [modify] https://crrev.com/0301a791b80b0456594e0f0e9108e7a3cf316fe9/content/public/android/BUILD.gn [modify] https://crrev.com/0301a791b80b0456594e0f0e9108e7a3cf316fe9/third_party/byte_buddy/BUILD.gn
,
Nov 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3b77826c61da068d51f2204ddd2b83f213f244c commit d3b77826c61da068d51f2204ddd2b83f213f244c Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Sat Nov 03 16:24:00 2018 Revert "Android: turning on bytecode checker" This reverts commit 0301a791b80b0456594e0f0e9108e7a3cf316fe9. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 605068 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDMwMWE3OTFiODBiMDQ1NjU5NGUwZjBlOTEwOGU3YTNjZjMxNmZlOQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/8686 Sample Failed Step: single_process_mash_browser_tests Sample Flaky Test: LockScreenNoteTakingTest.DataAvailableOnRestart Original change's description: > Android: turning on bytecode checker > > This arg was defaulting to false when it should have defaulted to true. > > TBR=turning off bytecode checks for certain dirs > > Bug: 874854 > Change-Id: I248ccab0ed52079106b07e43a302927bfa4414c8 > Reviewed-on: https://chromium-review.googlesource.com/c/1309973 > Commit-Queue: Sam Maier <smaier@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605068} Change-Id: I6cbeb762a8de75dde103493010715c5f5ed8074e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874854 , 901616 Reviewed-on: https://chromium-review.googlesource.com/c/1317030 Cr-Commit-Position: refs/heads/master@{#605180} [modify] https://crrev.com/d3b77826c61da068d51f2204ddd2b83f213f244c/build/config/android/internal_rules.gni [modify] https://crrev.com/d3b77826c61da068d51f2204ddd2b83f213f244c/components/data_reduction_proxy/core/common/BUILD.gn [modify] https://crrev.com/d3b77826c61da068d51f2204ddd2b83f213f244c/content/public/android/BUILD.gn [modify] https://crrev.com/d3b77826c61da068d51f2204ddd2b83f213f244c/third_party/byte_buddy/BUILD.gn
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba0225d122580b1bbce3fa8c39ad092bbd158308 commit ba0225d122580b1bbce3fa8c39ad092bbd158308 Author: Sam Maier <smaier@chromium.org> Date: Mon Nov 05 16:03:13 2018 Reland "Android: turning on bytecode checker" This is a reland of 0301a791b80b0456594e0f0e9108e7a3cf316fe9 I don't think this would have caused a runtime chromeos error, since it's a build time android change. If it pops up again that I broke the test, I will investigate further. TBR=retry Original change's description: > Android: turning on bytecode checker > > This arg was defaulting to false when it should have defaulted to true. > > TBR=turning off bytecode checks for certain dirs > > Bug: 874854 > Change-Id: I248ccab0ed52079106b07e43a302927bfa4414c8 > Reviewed-on: https://chromium-review.googlesource.com/c/1309973 > Commit-Queue: Sam Maier <smaier@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605068} Bug: 874854 Change-Id: Idc95750d4465ca53b72db26a98ce74724fe21968 Reviewed-on: https://chromium-review.googlesource.com/c/1318071 Reviewed-by: Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#605347} [modify] https://crrev.com/ba0225d122580b1bbce3fa8c39ad092bbd158308/build/config/android/internal_rules.gni [modify] https://crrev.com/ba0225d122580b1bbce3fa8c39ad092bbd158308/components/data_reduction_proxy/core/common/BUILD.gn [modify] https://crrev.com/ba0225d122580b1bbce3fa8c39ad092bbd158308/content/public/android/BUILD.gn [modify] https://crrev.com/ba0225d122580b1bbce3fa8c39ad092bbd158308/third_party/byte_buddy/BUILD.gn
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb0ce162fb1f37d0d57e136d7f45a9f76689c6e7 commit eb0ce162fb1f37d0d57e136d7f45a9f76689c6e7 Author: John Budorick <jbudorick@chromium.org> Date: Tue Nov 06 03:45:40 2018 Revert "Reland "Android: turning on bytecode checker"" This reverts commit ba0225d122580b1bbce3fa8c39ad092bbd158308. Reason for revert: breaks internal compilation; see e.g. http://shortn/_9928H1Hk0R Original change's description: > Reland "Android: turning on bytecode checker" > > This is a reland of 0301a791b80b0456594e0f0e9108e7a3cf316fe9 > > I don't think this would have caused a runtime chromeos error, since it's > a build time android change. If it pops up again that I broke the test, > I will investigate further. > > TBR=retry > > Original change's description: > > Android: turning on bytecode checker > > > > This arg was defaulting to false when it should have defaulted to true. > > > > TBR=turning off bytecode checks for certain dirs > > > > Bug: 874854 > > Change-Id: I248ccab0ed52079106b07e43a302927bfa4414c8 > > Reviewed-on: https://chromium-review.googlesource.com/c/1309973 > > Commit-Queue: Sam Maier <smaier@chromium.org> > > Reviewed-by: agrieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#605068} > > Bug: 874854 > Change-Id: Idc95750d4465ca53b72db26a98ce74724fe21968 > Reviewed-on: https://chromium-review.googlesource.com/c/1318071 > Reviewed-by: Sam Maier <smaier@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605347} TBR=agrieve@chromium.org,smaier@chromium.org Change-Id: I4bb41ab999431fd2df511838d10db598cd5c0a87 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874854 Reviewed-on: https://chromium-review.googlesource.com/c/1319333 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#605586} [modify] https://crrev.com/eb0ce162fb1f37d0d57e136d7f45a9f76689c6e7/build/config/android/internal_rules.gni [modify] https://crrev.com/eb0ce162fb1f37d0d57e136d7f45a9f76689c6e7/components/data_reduction_proxy/core/common/BUILD.gn [modify] https://crrev.com/eb0ce162fb1f37d0d57e136d7f45a9f76689c6e7/content/public/android/BUILD.gn [modify] https://crrev.com/eb0ce162fb1f37d0d57e136d7f45a9f76689c6e7/third_party/byte_buddy/BUILD.gn
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed886866633bcf132dbf5997271b06124d77b337 commit ed886866633bcf132dbf5997271b06124d77b337 Author: Sam Maier <smaier@chromium.org> Date: Tue Nov 06 22:41:49 2018 Reland "Reland "Android: turning on bytecode checker"" This is a reland of ba0225d122580b1bbce3fa8c39ad092bbd158308 Fixed the build breakage downstream TBR=reland Original change's description: > Reland "Android: turning on bytecode checker" > > This is a reland of 0301a791b80b0456594e0f0e9108e7a3cf316fe9 > > I don't think this would have caused a runtime chromeos error, since it's > a build time android change. If it pops up again that I broke the test, > I will investigate further. > > TBR=retry > > Original change's description: > > Android: turning on bytecode checker > > > > This arg was defaulting to false when it should have defaulted to true. > > > > TBR=turning off bytecode checks for certain dirs > > > > Bug: 874854 > > Change-Id: I248ccab0ed52079106b07e43a302927bfa4414c8 > > Reviewed-on: https://chromium-review.googlesource.com/c/1309973 > > Commit-Queue: Sam Maier <smaier@chromium.org> > > Reviewed-by: agrieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#605068} > > Bug: 874854 > Change-Id: Idc95750d4465ca53b72db26a98ce74724fe21968 > Reviewed-on: https://chromium-review.googlesource.com/c/1318071 > Reviewed-by: Sam Maier <smaier@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605347} Bug: 874854 Change-Id: I7d9cecced393853e9bfe2e6d9f5b184f6c9f1ffc Reviewed-on: https://chromium-review.googlesource.com/c/1320930 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#605858} [modify] https://crrev.com/ed886866633bcf132dbf5997271b06124d77b337/build/config/android/internal_rules.gni [modify] https://crrev.com/ed886866633bcf132dbf5997271b06124d77b337/components/data_reduction_proxy/core/common/BUILD.gn [modify] https://crrev.com/ed886866633bcf132dbf5997271b06124d77b337/content/public/android/BUILD.gn [modify] https://crrev.com/ed886866633bcf132dbf5997271b06124d77b337/third_party/byte_buddy/BUILD.gn |
|||
►
Sign in to add a comment |
|||
Comment 1 by wnwen@chromium.org
, Oct 25