New issue
Advanced search Search tips

Issue 874825 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Dec 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

--disable-gpu-vsync command line regression

Reported by sebastie...@gmail.com, Aug 16

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36

Steps to reproduce the problem:
1. Launch chrome 68 on windows 10 with --disable-gpu-vsync command line
2. open https://threejs.org/examples/#webgl_geometry_colors
3. observe the FPS

What is the expected behavior?
The FPS should not be limited by vsync (60 FPS)

What went wrong?
The FPS is limited by vsync (60 FPS)

Did this work before? Yes Chrome 67

Chrome version: 68.0.3440.106  Channel: stable
OS Version: 10.0
Flash Version: 

This is related to a previous issue :

https://bugs.chromium.org/p/chromium/issues/detail?id=787485
 
Labels: Needs-Triage-M68 Needs-Bisect
Cc: susan.boorgula@chromium.org
Components: Internals>GPU
Labels: -Pri-2 -Needs-Bisect ReleaseBlock-Stable M-68 Target-70 RegressedIn-68 FoundIn-69 FoundIn-68 FoundIn-70 Target-68 Triaged-ET Target-69 hasbisect OS-Linux OS-Mac Pri-1
Owner: sunn...@chromium.org
Status: Assigned (was: Unconfirmed)
sebastien.videcoq@ Thanks for the issue.

Able to reproduce this issue on Windows 10, Mac OS 10.13.3 and Ubuntu 14.04 on the latest Stable 68.0.3440.106 and latest Canary 70.0.3524.0 as per the original comment.

Bisect Information:
===================
Good Build: 68.0.3438.0
Bad Build : 68.0.3439.0

By running the chromium bisect script, below is the changelog URL.

https://chromium.googlesource.com/chromium/src/+log/4fffb41bc1da1bdafadb20c0f90fc7eb615a1a2d..271ca3738e0dd09f784da2b3ef12448515cfb0be

From the above Changelog, suspecting the below change:
Reviewed-on: https://chromium-review.googlesource.com/1069744

sunnyps@ Please check and confirm if this issue is related to your change, else help us in assigning to the right owner.

Adding 'ReleaseBlock-Stable' as this is a recent regression. Please feel free to remove if it is not applicable.

Thanks
Labels: M-69
Friendly ping to get an update as stable release is coming soon and this bug is marked as RBS for M68/M69.
Thanks..!

M69 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Merge has to happen latest by 4:00 PM PT Friday (08/24/18) in order to make it to next week stable cut. Thank you.
As this is regressed in M68, we're not planning to block M69 stable. Pls target fix for M70. Pls let us know ASAP if there is any concern here. Thank you.
This is a command line flag for testing and debugging. It is never shipped to users in any configuration. So any regression here cannot be a release blocker.
Labels: -ReleaseBlock-Stable M-70
Removing "ReleaseBlock-Stable" label per comment #7.
Labels: Needs-Feedback
This is not a bug. The behavior of --disable-gpu-vsync flag was changed:

"Split --disable-gpu-vsync command line switch

Introduce new --disable-frame-rate-limit switch that disables begin
frame limiting and synchronization of presentation with vblank.

After this change --disable-gpu-vsync only controls synchronization of
presentation with vblank which allows using this mode independently of
frame rate limiting e.g. for minimizing latency.

Follow up CL will enable variable refresh rate support on Windows with
--disable-gpu-vsync."

Please let me know if this flag is commonly used by web developers for testing. I'll consider reverting the behavior change.

Comment 10 Deleted

Not sure i understood all the details, but i've added the new command line switch to our scripts. I will have the result tomorrow.

We use this command line internally in our performance release to track FPS regression /progression in our WebGL rendering engine.

Our performance tests results are back to normal. For me you can close.

Thanks.
Status: WontFix (was: Assigned)
Closing per #12

Sign in to add a comment