New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 874820 link

Starred by 1 user
Status: Fixed
Owner:
█ sweilun@chromium.org
Last visit 18 days ago
Closed: Aug 23
Cc:
pnangunoori@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: 'Select a collection' overlay closes after dragging mouse cursor within the overlay

Reported by khushal....@etouch.net, Aug 16 
Chrome Version: 69.0.3497.42 (Official Build) Revision 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655} (32/64-bit)
OS: Mac (10.12.6, 10.13.1, 10.13.6, 10.14), Win (7, 8, 8.1, 10) & Linux (14.04 LTS)

Pre-condition: Enable the flag 'Enable using the Google local NTP' and 'New Tab Page Background Selection' from chrome://flags/

What steps will reproduce the problem?
(1) Launch chrome, open NTP and click on gear icon then select 'Choose background' option ('Select a collection' overlay will open).
(2) Now drag the mouse cursor from 'Select a collection' titlebar and release within the overlay and Observe.

Actual Result: 'Select a collection' overlay closes after dragging mouse cursor within the overlay.

Expected Result: 'Select a collection' overlay should not close after dragging mouse cursor within the overlay.

This is a Regression issue seen from 'M-69' and providing the bisect info below:
Good Build: 69.0.3469.2 (Revision: 569383)
Bad Build:  69.0.3472.0 (Revision: 569948)

You are probably looking for a change made after 569864 (known good), but no later than 569865 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/85b6c71b8c485f38fbc33a50bf2a3377a689a08a..6df75860ef51a541632f1a8557fbfa996b2d5bda

Suspect: https://chromium.googlesource.com/chromium/src/+/6df75860ef51a541632f1a8557fbfa996b2d5bda

@kmilka: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: Issue is also seen on M-70 Dev (build #70.0.3521.2) & M-70 Canary (build #70.0.3524.0).

Kindly refer the attached screen-cast.

Thank You..!!
Actual Video.mov
7.6 MB View Download
Expected Video.mov
6.8 MB View Download

Comment 1 by ramyan@chromium.org, Aug 16

Labels: -Pri-1 -Target-69 Pri-3
Owner: sweilun@chromium.org
Lowering the priority as mouse-drag isn't too common.

Also observed that this doesn't appear to happen when the mouse-drag occurs entirely within the grid area.

Comment 2 by sweilun@chromium.org, Aug 16

Status: Started (was: Assigned)
For this problem, if you try click the collection tile, hold that, drag anywhere, and unhold the mouse within the same collection tile area. It will be detected as click that tile. It might be possible if we use onmouseup or onmousedown event. wdyt?

Comment 3 by twelling...@chromium.org, Aug 21

Labels: zine-triaged

Comment 4 by bklmn@chromium.org, Aug 22 

Adding in a summary from a convo with ramyan@ related to this bug. 

These dialog dismissal UX patterns are varied from our web UI and secondary UI's. Ramya and I agreed our main goal is to make this dialog behave the same way as our edit link dialog...which is how our WebUI dialogs work.

Added bonus: there is a nice interaction detail where the dialog "pulses" when clicking outside to bring back attention (capture attached). Ideally we can match this.
dialog.gif
228 KB View Download

Comment 5 by ramyan@chromium.org, Aug 22 

Thanks for the additional detail Joel. Should there be any change to the color of the overlay applied to the background? The color in the gif in comment #4 looks a lot darker than what we apply now.

Weilun - as we discussed, let's make the background dialog uniform with add/edit custom link, which *should* also fix the regression described by this bug.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab53b6355b4710dadcc97b3b86173e8657fb7978

commit ab53b6355b4710dadcc97b3b86173e8657fb7978
Author: Weilun Shi <sweilun@chromium.org>
Date: Thu Aug 23 02:18:43 2018

[NTP] Not close custom background dialog when clicking outside

Prevent closing the custom background dialog when clicking outside to
stay consistent with the custom link edit dialog. Also fix  bug 874820 .
When dragging mouse cursor within the overlay, now the dialog will not
close.

Bug:  874820 
Change-Id: I4f78da252df73a664a7c31099e7e311a6c7856ed
Reviewed-on: https://chromium-review.googlesource.com/1185799
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585369}
[modify] https://crrev.com/ab53b6355b4710dadcc97b3b86173e8657fb7978/chrome/browser/resources/local_ntp/custom_backgrounds.js

Comment 7 by sweilun@chromium.org, Aug 23

Status: Fixed (was: Started)

Comment 8 by ramyan@chromium.org, Aug 23

Labels: AddToRemoteNTP

Comment 9 by khushal....@etouch.net, Aug 24

Labels: TE-Verified-M70 TE-Verified-70.0.3532.0
Update:

Rechecked the above issue on Win (7, 8, 8.1, 10), Mac (10.12.6, 10.13.1, 10.13.6, 10.14) & Linux (14.04 LTS) using latest canary version 70.0.3532.0 and the issue is found FIXED. Hence, adding the respective labels.

Please refer the attached screen-cast.

Thank You..!!
874820_Fixed.mov
8.4 MB View Download

Comment 10 by kristip...@chromium.org, Nov 15

Labels: -AddToRemoteNTP SupportedInRemoteNTP
►

Sign in to add a comment