Non-Regression : 'App info' Overlay edges is not proper |
|||||||||||||
Issue descriptionChrome Version: 70.0.3519.3/10973.0.0 dev-channel Kip,Celes and Daisy OS: Chrome What steps will reproduce the problem? (1)Sign into User ->Open browser and go to New Tab -> Now Open App launcher -> click on 'All Apps' (2)Select any App -> right click for context Menu and select 'App info' option (3)'App info' Overlay is seen -> now observe Overlay edges i.e.unable to distinguish between browser and overlay (Please refer Video and Screenshot) Expected: 'App info' Overlay edges is not proper i.e. Unable to distinguish between browser and Overlay edges Actual: Instead Unable to distinguish between browser and 'App info' Overlay edges This is Non-Regression Issue seen from M-62
,
Aug 16
This seems like a good candidate to punt to >M-70 IMO.
,
Sep 26
Mass punting to M-71.
,
Sep 27
,
Oct 8
,
Oct 15
This dialog should use the Chrome OS MD shadow shown in "Expected_Edge1.jpg" which is 24dp elevation.
,
Oct 15
Bulk moving all M-71 <P-1's to M-72.
,
Oct 15
,
Dec 3
Bulk moving <p-1's to the next milestone because we branched to M-73.
,
Dec 12
,
Dec 13
Issue 826524 has been merged into this issue.
,
Dec 13
I think this is ready to be assigned for implementation.
,
Dec 20
,
Jan 7
I can take this one.
,
Jan 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b3d3bc3ee6e9b6e3bfb808ccc814db08af38922 commit 2b3d3bc3ee6e9b6e3bfb808ccc814db08af38922 Author: Weidong Guo <weidongg@chromium.org> Date: Tue Jan 08 05:54:33 2019 Fix app info dialog elevation issue Changes: Enable 24dp elevation of the app info dialog to make it more visible against light background. Bug: 874816 Change-Id: Iaef61fc058a4495c021d85de1a57cadf279e0139 Reviewed-on: https://chromium-review.googlesource.com/c/1395868 Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#620636} [modify] https://crrev.com/2b3d3bc3ee6e9b6e3bfb808ccc814db08af38922/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc
,
Jan 8
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by weidongg@chromium.org
, Aug 16