blink_perf.image_decoder/decode-lossy-webp.html and 3 other(s) in performance_test_suite failing on multiple builders |
||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of nednguyen@chromium.org blink_perf.image_decoder/decode-lossy-webp.html and 3 other(s) in performance_test_suite failing on multiple builders Builders failed on: - Win 7 Perf: https://ci.chromium.org/buildbot/chromium.perf/Win%207%20Perf - win-10-perf: https://ci.chromium.org/buildbot/chromium.perf/win-10-perf This just happens recently, I will kick off bisect https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=performance_test_suite&tests=blink_perf.image_decoder%2Fdecode-lossy-webp.html
,
Aug 16
๐ Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/148692ea640000
,
Aug 16
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14d6f742640000
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6090d22674ffa58c65f9e3163a9345fd2dd74352 commit 6090d22674ffa58c65f9e3163a9345fd2dd74352 Author: Annie Sullivan <sullivan@chromium.org> Date: Thu Aug 16 15:23:37 2018 Disabling failing blink_perf.image_decoder stories on Win. Bug: 874810 Change-Id: I11ff44a55b4f2b14b8ba0a4ab5bb4e0f54cd8ef8 TBR: nednguyen@google.com NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1177882 Reviewed-by: Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#583658} [modify] https://crrev.com/6090d22674ffa58c65f9e3163a9345fd2dd74352/tools/perf/expectations.config
,
Aug 16
๐ Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14d6f742640000 Hold pre-decoded images until use or 250ms rather than 2 frames by ericrk@chromium.org https://chromium.googlesource.com/chromium/src/+/520ce5d7136360877309b68ab8b43a7d13c84d82 0 โ 0.8 (+0.8) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bba9dc79de2bd15006cc9f42ebe98f128c8d1d91 commit bba9dc79de2bd15006cc9f42ebe98f128c8d1d91 Author: Ned Nguyen <nednguyen@google.com> Date: Thu Aug 16 20:40:00 2018 Revert "Disabling failing blink_perf.image_decoder stories on Win." This reverts commit 6090d22674ffa58c65f9e3163a9345fd2dd74352. Reason for revert: culprit CL is being reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1178841 Original change's description: > Disabling failing blink_perf.image_decoder stories on Win. > > Bug: 874810 > Change-Id: I11ff44a55b4f2b14b8ba0a4ab5bb4e0f54cd8ef8 > TBR: nednguyen@google.com > NOTRY: true > Reviewed-on: https://chromium-review.googlesource.com/1177882 > Reviewed-by: Annie Sullivan <sullivan@chromium.org> > Commit-Queue: Annie Sullivan <sullivan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583658} TBR=sullivan@chromium.org Change-Id: Ia80a8b6809d909fff687bd12cace06fe447eb141 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874810 Reviewed-on: https://chromium-review.googlesource.com/1178861 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#583798} [modify] https://crrev.com/bba9dc79de2bd15006cc9f42ebe98f128c8d1d91/tools/perf/expectations.config
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37d7392b2648e52d2271e49d4aefc5633e391075 commit 37d7392b2648e52d2271e49d4aefc5633e391075 Author: Ned Nguyen <nednguyen@google.com> Date: Thu Aug 16 22:25:01 2018 Revert "Hold pre-decoded images until use or 250ms rather than 2 frames" This reverts commit 520ce5d7136360877309b68ab8b43a7d13c84d82. Reason for revert: breaking blink_perf.image_decoder/* tests BUG:chromium:874810 Original change's description: > Hold pre-decoded images until use or 250ms rather than 2 frames > > We currently unlock pre-decoded images after 2 frames of any type. This > doesn't always give callers a chance to use their images (if main thread > is a bit backed up). Instead we should wait for the caller to actually > use the image. Additionally, we drop images after 250ms to prevent > excessive growth if a user fails to use images in a timely manner. > > See the linked bug for example traces which show the benefits. > > R=โkhushalsagar > > Bug: 869491 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Icd94709aad5c076b1ba295495eaab24dc893ebdb > Reviewed-on: https://chromium-review.googlesource.com/1159203 > Commit-Queue: Eric Karl <ericrk@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583171} TBR=khushalsagar@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869491 Change-Id: Ia80ab26563bf1ccc0556d5638a483337acee972d Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1178841 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#583855} [modify] https://crrev.com/37d7392b2648e52d2271e49d4aefc5633e391075/cc/tiles/decoded_image_tracker.cc [modify] https://crrev.com/37d7392b2648e52d2271e49d4aefc5633e391075/cc/tiles/decoded_image_tracker.h [modify] https://crrev.com/37d7392b2648e52d2271e49d4aefc5633e391075/cc/tiles/decoded_image_tracker_unittest.cc [modify] https://crrev.com/37d7392b2648e52d2271e49d4aefc5633e391075/cc/tiles/tile_manager.cc [modify] https://crrev.com/37d7392b2648e52d2271e49d4aefc5633e391075/cc/tiles/tile_manager_unittest.cc [modify] https://crrev.com/37d7392b2648e52d2271e49d4aefc5633e391075/cc/trees/layer_tree_host_impl.cc
,
Aug 27
Issue 874878 has been merged into this issue. |
||
►
Sign in to add a comment |
||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Aug 16