New issue
Advanced search Search tips

Issue 874809 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

DCHECK failure in address % access_size == 0 in simulator-arm64.cc

Project Member Reported by ClusterFuzz, Aug 16

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5889010556469248

Fuzzer: binaryen_wasm_fuzzer
Job Type: linux_asan_d8_v8_arm64_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  address % access_size == 0 in simulator-arm64.cc
  v8::internal::Simulator::VisitLoadStoreAcquireRelease
  v8::internal::Simulator::ExecuteInstruction
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_v8_arm64_dbg&range=48251:48252

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5889010556469248

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 16

Labels: Test-Predator-Auto-Owner
Owner: gdeepti@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/b380525b3b5f6b07b7d419a69f328ebf59b9b800 ([wasm] Implement I32AtomicLoad, I32AtomicStore ops).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 16

Labels: Pri-1
Labels: M-68 Security_Impact-Stable
Components: -Blink>JavaScript Blink>JavaScript>WebAssembly
Labels: -Security_Impact-Stable
This does not impact stable, the executed op is behind a flag in d8 (--experimental-wasm-threads). Editing labels accordingly. 
Labels: Security_Impact-None
Labels: Merge-Request-70
Status: Fixed (was: Assigned)
Project Member

Comment 8 by ClusterFuzz, Sep 6

ClusterFuzz has detected this issue as fixed in range 55665:55666.

Detailed report: https://clusterfuzz.com/testcase?key=5889010556469248

Fuzzer: binaryen_wasm_fuzzer
Job Type: linux_asan_d8_v8_arm64_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  address % access_size == 0 in simulator-arm64.cc
  v8::internal::Simulator::VisitLoadStoreAcquireRelease
  v8::internal::Simulator::ExecuteInstruction
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_v8_arm64_dbg&range=48251:48252
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_v8_arm64_dbg&range=55665:55666

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5889010556469248

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Sep 6

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5889010556469248 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Sep 6

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 11 by sheriffbot@chromium.org, Sep 7

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 10

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Sep 14

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 14

Labels: merge-merged-7.0
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0b769a29ff14764d05d8d9fb12a501d3eb18b078

commit 0b769a29ff14764d05d8d9fb12a501d3eb18b078
Author: Deepti Gandluri <gdeepti@chromium.org>
Date: Fri Sep 14 17:13:12 2018

Merged:[wasm] Add runtime checks for misaligned atomic accesses

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

BUG:  v8:6532 ,  chromium:874809 
Change-Id: I55c00e8563741908cf0daf263152ce927ae18e7c
Reviewed-on: https://chromium-review.googlesource.com/1205812
Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
Reviewed-by: Ben Smith <binji@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#55666}(cherry picked from commit 2fcf6da494550c0a3c3ec2173bfc6f73c9ab635b)
Reviewed-on: https://chromium-review.googlesource.com/1226412
Cr-Commit-Position: refs/branch-heads/7.0@{#25}
Cr-Branched-From: 6e2adae6f7f8e891cfd01f3280482b20590427a6-refs/heads/7.0.276@{#1}
Cr-Branched-From: bc08a8624cbbea7a2d30071472bc73ad9544eadf-refs/heads/master@{#55424}
[modify] https://crrev.com/0b769a29ff14764d05d8d9fb12a501d3eb18b078/src/builtins/builtins-definitions.h
[modify] https://crrev.com/0b769a29ff14764d05d8d9fb12a501d3eb18b078/src/compiler/wasm-compiler.cc
[modify] https://crrev.com/0b769a29ff14764d05d8d9fb12a501d3eb18b078/src/compiler/wasm-compiler.h
[modify] https://crrev.com/0b769a29ff14764d05d8d9fb12a501d3eb18b078/src/globals.h
[modify] https://crrev.com/0b769a29ff14764d05d8d9fb12a501d3eb18b078/src/messages.h
[modify] https://crrev.com/0b769a29ff14764d05d8d9fb12a501d3eb18b078/test/mjsunit/wasm/atomics.js
[modify] https://crrev.com/0b769a29ff14764d05d8d9fb12a501d3eb18b078/test/mjsunit/wasm/wasm-constants.js

Labels: -Type-Bug-Security -reward-topanel -Security_Impact-None -Security_Severity-High reward-0 Type-Bug
I'm afraid the VRP panel declined to reward, as this issue affected the simulator. (Additionally, we are confident that we would have fixed this before the feature came out from behind a flag), but thanks for the report nevertheless!
Labels: -Merge-Approved-70
Project Member

Comment 17 by sheriffbot@chromium.org, Dec 13

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment