New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 874787 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 882742



Sign in to add a comment

CRAS: AEC tuning on Chrome OS device

Project Member Reported by hychao@chromium.org, Aug 16

Issue description

The work of integrating WebRTC APM to CRAS is done per  issue 710465 . 

This bug tracks the additional changes for actually tune the system side APM for a Chrome OS product.

According to offline discussion with peah@ and leonardokusumo@, we still need below works:

- sync CrOS side webrtc-apm package to M69 branch in upstream.
- Expose pre-amplifier, AGC, NS functions to CRAS.
- Let CRAS use echo reference PCM provided by driver.
- Figure out if we need to change webrtc APM code.

I will post CLs for some of above later. Note that these CLs will stay in work-in-progress state while we integrate them and tune on real Chrome OS device.

Once we verify the tuning and finalize all necessary changes, I will request code review and land them in M70.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/webrtc-apm/+/edc34c8fceda40d7258e5b0699741723736d0be4

commit edc34c8fceda40d7258e5b0699741723736d0be4
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Fri Aug 24 06:27:47 2018

Sync to webrtc branch-heads/69

https://webrtc.googlesource.com/src/+log/branch-heads/69

BUG= chromium:874787 
TEST=emerge-eve webrtc-apm

Change-Id: If0f58568f15f0f419356474f631f6fcea1f3a0d2
Reviewed-on: https://chromium-review.googlesource.com/1174084
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/acm2/rent_a_codec.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/httpcommon_unittest.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Europe/Prague
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Africa/Khartoum
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/America/Indiana/Marengo
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Pacific/Auckland
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Pacific/Palau
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/aec3/matched_filter.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/neteq/tools/rtp_generator.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Zulu
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/America/Argentina/La_Rioja
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/debugging/leak_check_disable.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Asia/Yangon
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/rtcp_packet/psfb.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/experiments/congestion_controller_experiment.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/criticalsection_unittest.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/America/Inuvik
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/include/audio_coding_module.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/memory/CMakeLists.txt
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Brazil/DeNoronha
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/rtcp_packet/remb.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/format_benchmark.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/vad/vad_audio_proc_internal.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/thread_checker_impl.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/ilbc/ilbc.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/ilbc/cb_update_best_index.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/include/cctz/civil_time.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/iso3166.tab
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Africa/Douala
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/rtcp_packet/target_bitrate_unittest.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/src/zone_info_source.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/rtp_format.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/ratetracker.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/ilbc/chebyshev.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/pathutils_unittest.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/strings/internal/str_join_internal.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/thread.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/isac/fix/source/codec.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/base/CMakeLists.txt
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/rtcp_packet/pli.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/byteorder_unittest.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/aec3/moving_average.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/rtp_header_extension_map.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/Makefile
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/acm2/acm_receiver.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/agc2/rnn_vad/fft_util.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/base/BUILD.bazel
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/aec_dump/aec_dump_integration_test.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/api/array_view_unittest.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/agc2/rnn_vad/pitch_search_internal.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/synchronization/internal/mutex_nonprod.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/aec3/render_delay_controller.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/aec3/residual_echo_estimator_unittest.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/checks.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/America/Argentina/San_Juan
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/isac/main/source/isac_vad.c
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/base/internal/raw_logging.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/synchronization/blocking_counter_test.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/api/transport/network_types.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/base/inline_variable_test_b.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/base/internal/low_level_scheduling.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Canada/Pacific
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/synchronization/internal/graphcycles.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/aec3/block_processor.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/strings/str_split.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/America/Rankin_Inlet
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/rtp_receiver_video.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/isac/main/source/filterbanks.c
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/neteq/tools/input_audio_file.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Pacific/Marquesas
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/types/bad_any_cast.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Europe/Uzhgorod
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Indian/Reunion
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/third_party/rnnoise/src/kiss_fft.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Pacific/Tongatapu
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/ulpfec_generator.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/echo_detector/circular_buffer.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Africa/Tunis
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/neteq/neteq_decoder_enum.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/GMT0
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Europe/Mariehamn
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/ipaddress_unittest.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/aec/aec_core_neon.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/echo_detector/circular_buffer.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/rtcp_packet/rapid_resync_request_unittest.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/ilbc/smooth.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/common_audio/resampler/resampler_unittest.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/neteq/neteq_stereo_unittest.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/ilbc/energy_inverse.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/api/units/timestamp_unittest.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/types/any_exception_safety_test.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/types/variant_benchmark.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/aec3/echo_path_delay_estimator.cc
[delete] https://crrev.com/ede78de16649a8675020bd305049f88b43680df0/modules/audio_processing/beamformer/covariance_matrix_generator.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/copyonwritebuffer.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/aec3/render_signal_analyzer_unittest.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Asia/Qatar
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/packet_loss_stats_unittest.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/numeric/int128.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/neteq/delay_manager.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/synchronization/barrier_test.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/json.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/rtcp_packet/tmmbr.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/ilbc/split_vq.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/isac/fix/source/arith_routins.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/time_util_unittest.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/platform_thread_unittest.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/firewallsocketserver.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Australia/ACT
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/America/North_Dakota/New_Salem
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/base/casts.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/America/Edmonton
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/receive_statistics_impl.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/experiments/field_trial_units_unittest.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/ssladapter_unittest.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/debugging/internal/examine_stack.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Atlantic/Faeroe
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/neteq/neteq_network_stats_unittest.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/debugging/internal/demangle.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/aec_dump/BUILD.gn
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Arctic/Longyearbyen
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/src/time_zone_lookup.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/common_audio/wav_header.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Europe/Zagreb
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Europe/Paris
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/packet_loss_stats.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/neteq/tools/neteq_packet_source_input.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/America/Martinique
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/container/fixed_array_benchmark.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/checks.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Australia/Yancowinna
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/MET
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Europe/Skopje
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/aec3/echo_remover.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Pacific/Midway
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/legacy_encoded_audio_frame.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/base/module.mk
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/rtcp_packet/compound_packet_unittest.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Pacific/Wallis
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/types/any.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/strings/internal/charconv_bigint.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/ilbc/interpolate_samples.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/common_audio/signal_processing/include/spl_inl.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/common_audio/mocks/mock_smoothing_filter.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/neteq/time_stretch.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/America/Anchorage
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/base/internal/low_level_alloc_test.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Asia/Shanghai
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/api/video/video_frame.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/helpers.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/function_view_unittest.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/opensslstreamadapter.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Europe/Nicosia
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/include/gain_control.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/ilbc/state_construct.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/api/video/video_source_interface.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/neteq/packet_buffer.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/isac/fix/source/lpc_tables.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/common_audio/audio_converter.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/rtcp_packet/fir.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/neteq/random_vector.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Asia/Magadan
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/aec3/filter_analyzer.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/debugging/CMakeLists.txt
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/fileutils.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/isac/fix/source/bandwidth_estimator.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/api/video/video_timing.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/synchronization/mutex_benchmark.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/rtcp_packet/common_header_unittest.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Pacific/Apia
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/rtp_packet_unittest.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/agc2/biquad_filter_unittest.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/thread_checker.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/US/Michigan
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/neteq/post_decode_vad.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/aec3/suppression_gain_unittest.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Etc/Universal
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/America/Cayman
[delete] https://crrev.com/ede78de16649a8675020bd305049f88b43680df0/modules/audio_coding/codecs/isac/main/source/filterbank_tables.c
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/rtc_base/experiments/field_trial_units.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Hongkong
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/agc2/vad_with_level.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/numeric/int128_stream_test.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/isac/fix/source/settings.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/residual_echo_detector_unittest.cc
[delete] https://crrev.com/ede78de16649a8675020bd305049f88b43680df0/modules/audio_coding/codecs/isac/main/source/filterbank_tables.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/debugging/internal/vdso_support.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/debugging/internal/stacktrace_unimplemented-inl.inc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/agc2/biquad_filter.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/common_audio/vad/vad_unittest.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/audio/audio_transport_impl.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/common_audio/BUILD.gn
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/transient/wpd_node_unittest.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Australia/Sydney
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/neteq/tools/neteq_test.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/third_party/rnnoise/src/rnn_vad_weights.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/ilbc/audio_decoder_ilbc.cc
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/Australia/Brisbane
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/rtcp_nack_stats.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/isac/fix/source/structs.h
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/neteq/mock/mock_decoder_database.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/time/internal/cctz/testdata/zoneinfo/US/Pacific
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/absl/strings/internal/str_format/convert_test.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/codecs/g722/g722_enc_dec.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/rtp_rtcp/source/rtp_generic_frame_descriptor_extension_unittest.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/neteq/tools/neteq_packet_source_input.h
[add] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/aec3/mock/mock_echo_remover.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_processing/agc2/rnn_vad/rnn_vad_tool.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/system_wrappers/source/metrics_default.cc
[modify] https://crrev.com/edc34c8fceda40d7258e5b0699741723736d0be4/modules/audio_coding/c
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/1c8be7cdce59379dca20ac46106a0a40dd3f7547

commit 1c8be7cdce59379dca20ac46106a0a40dd3f7547
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Fri Aug 24 06:27:48 2018

CRAS: aec_config - sync to webrtc-apm m69 branch

BUG= chromium:874787 
TEST=emerge adhd with webrtc-apm sync to m69
CQ-DEPEND=CL:1174084

Change-Id: I1137003ad2e46074a22f3c5f7601fe5f18804277
Reviewed-on: https://chromium-review.googlesource.com/1180784
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/1c8be7cdce59379dca20ac46106a0a40dd3f7547/cras/src/server/config/aec_config.h
[modify] https://crrev.com/1c8be7cdce59379dca20ac46106a0a40dd3f7547/cras/src/server/config/aec_config.c

Cc: cindyb@chromium.org
Labels: Merge-Request-69
We need the CLs from #2 and #3 merge to M69, for CFM testing.

Rest of the tuning changes will go to M70.
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 29

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: We are only 5 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/205aff6cd98f5a33caf24cd450f2d4ecf1b950e5

commit 205aff6cd98f5a33caf24cd450f2d4ecf1b950e5
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Fri Aug 31 12:23:08 2018

CRAS: config - Add apm_config

apm_config includes parameters not for AEC but useful
for tuning APM performance in CRAS.

BUG= chromium:874787 
TEST=apply all config files and test on nocturne
CQ-DEPEND=CL:1174085

Change-Id: I7d3e42fdde41ef721303ac063236c79eb7b23156
Reviewed-on: https://chromium-review.googlesource.com/1180785
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/205aff6cd98f5a33caf24cd450f2d4ecf1b950e5/cras/src/server/cras_apm_list.c
[modify] https://crrev.com/205aff6cd98f5a33caf24cd450f2d4ecf1b950e5/cras/src/tests/apm_list_unittest.cc
[modify] https://crrev.com/205aff6cd98f5a33caf24cd450f2d4ecf1b950e5/cras/src/Makefile.am
[add] https://crrev.com/205aff6cd98f5a33caf24cd450f2d4ecf1b950e5/cras/src/server/config/apm_config.h
[add] https://crrev.com/205aff6cd98f5a33caf24cd450f2d4ecf1b950e5/cras/src/server/config/apm_config.c

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/webrtc-apm/+/7874576bed69e203d9a87409ac1d9a87d3842164

commit 7874576bed69e203d9a87409ac1d9a87d3842164
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Fri Aug 31 12:23:07 2018

Expose apm_config

Expose parameters of webrtc::AudioProcessing::Config to
be configured by CRAS.
New parmeters includes configuring pre-amp gain, NS, AGC/AGC2,
which are not in aec3 config.

BUG= chromium:874787 
TEST=apply all config files and test on nocturne

Change-Id: Ib34a01598610f88ebf82e33f9d797c29627531ea
Reviewed-on: https://chromium-review.googlesource.com/1174085
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/7874576bed69e203d9a87409ac1d9a87d3842164/webrtc_apm.h
[modify] https://crrev.com/7874576bed69e203d9a87409ac1d9a87d3842164/webrtc_apm.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/webrtc-apm/+/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9

commit edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9
Author: Hsin-Yu Chao <hychao@google.com>
Date: Fri Aug 31 22:08:42 2018

Sync to webrtc ToT

Update to commit "AEC3: Parametrize the shadow filter output usage".

https://webrtc.googlesource.com/src/+/240215431ee21e85e415484d1d80f437850f2f8e

This update includes all parameters and codes for tuning
APM performance with CRAS.

BUG= chromium:874787 
TEST=Apply all config files and test on nocturne
CQ-DEPEND=CL:1196304

Change-Id: Idf6da0c70ac1569d2567c2ab15f436731edb3f35
Reviewed-on: https://chromium-review.googlesource.com/1194561
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/acm2/rent_a_codec.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec3/aec_state.cc
[rename] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/third_party/base64/base64.cc
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/video/video_stream_encoder_observer.cc
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/third_party/base64/module.mk
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec3/matched_filter.h
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/third_party/g711/LICENSE
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/debugging/failure_signal_handler.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/random.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/sigslotrepeater.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/gain_controller2.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/preemptive_expand.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/audio_decoder_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/gain_control_for_experimental_agc.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/source/rtp_packet.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/container/fixed_array.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/include/audio_coding_module.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/tools/audio_sink.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/synchronization/mutex_test.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/meta/type_traits.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/source/rtp_sender.cc
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec3/reverb_frequency_response.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/source/rtp_format_vp8.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/strings/escaping.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/system_wrappers/source/cpu_features_linux.c
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/codecs/ilbc/ilbc.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/codecs/isac/main/source/encode_lpc_swb.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec3/filter_analyzer.h
[rename] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/common_audio/third_party/fft4g/fft4g.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/source/rtp_format.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec3/fft_data_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/strings/BUILD.bazel
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/units/timestamp.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/utility/delay_estimator.h
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/third_party/fft/README.chromium
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/third_party/portaudio/pa_ringbuffer.c
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/common_audio/third_party/spl_sqrt_floor/README.chromium
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/base/internal/exception_testing.h
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/third_party/portaudio/pa_ringbuffer.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/sigslottester.h.pump
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/base/CMakeLists.txt
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec3/BUILD.gn
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/tools/packet_source.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/OWNERS
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/units/data_rate_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/source/rtp_receiver_impl.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/include/rtp_rtcp_defines.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/time/clock.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/common_audio/vad/vad_core_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/strings/str_format_test.cc
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/third_party/module.mk
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/include/audio_processing.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/audio_network_adaptor/parse_ana_dump.py
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/source/fec_private_tables_random.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/codecs/tools/audio_codec_speed_test.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/acm2/acm_receiver.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/base/BUILD.bazel
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/vad/gmm.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/include/rtp_header_parser.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec3/vector_math.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec_dump/aec_dump_integration_test.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/transient/file_utils.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/tools/neteq_rtpplay.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/agc2/adaptive_agc.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/tools/encode_neteq_input.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/utility/ooura_fft_sse2.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/codecs/pcm16b/pcm16b.h
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/third_party/base64/LICENSE
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/tools/neteq_input.h
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/third_party/module.mk
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/timeutils.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/base/internal/raw_logging.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/random_vector.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/transport/network_types.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/codecs/ilbc/cb_construct.h
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/video/video_stream_encoder_create.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/tools/neteq_delay_analyzer.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/source/rtp_generic_frame_descriptor.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/source/rtp_receiver_video.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/codecs/isac/main/source/lpc_shape_swb12_tables.h
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/message_buffer_reader.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/jsepicecandidate.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/codecs/isac/main/source/lpc_shape_swb12_tables.c
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/agc2/interpolated_gain_curve_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/audio_multi_vector_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/base/internal/raw_logging.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/agc2/gain_curve_applier.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/network.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/criticalsection.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/codecs/ilbc/vq4.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/criticalsection.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/rtpreceiverinterface.cc
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/time/internal/get_current_time_chrono.inc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/source/rtp_receiver_strategy.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/codecs/ilbc/get_cd_vec.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/statstypes.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec3/adaptive_fir_filter.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/audio_options.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/stream.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/vad/pole_zero_filter.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/utility/delay_estimator_wrapper.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/codecs/isac/main/source/structs.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/utility/delay_estimator_internal.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/time_stretch.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/source/rtp_header_extension_map_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/units/timestamp_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/codecs/ilbc/constants.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/copyonwritebuffer.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/copts.bzl
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/codecs/isac/fix/source/filterbank_internal.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/container/BUILD.gn
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/packet_buffer.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/meta/type_traits_test.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/common_audio/include/audio_util.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/common_audio/vad/vad_unittest.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/agc2/fixed_gain_controller.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/codecs/isac/main/source/pitch_lag_tables.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/synchronization/rw_lock_posix.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec/aec_core.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/common_audio/signal_processing/complex_fft.c
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec3/block_delay_buffer_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec3/echo_canceller3.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/timestamp_scaler.h
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/third_party/fft/LICENSE
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/units/time_delta.h
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/experiments/rtt_mult_experiment.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/common_audio/vad/vad_sp.c
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/audio/channel.h
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/third_party/portaudio/BUILD.gn
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/rtpparameters.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/source/rtp_format_vp8_test_helper.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/agc2/adaptive_agc.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/agc2/adaptive_digital_gain_applier.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/audio/audio_send_stream_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/source/receive_statistics_impl.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/sslcertificate.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/audio/channel_proxy.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec3/filter_analyzer.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/rtpsenderinterface.h
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/container/internal/compressed_tuple_test.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/experiments/BUILD.gn
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/audio_processing_impl.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/common_audio/signal_processing/resample_by_2_internal.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/audio_vector.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/tools/rtp_jitter.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/audio_processing_performance_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/units/data_size.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/units/timestamp.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/common_audio/vad/include/vad.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/memory/aligned_malloc.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/synchronization/mutex.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/common_audio/signal_processing/complex_fft_tables.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/utility/ooura_fft.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/transient/moving_moments.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/base64_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec3/echo_remover.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/audio_vector_unittest.cc
[rename] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/third_party/g722/g722_enc_dec.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/rtpreceiverinterface.h
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/video/video_bitrate_allocator.h
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/datachannelinterface.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/algorithm/container.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/network.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec3/reverb_model_estimator.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/audio_processing_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/include/rtp_payload_registry.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/helpers.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/container/inlined_vector_test.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/packet.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/codecs/opus/opus_fec_test.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/codecs/isac/fix/source/lpc_tables.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/jsep.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/rtp_headers.h
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/third_party/portaudio/pa_memorybarrier.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/asyncresolverfactory.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/utility/ooura_fft_tables_neon_sse2.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/time/time.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec3/echo_canceller3.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/synchronization/mutex_benchmark.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/video/video_stream_encoder_interface.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/container/inlined_vector.h
[add] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/api/peerconnectioninterface.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/source/rtp_packet_unittest.cc
[rename] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/third_party/sigslot/sigslot.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/source/rtcp_receiver.cc
[rename] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/common_audio/third_party/fft4g/fft4g.c
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/agc/agc.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/post_decode_vad.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec3/suppression_gain_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/onetimeevent.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/codecs/isac/main/source/isac.c
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec3/erle_estimator.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/codecs/isac/fix/source/lpc_masking_model_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/agc/agc_manager_direct_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/sslidentity.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/source/rtp_sender_video.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/sigslottester_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/rtp_rtcp/source/rtcp_receiver.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/common_audio/vad/vad_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/httpcommon.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/tick_timer.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/common_audio/BUILD.gn
[delete] https://crrev.com/7874576bed69e203d9a87409ac1d9a87d3842164/modules/audio_processing/intelligibility/intelligibility_enhancer_unittest.cc
[delete] https://crrev.com/7874576bed69e203d9a87409ac1d9a87d3842164/absl/time/internal/get_current_time_ios.inc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/agc2/gain_curve_applier_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/transient/dyadic_decimator.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/absl/synchronization/internal/kernel_timeout.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/utility/ooura_fft_mips.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/system_wrappers/BUILD.gn
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/neteq/tools/neteq_test.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/rtc_base/opensslutility.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec3/subtractor_output_analyzer.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/acm2/audio_coding_module_unittest.cc
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_coding/codecs/isac/fix/source/structs.h
[modify] https://crrev.com/edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9/modules/audio_processing/aec3/subtractor.cc
[delete] https://crrev.com/7874576bed69e203d9a87409ac
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/400399da40785d27b86863f81d14d296ebe993dc

commit 400399da40785d27b86863f81d14d296ebe993dc
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Fri Aug 31 22:08:40 2018

CRAS: config - Update aec_config to latest webrtc-apm

Some parameters are added and some removed. A few of them
changed default value.

BUG= chromium:874787 
TEST=apply all config files and test on nocturne
CQ-DEPEND=CL:1194561

Change-Id: I0e47e330b0aaf002d8338f064f0052cc87ff261c
Reviewed-on: https://chromium-review.googlesource.com/1196304
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/400399da40785d27b86863f81d14d296ebe993dc/cras/src/server/config/aec_config.h
[modify] https://crrev.com/400399da40785d27b86863f81d14d296ebe993dc/cras/src/server/config/aec_config.c

Cc: geohsu@chromium.org
Labels: Merge-Request-70
CLs in #6 #7 #8 #9 just missed M70 cut. Request merge to M70.

Note that: CLs in #2 #3 are still waiting M69 merge approval.
Project Member

Comment 11 by sheriffbot@chromium.org, Sep 4

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 4

Labels: merge-merged-release-R70-11021.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/webrtc-apm/+/b74255c9f9ec0754e5f356c4967adf56eebb8f2a

commit b74255c9f9ec0754e5f356c4967adf56eebb8f2a
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Tue Sep 04 06:28:36 2018

Expose apm_config

Expose parameters of webrtc::AudioProcessing::Config to
be configured by CRAS.
New parmeters includes configuring pre-amp gain, NS, AGC/AGC2,
which are not in aec3 config.

BUG= chromium:874787 
TEST=apply all config files and test on nocturne

Change-Id: Ib34a01598610f88ebf82e33f9d797c29627531ea
Reviewed-on: https://chromium-review.googlesource.com/1174085
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
(cherry picked from commit 7874576bed69e203d9a87409ac1d9a87d3842164)
Reviewed-on: https://chromium-review.googlesource.com/1203497
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Commit-Queue: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/b74255c9f9ec0754e5f356c4967adf56eebb8f2a/webrtc_apm.h
[modify] https://crrev.com/b74255c9f9ec0754e5f356c4967adf56eebb8f2a/webrtc_apm.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 4

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/e1dc93a210f7ab43c21cd243dfdf4a8c87e952ae

commit e1dc93a210f7ab43c21cd243dfdf4a8c87e952ae
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Tue Sep 04 07:23:23 2018

CRAS: config - Update aec_config to latest webrtc-apm

Some parameters are added and some removed. A few of them
changed default value.

BUG= chromium:874787 
TEST=apply all config files and test on nocturne
CQ-DEPEND=CL:1203498

Change-Id: I0e47e330b0aaf002d8338f064f0052cc87ff261c
Reviewed-on: https://chromium-review.googlesource.com/1196304
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
(cherry picked from commit 400399da40785d27b86863f81d14d296ebe993dc)
Reviewed-on: https://chromium-review.googlesource.com/1203676
Commit-Queue: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/e1dc93a210f7ab43c21cd243dfdf4a8c87e952ae/cras/src/server/config/aec_config.h
[modify] https://crrev.com/e1dc93a210f7ab43c21cd243dfdf4a8c87e952ae/cras/src/server/config/aec_config.c

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/webrtc-apm/+/92c5962352174349f3d7bc4117f1514f8d3fc9cc

commit 92c5962352174349f3d7bc4117f1514f8d3fc9cc
Author: Hsin-Yu Chao <hychao@google.com>
Date: Tue Sep 04 07:23:24 2018

Sync to webrtc ToT

Update to commit "AEC3: Parametrize the shadow filter output usage".

https://webrtc.googlesource.com/src/+/240215431ee21e85e415484d1d80f437850f2f8e

This update includes all parameters and codes for tuning
APM performance with CRAS.

BUG= chromium:874787 
TEST=Apply all config files and test on nocturne
CQ-DEPEND=CL:1203676

Change-Id: Idf6da0c70ac1569d2567c2ab15f436731edb3f35
Reviewed-on: https://chromium-review.googlesource.com/1194561
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
(cherry picked from commit edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9)
Reviewed-on: https://chromium-review.googlesource.com/1203498
Commit-Queue: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/acm2/rent_a_codec.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/aec_state.cc
[rename] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/third_party/base64/base64.cc
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/video/video_stream_encoder_observer.cc
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/third_party/base64/module.mk
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/matched_filter.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/g711/LICENSE
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/debugging/failure_signal_handler.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/random.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/sigslotrepeater.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/gain_controller2.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/preemptive_expand.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/audio_decoder_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/gain_control_for_experimental_agc.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_packet.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/container/fixed_array.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/include/audio_coding_module.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/audio_sink.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/synchronization/mutex_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/meta/type_traits.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_sender.cc
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/reverb_frequency_response.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_format_vp8.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/strings/escaping.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/system_wrappers/source/cpu_features_linux.c
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/ilbc/ilbc.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/main/source/encode_lpc_swb.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/filter_analyzer.h
[rename] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/third_party/fft4g/fft4g.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_format.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/fft_data_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/strings/BUILD.bazel
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/units/timestamp.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/delay_estimator.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/fft/README.chromium
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/portaudio/pa_ringbuffer.c
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/third_party/spl_sqrt_floor/README.chromium
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/base/internal/exception_testing.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/portaudio/pa_ringbuffer.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/sigslottester.h.pump
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/base/CMakeLists.txt
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/BUILD.gn
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/packet_source.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/OWNERS
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/units/data_rate_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_receiver_impl.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/time/clock.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/vad/vad_core_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/strings/str_format_test.cc
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/module.mk
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/include/audio_processing.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/audio_network_adaptor/parse_ana_dump.py
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/fec_private_tables_random.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/tools/audio_codec_speed_test.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/acm2/acm_receiver.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/base/BUILD.bazel
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/vad/gmm.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/include/rtp_header_parser.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/vector_math.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec_dump/aec_dump_integration_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/transient/file_utils.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/adaptive_agc.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/encode_neteq_input.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/ooura_fft_sse2.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/pcm16b/pcm16b.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/third_party/base64/LICENSE
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/neteq_input.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/third_party/module.mk
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/timeutils.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/base/internal/raw_logging.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/random_vector.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/transport/network_types.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/ilbc/cb_construct.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/video/video_stream_encoder_create.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/neteq_delay_analyzer.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_generic_frame_descriptor.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_receiver_video.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/main/source/lpc_shape_swb12_tables.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/message_buffer_reader.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/jsepicecandidate.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/main/source/lpc_shape_swb12_tables.c
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/interpolated_gain_curve_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/audio_multi_vector_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/base/internal/raw_logging.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/gain_curve_applier.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/network.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/criticalsection.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/ilbc/vq4.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/criticalsection.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/rtpreceiverinterface.cc
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/time/internal/get_current_time_chrono.inc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_receiver_strategy.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/ilbc/get_cd_vec.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/statstypes.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/adaptive_fir_filter.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/audio_options.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/stream.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/vad/pole_zero_filter.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/delay_estimator_wrapper.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/main/source/structs.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/delay_estimator_internal.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/time_stretch.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_header_extension_map_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/units/timestamp_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/ilbc/constants.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/copyonwritebuffer.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/copts.bzl
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/fix/source/filterbank_internal.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/container/BUILD.gn
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/packet_buffer.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/meta/type_traits_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/include/audio_util.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/vad/vad_unittest.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/fixed_gain_controller.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/main/source/pitch_lag_tables.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/synchronization/rw_lock_posix.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec/aec_core.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/signal_processing/complex_fft.c
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/block_delay_buffer_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/echo_canceller3.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/timestamp_scaler.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/fft/LICENSE
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/units/time_delta.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/experiments/rtt_mult_experiment.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/vad/vad_sp.c
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/audio/channel.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/portaudio/BUILD.gn
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/rtpparameters.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_format_vp8_test_helper.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/adaptive_agc.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/adaptive_digital_gain_applier.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/audio/audio_send_stream_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/receive_statistics_impl.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/sslcertificate.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/audio/channel_proxy.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/filter_analyzer.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/rtpsenderinterface.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/container/internal/compressed_tuple_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/experiments/BUILD.gn
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/audio_processing_impl.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/signal_processing/resample_by_2_internal.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/audio_vector.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/rtp_jitter.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/audio_processing_performance_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/units/data_size.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/units/timestamp.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/vad/include/vad.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/memory/aligned_malloc.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/synchronization/mutex.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/signal_processing/complex_fft_tables.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/ooura_fft.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/transient/moving_moments.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/base64_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/echo_remover.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/audio_vector_unittest.cc
[rename] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/g722/g722_enc_dec.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/rtpreceiverinterface.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/video/video_bitrate_allocator.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/datachannelinterface.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/algorithm/container.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/network.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/reverb_model_estimator.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/audio_processing_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/include/rtp_payload_registry.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/helpers.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/container/inlined_vector_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/packet.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/opus/opus_fec_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/fix/source/lpc_tables.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/jsep.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/rtp_headers.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/portaudio/pa_memorybarrier.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/asyncresolverfactory.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/ooura_fft_tables_neon_sse2.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/time/time.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/echo_canceller3.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/synchronization/mutex_benchmark.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/video/video_stream_encoder_interface.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/container/inlined_vector.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/peerconnectioninterface.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_packet_unittest.cc
[rename] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/third_party/sigslot/sigslot.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtcp_receiver.cc
[rename] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/third_party/fft4g/fft4g.c
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc/agc.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/post_decode_vad.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/suppression_gain_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/onetimeevent.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/main/source/isac.c
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/erle_estimator.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/fix/source/lpc_masking_model_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc/agc_manager_direct_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/sslidentity.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_sender_video.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/sigslottester_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtcp_receiver.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/vad/vad_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/httpcommon.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tick_timer.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/BUILD.gn
[delete] https://crrev.com/b74255c9f9ec0754e5f356c4967adf56eebb8f2a/modules/audio_processing/intelligibility/intelligibility_enhancer_unittest.cc
[delete] https://crrev.com/b74255c9f9ec0754e5f356c4967adf56eebb8f2a/absl/time/internal/get_current_time_ios.inc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/gain_curve_applier_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/transient/dyadic_decimator.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/synchronization/internal/kernel_timeout.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/ooura_fft_mips.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/system_wrappers/BUILD.gn
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/neteq_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/opensslutility.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/subtractor_output_analyzer.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/acm2/audio_coding_module_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/fix/sou
Project Member

Comment 16 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/webrtc-apm/+/b74255c9f9ec0754e5f356c4967adf56eebb8f2a

commit b74255c9f9ec0754e5f356c4967adf56eebb8f2a
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Tue Sep 04 06:28:36 2018

Expose apm_config

Expose parameters of webrtc::AudioProcessing::Config to
be configured by CRAS.
New parmeters includes configuring pre-amp gain, NS, AGC/AGC2,
which are not in aec3 config.

BUG= chromium:874787 
TEST=apply all config files and test on nocturne

Change-Id: Ib34a01598610f88ebf82e33f9d797c29627531ea
Reviewed-on: https://chromium-review.googlesource.com/1174085
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
(cherry picked from commit 7874576bed69e203d9a87409ac1d9a87d3842164)
Reviewed-on: https://chromium-review.googlesource.com/1203497
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Commit-Queue: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/b74255c9f9ec0754e5f356c4967adf56eebb8f2a/webrtc_apm.h
[modify] https://crrev.com/b74255c9f9ec0754e5f356c4967adf56eebb8f2a/webrtc_apm.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Sep 4

Project Member

Comment 18 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/e1dc93a210f7ab43c21cd243dfdf4a8c87e952ae

commit e1dc93a210f7ab43c21cd243dfdf4a8c87e952ae
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Tue Sep 04 07:23:23 2018

CRAS: config - Update aec_config to latest webrtc-apm

Some parameters are added and some removed. A few of them
changed default value.

BUG= chromium:874787 
TEST=apply all config files and test on nocturne
CQ-DEPEND=CL:1203498

Change-Id: I0e47e330b0aaf002d8338f064f0052cc87ff261c
Reviewed-on: https://chromium-review.googlesource.com/1196304
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
(cherry picked from commit 400399da40785d27b86863f81d14d296ebe993dc)
Reviewed-on: https://chromium-review.googlesource.com/1203676
Commit-Queue: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/e1dc93a210f7ab43c21cd243dfdf4a8c87e952ae/cras/src/server/config/aec_config.h
[modify] https://crrev.com/e1dc93a210f7ab43c21cd243dfdf4a8c87e952ae/cras/src/server/config/aec_config.c

Project Member

Comment 19 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/webrtc-apm/+/92c5962352174349f3d7bc4117f1514f8d3fc9cc

commit 92c5962352174349f3d7bc4117f1514f8d3fc9cc
Author: Hsin-Yu Chao <hychao@google.com>
Date: Tue Sep 04 07:23:24 2018

Sync to webrtc ToT

Update to commit "AEC3: Parametrize the shadow filter output usage".

https://webrtc.googlesource.com/src/+/240215431ee21e85e415484d1d80f437850f2f8e

This update includes all parameters and codes for tuning
APM performance with CRAS.

BUG= chromium:874787 
TEST=Apply all config files and test on nocturne
CQ-DEPEND=CL:1203676

Change-Id: Idf6da0c70ac1569d2567c2ab15f436731edb3f35
Reviewed-on: https://chromium-review.googlesource.com/1194561
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
(cherry picked from commit edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9)
Reviewed-on: https://chromium-review.googlesource.com/1203498
Commit-Queue: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/acm2/rent_a_codec.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/aec_state.cc
[rename] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/third_party/base64/base64.cc
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/video/video_stream_encoder_observer.cc
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/third_party/base64/module.mk
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/matched_filter.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/g711/LICENSE
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/debugging/failure_signal_handler.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/random.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/sigslotrepeater.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/gain_controller2.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/preemptive_expand.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/audio_decoder_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/gain_control_for_experimental_agc.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_packet.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/container/fixed_array.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/include/audio_coding_module.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/audio_sink.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/synchronization/mutex_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/meta/type_traits.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_sender.cc
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/reverb_frequency_response.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_format_vp8.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/strings/escaping.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/system_wrappers/source/cpu_features_linux.c
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/ilbc/ilbc.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/main/source/encode_lpc_swb.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/filter_analyzer.h
[rename] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/third_party/fft4g/fft4g.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_format.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/fft_data_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/strings/BUILD.bazel
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/units/timestamp.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/delay_estimator.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/fft/README.chromium
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/portaudio/pa_ringbuffer.c
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/third_party/spl_sqrt_floor/README.chromium
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/base/internal/exception_testing.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/portaudio/pa_ringbuffer.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/sigslottester.h.pump
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/base/CMakeLists.txt
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/BUILD.gn
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/packet_source.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/OWNERS
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/units/data_rate_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_receiver_impl.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/time/clock.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/vad/vad_core_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/strings/str_format_test.cc
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/module.mk
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/include/audio_processing.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/audio_network_adaptor/parse_ana_dump.py
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/fec_private_tables_random.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/tools/audio_codec_speed_test.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/acm2/acm_receiver.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/base/BUILD.bazel
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/vad/gmm.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/include/rtp_header_parser.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/vector_math.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec_dump/aec_dump_integration_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/transient/file_utils.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/adaptive_agc.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/encode_neteq_input.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/ooura_fft_sse2.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/pcm16b/pcm16b.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/third_party/base64/LICENSE
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/neteq_input.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/third_party/module.mk
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/timeutils.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/base/internal/raw_logging.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/random_vector.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/transport/network_types.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/ilbc/cb_construct.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/video/video_stream_encoder_create.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/neteq_delay_analyzer.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_generic_frame_descriptor.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_receiver_video.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/main/source/lpc_shape_swb12_tables.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/message_buffer_reader.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/jsepicecandidate.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/main/source/lpc_shape_swb12_tables.c
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/interpolated_gain_curve_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/audio_multi_vector_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/base/internal/raw_logging.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/gain_curve_applier.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/network.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/criticalsection.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/ilbc/vq4.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/criticalsection.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/rtpreceiverinterface.cc
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/time/internal/get_current_time_chrono.inc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_receiver_strategy.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/ilbc/get_cd_vec.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/statstypes.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/adaptive_fir_filter.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/audio_options.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/stream.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/vad/pole_zero_filter.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/delay_estimator_wrapper.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/main/source/structs.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/delay_estimator_internal.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/time_stretch.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_header_extension_map_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/units/timestamp_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/ilbc/constants.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/copyonwritebuffer.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/copts.bzl
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/fix/source/filterbank_internal.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/container/BUILD.gn
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/packet_buffer.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/meta/type_traits_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/include/audio_util.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/vad/vad_unittest.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/fixed_gain_controller.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/main/source/pitch_lag_tables.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/synchronization/rw_lock_posix.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec/aec_core.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/signal_processing/complex_fft.c
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/block_delay_buffer_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/echo_canceller3.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/timestamp_scaler.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/fft/LICENSE
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/units/time_delta.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/experiments/rtt_mult_experiment.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/vad/vad_sp.c
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/audio/channel.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/portaudio/BUILD.gn
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/rtpparameters.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_format_vp8_test_helper.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/adaptive_agc.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/adaptive_digital_gain_applier.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/audio/audio_send_stream_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/receive_statistics_impl.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/sslcertificate.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/audio/channel_proxy.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/filter_analyzer.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/rtpsenderinterface.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/container/internal/compressed_tuple_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/experiments/BUILD.gn
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/audio_processing_impl.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/signal_processing/resample_by_2_internal.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/audio_vector.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/rtp_jitter.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/audio_processing_performance_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/units/data_size.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/units/timestamp.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/vad/include/vad.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/memory/aligned_malloc.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/synchronization/mutex.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/signal_processing/complex_fft_tables.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/ooura_fft.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/transient/moving_moments.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/base64_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/echo_remover.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/audio_vector_unittest.cc
[rename] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/g722/g722_enc_dec.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/rtpreceiverinterface.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/video/video_bitrate_allocator.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/datachannelinterface.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/algorithm/container.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/network.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/reverb_model_estimator.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/audio_processing_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/include/rtp_payload_registry.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/helpers.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/container/inlined_vector_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/packet.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/opus/opus_fec_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/fix/source/lpc_tables.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/jsep.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/rtp_headers.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/portaudio/pa_memorybarrier.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/asyncresolverfactory.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/ooura_fft_tables_neon_sse2.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/time/time.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/echo_canceller3.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/synchronization/mutex_benchmark.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/video/video_stream_encoder_interface.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/container/inlined_vector.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/peerconnectioninterface.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_packet_unittest.cc
[rename] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/third_party/sigslot/sigslot.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtcp_receiver.cc
[rename] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/third_party/fft4g/fft4g.c
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc/agc.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/post_decode_vad.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/suppression_gain_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/onetimeevent.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/main/source/isac.c
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/erle_estimator.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/fix/source/lpc_masking_model_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc/agc_manager_direct_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/sslidentity.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_sender_video.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/sigslottester_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtcp_receiver.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/vad/vad_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/httpcommon.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tick_timer.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/BUILD.gn
[delete] https://crrev.com/b74255c9f9ec0754e5f356c4967adf56eebb8f2a/modules/audio_processing/intelligibility/intelligibility_enhancer_unittest.cc
[delete] https://crrev.com/b74255c9f9ec0754e5f356c4967adf56eebb8f2a/absl/time/internal/get_current_time_ios.inc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/gain_curve_applier_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/transient/dyadic_decimator.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/synchronization/internal/kernel_timeout.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/ooura_fft_mips.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/system_wrappers/BUILD.gn
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/neteq_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/opensslutility.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/subtractor_output_analyzer.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/acm2/audio_coding_module_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/fix/sou
Project Member

Comment 20 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/webrtc-apm/+/b74255c9f9ec0754e5f356c4967adf56eebb8f2a

commit b74255c9f9ec0754e5f356c4967adf56eebb8f2a
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Tue Sep 04 06:28:36 2018

Expose apm_config

Expose parameters of webrtc::AudioProcessing::Config to
be configured by CRAS.
New parmeters includes configuring pre-amp gain, NS, AGC/AGC2,
which are not in aec3 config.

BUG= chromium:874787 
TEST=apply all config files and test on nocturne

Change-Id: Ib34a01598610f88ebf82e33f9d797c29627531ea
Reviewed-on: https://chromium-review.googlesource.com/1174085
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
(cherry picked from commit 7874576bed69e203d9a87409ac1d9a87d3842164)
Reviewed-on: https://chromium-review.googlesource.com/1203497
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Commit-Queue: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/b74255c9f9ec0754e5f356c4967adf56eebb8f2a/webrtc_apm.h
[modify] https://crrev.com/b74255c9f9ec0754e5f356c4967adf56eebb8f2a/webrtc_apm.cc

Project Member

Comment 21 by bugdroid1@chromium.org, Sep 4

Project Member

Comment 22 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/e1dc93a210f7ab43c21cd243dfdf4a8c87e952ae

commit e1dc93a210f7ab43c21cd243dfdf4a8c87e952ae
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Tue Sep 04 07:23:23 2018

CRAS: config - Update aec_config to latest webrtc-apm

Some parameters are added and some removed. A few of them
changed default value.

BUG= chromium:874787 
TEST=apply all config files and test on nocturne
CQ-DEPEND=CL:1203498

Change-Id: I0e47e330b0aaf002d8338f064f0052cc87ff261c
Reviewed-on: https://chromium-review.googlesource.com/1196304
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
(cherry picked from commit 400399da40785d27b86863f81d14d296ebe993dc)
Reviewed-on: https://chromium-review.googlesource.com/1203676
Commit-Queue: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/e1dc93a210f7ab43c21cd243dfdf4a8c87e952ae/cras/src/server/config/aec_config.h
[modify] https://crrev.com/e1dc93a210f7ab43c21cd243dfdf4a8c87e952ae/cras/src/server/config/aec_config.c

Project Member

Comment 23 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/webrtc-apm/+/92c5962352174349f3d7bc4117f1514f8d3fc9cc

commit 92c5962352174349f3d7bc4117f1514f8d3fc9cc
Author: Hsin-Yu Chao <hychao@google.com>
Date: Tue Sep 04 07:23:24 2018

Sync to webrtc ToT

Update to commit "AEC3: Parametrize the shadow filter output usage".

https://webrtc.googlesource.com/src/+/240215431ee21e85e415484d1d80f437850f2f8e

This update includes all parameters and codes for tuning
APM performance with CRAS.

BUG= chromium:874787 
TEST=Apply all config files and test on nocturne
CQ-DEPEND=CL:1203676

Change-Id: Idf6da0c70ac1569d2567c2ab15f436731edb3f35
Reviewed-on: https://chromium-review.googlesource.com/1194561
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
(cherry picked from commit edc7e2a9977370ba0ff487cf1367fbdc1bc8d9e9)
Reviewed-on: https://chromium-review.googlesource.com/1203498
Commit-Queue: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/acm2/rent_a_codec.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/aec_state.cc
[rename] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/third_party/base64/base64.cc
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/video/video_stream_encoder_observer.cc
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/third_party/base64/module.mk
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/matched_filter.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/g711/LICENSE
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/debugging/failure_signal_handler.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/random.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/sigslotrepeater.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/gain_controller2.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/preemptive_expand.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/audio_decoder_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/gain_control_for_experimental_agc.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_packet.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/container/fixed_array.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/include/audio_coding_module.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/audio_sink.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/synchronization/mutex_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/meta/type_traits.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_sender.cc
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/reverb_frequency_response.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_format_vp8.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/strings/escaping.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/system_wrappers/source/cpu_features_linux.c
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/ilbc/ilbc.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/main/source/encode_lpc_swb.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/filter_analyzer.h
[rename] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/third_party/fft4g/fft4g.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_format.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/fft_data_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/strings/BUILD.bazel
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/units/timestamp.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/delay_estimator.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/fft/README.chromium
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/portaudio/pa_ringbuffer.c
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/third_party/spl_sqrt_floor/README.chromium
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/base/internal/exception_testing.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/portaudio/pa_ringbuffer.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/sigslottester.h.pump
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/base/CMakeLists.txt
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/BUILD.gn
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/packet_source.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/OWNERS
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/units/data_rate_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_receiver_impl.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/include/rtp_rtcp_defines.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/time/clock.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/vad/vad_core_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/strings/str_format_test.cc
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/module.mk
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/include/audio_processing.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/audio_network_adaptor/parse_ana_dump.py
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/fec_private_tables_random.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/tools/audio_codec_speed_test.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/acm2/acm_receiver.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/base/BUILD.bazel
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/vad/gmm.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/include/rtp_header_parser.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/vector_math.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec_dump/aec_dump_integration_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/transient/file_utils.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/adaptive_agc.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/encode_neteq_input.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/ooura_fft_sse2.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/pcm16b/pcm16b.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/third_party/base64/LICENSE
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/neteq_input.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/third_party/module.mk
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/timeutils.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/base/internal/raw_logging.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/random_vector.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/transport/network_types.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/ilbc/cb_construct.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/video/video_stream_encoder_create.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/neteq_delay_analyzer.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_generic_frame_descriptor.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_receiver_video.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/main/source/lpc_shape_swb12_tables.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/message_buffer_reader.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/jsepicecandidate.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/main/source/lpc_shape_swb12_tables.c
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/interpolated_gain_curve_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/audio_multi_vector_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/base/internal/raw_logging.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/gain_curve_applier.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/network.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/criticalsection.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/ilbc/vq4.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/criticalsection.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/rtpreceiverinterface.cc
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/time/internal/get_current_time_chrono.inc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_receiver_strategy.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/ilbc/get_cd_vec.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/statstypes.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/adaptive_fir_filter.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/audio_options.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/stream.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/vad/pole_zero_filter.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/delay_estimator_wrapper.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/main/source/structs.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/delay_estimator_internal.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/time_stretch.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_header_extension_map_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/units/timestamp_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/ilbc/constants.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/copyonwritebuffer.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/copts.bzl
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/fix/source/filterbank_internal.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/container/BUILD.gn
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/packet_buffer.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/meta/type_traits_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/include/audio_util.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/vad/vad_unittest.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/fixed_gain_controller.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/main/source/pitch_lag_tables.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/synchronization/rw_lock_posix.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec/aec_core.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/signal_processing/complex_fft.c
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/block_delay_buffer_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/echo_canceller3.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/timestamp_scaler.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/fft/LICENSE
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/units/time_delta.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/experiments/rtt_mult_experiment.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/vad/vad_sp.c
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/audio/channel.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/portaudio/BUILD.gn
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/rtpparameters.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_format_vp8_test_helper.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/adaptive_agc.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/adaptive_digital_gain_applier.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/audio/audio_send_stream_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/receive_statistics_impl.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/sslcertificate.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/audio/channel_proxy.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/filter_analyzer.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/rtpsenderinterface.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/container/internal/compressed_tuple_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/experiments/BUILD.gn
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/audio_processing_impl.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/signal_processing/resample_by_2_internal.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/audio_vector.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/rtp_jitter.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/audio_processing_performance_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/units/data_size.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/units/timestamp.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/vad/include/vad.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/memory/aligned_malloc.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/synchronization/mutex.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/signal_processing/complex_fft_tables.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/ooura_fft.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/transient/moving_moments.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/base64_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/echo_remover.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/audio_vector_unittest.cc
[rename] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/g722/g722_enc_dec.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/rtpreceiverinterface.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/video/video_bitrate_allocator.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/datachannelinterface.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/algorithm/container.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/network.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/reverb_model_estimator.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/audio_processing_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/include/rtp_payload_registry.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/helpers.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/container/inlined_vector_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/packet.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/opus/opus_fec_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/fix/source/lpc_tables.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/jsep.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/rtp_headers.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/third_party/portaudio/pa_memorybarrier.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/asyncresolverfactory.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/ooura_fft_tables_neon_sse2.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/time/time.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/echo_canceller3.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/synchronization/mutex_benchmark.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/video/video_stream_encoder_interface.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/container/inlined_vector.h
[add] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/api/peerconnectioninterface.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_packet_unittest.cc
[rename] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/third_party/sigslot/sigslot.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtcp_receiver.cc
[rename] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/third_party/fft4g/fft4g.c
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc/agc.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/post_decode_vad.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/suppression_gain_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/onetimeevent.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/main/source/isac.c
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/erle_estimator.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/fix/source/lpc_masking_model_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc/agc_manager_direct_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/sslidentity.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtp_sender_video.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/sigslottester_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/rtp_rtcp/source/rtcp_receiver.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/vad/vad_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/httpcommon.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tick_timer.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/common_audio/BUILD.gn
[delete] https://crrev.com/b74255c9f9ec0754e5f356c4967adf56eebb8f2a/modules/audio_processing/intelligibility/intelligibility_enhancer_unittest.cc
[delete] https://crrev.com/b74255c9f9ec0754e5f356c4967adf56eebb8f2a/absl/time/internal/get_current_time_ios.inc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/agc2/gain_curve_applier_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/transient/dyadic_decimator.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/absl/synchronization/internal/kernel_timeout.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/utility/ooura_fft_mips.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/system_wrappers/BUILD.gn
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/neteq/tools/neteq_test.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/rtc_base/opensslutility.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_processing/aec3/subtractor_output_analyzer.h
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/acm2/audio_coding_module_unittest.cc
[modify] https://crrev.com/92c5962352174349f3d7bc4117f1514f8d3fc9cc/modules/audio_coding/codecs/isac/fix/sou
Labels: -Merge-Approved-70
Merge done for M70. (why bugdroid gives duplicated posts?)

Note that We still need the CLs from #2 and #3 merge to M69, for CFM testing.
Blockedon: 882742
Project Member

Comment 26 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/9e076196ee49614a087b58cf4ab692c998cbafca

commit 9e076196ee49614a087b58cf4ab692c998cbafca
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Thu Sep 13 13:14:18 2018

nocturne: audio-config - AEC tuning

- board.ini to turn on AEC supported flag
- UCM HiFi.conf to specify echo reference dev
- UCM specify dmic_eq
- dsp.ini for dmic_eq to adjust dmic gain
- aec.ini for tuned parameters in aec3 config
- apm.ini for parameters for pre-amp/NS/AGC

BUG= chromium:874787 
TEST=Apply all config files and test on nocturne

Change-Id: If19dd28ba838cd198752448a846442b895db86d3
Reviewed-on: https://chromium-review.googlesource.com/1180786
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Reviewed-by: Leonardo Kusumo <leonardokusumo@chromium.org>

[add] https://crrev.com/9e076196ee49614a087b58cf4ab692c998cbafca/overlay-nocturne/chromeos-base/chromeos-bsp-nocturne/files/audio-config/cras-config/apm.ini
[add] https://crrev.com/9e076196ee49614a087b58cf4ab692c998cbafca/overlay-nocturne/chromeos-base/chromeos-bsp-nocturne/files/audio-config/cras-config/dsp.ini
[add] https://crrev.com/9e076196ee49614a087b58cf4ab692c998cbafca/overlay-nocturne/chromeos-base/chromeos-bsp-nocturne/files/audio-config/cras-config/board.ini
[modify] https://crrev.com/9e076196ee49614a087b58cf4ab692c998cbafca/overlay-nocturne/chromeos-base/chromeos-bsp-nocturne/files/audio-config/ucm-config/kblmax98373/HiFi.conf
[rename] https://crrev.com/9e076196ee49614a087b58cf4ab692c998cbafca/overlay-nocturne/chromeos-base/chromeos-bsp-nocturne/chromeos-bsp-nocturne-0.0.1-r23.ebuild
[add] https://crrev.com/9e076196ee49614a087b58cf4ab692c998cbafca/overlay-nocturne/chromeos-base/chromeos-bsp-nocturne/files/audio-config/cras-config/aec.ini

Hychao:

I notice that https://chromium-review.googlesource.com/c/chromiumos/overlays/board-overlays/+/1180786 is not in M-70.

If you don't mind, I can cherry-pick it back along with the hifi.conf changes to support EVT2 and DVT.
Cc: bleung@chromium.org
Cc: bleung@google.com
I posted this series on m-70, hychao, which includes the patch in comment #26:
https://chromium-review.googlesource.com/q/topic:%22dmic-port-change-dvt-evt-coexist-m70%22+(status:open%20OR%20status:merged)
Project Member

Comment 30 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/2f5383ddcdc482a2035b2ebb009f61bb84749ab4

commit 2f5383ddcdc482a2035b2ebb009f61bb84749ab4
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Fri Sep 21 04:45:50 2018

nocturne: audio-config - AEC tuning

- board.ini to turn on AEC supported flag
- UCM HiFi.conf to specify echo reference dev
- UCM specify dmic_eq
- dsp.ini for dmic_eq to adjust dmic gain
- aec.ini for tuned parameters in aec3 config
- apm.ini for parameters for pre-amp/NS/AGC

BUG= chromium:874787 
TEST=Apply all config files and test on nocturne

Reviewed-on: https://chromium-review.googlesource.com/1180786
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Reviewed-by: Leonardo Kusumo <leonardokusumo@chromium.org>
(cherry picked from commit 9e076196ee49614a087b58cf4ab692c998cbafca)
Signed-off-by: Benson Leung <bleung@chromium.org>

Change-Id: If19dd28ba838cd198752448a846442b895db86d3
Reviewed-on: https://chromium-review.googlesource.com/1234296
Reviewed-by: Leonardo Kusumo <leonardokusumo@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>
Commit-Queue: Benson Leung <bleung@chromium.org>
Tested-by: Benson Leung <bleung@chromium.org>
Trybot-Ready: Benson Leung <bleung@chromium.org>

[add] https://crrev.com/2f5383ddcdc482a2035b2ebb009f61bb84749ab4/overlay-nocturne/chromeos-base/chromeos-bsp-nocturne/files/audio-config/cras-config/apm.ini
[add] https://crrev.com/2f5383ddcdc482a2035b2ebb009f61bb84749ab4/overlay-nocturne/chromeos-base/chromeos-bsp-nocturne/files/audio-config/cras-config/dsp.ini
[add] https://crrev.com/2f5383ddcdc482a2035b2ebb009f61bb84749ab4/overlay-nocturne/chromeos-base/chromeos-bsp-nocturne/files/audio-config/cras-config/board.ini
[modify] https://crrev.com/2f5383ddcdc482a2035b2ebb009f61bb84749ab4/overlay-nocturne/chromeos-base/chromeos-bsp-nocturne/files/audio-config/ucm-config/kblmax98373/HiFi.conf
[rename] https://crrev.com/2f5383ddcdc482a2035b2ebb009f61bb84749ab4/overlay-nocturne/chromeos-base/chromeos-bsp-nocturne/chromeos-bsp-nocturne-0.0.1-r23.ebuild
[add] https://crrev.com/2f5383ddcdc482a2035b2ebb009f61bb84749ab4/overlay-nocturne/chromeos-base/chromeos-bsp-nocturne/files/audio-config/cras-config/aec.ini

Yes I missed the board overlay CL. Thank you Benson!
Labels: -Merge-Review-69
Status: Fixed (was: Started)
No longer need this in 69, marking as fixed.

Sign in to add a comment