New issue
Advanced search Search tips

Issue 874780 link

Starred by 2 users
Status: Assigned
Owner:
markchang@chromium.org
Cc:
pbos@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Find-In' bubble is seen misplaced in full-screen mode.

Reported by sanyam.g...@etouch.net, Aug 16 
Chrome Version: 70.0.3524.0 (Official Build) af89913d666a6f95572c04f15ab3a0752343ebf3-refs/branch-heads/3524@{#1} (32/64 bit)

OS: Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04) OS

Steps to reproduce:
(1) Launch Chrome, navigate to NTP and enter 'Full-screen' mode.
(2) Open 'Find-In' bubble by pressing 'ctrl+f' and observe. 

Actual Result  : 'Find-In' bubble is seen misplaced in full-screen mode.
Expected Result: 'Find-In' bubble should not be seen misplaced in full-screen mode.

This is a regression issue, broken in 'M-70' and below is the per-revision bisect info:
Good Build: 70.0.3516.0 (Revision: 581410)
Bad Build : 70.0.3517.0 (Revision: 581729)

You are probably looking for a change made after 581573 (known good), but no later than 581574 (first known bad).

CHANGE-LOG URL: 

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/80c95f806b8891bd0d3ea54becbb84200ee0f601..8c86ba838fcfac0de766c5448a2dc5a35c28ca18

Suspect: https://chromium.googlesource.com/chromium/src/+/8c86ba838fcfac0de766c5448a2dc5a35c28ca18

@cyan: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly review the attached screen-cast for reference..

Note: Issue is reproducible with both options of 'Show Bookmark bar'- check and uncheck.
 
Thank You!
Actual_Behaviour.mp4
394 KB View Download
Expected_Behaviour.mp4
327 KB View Download
Result_image.png
55.9 KB View Download

Comment 1 by cyan@chromium.org, Aug 16

Cc: pbos@chromium.org
Owner: markchang@chromium.org
Re-assigning to Mark to decide if this is necessary.

Before the change, the bookmark bar was considered as part of the content area when calling layout. This did not affect non full-screen since the find bar would be attached to the location bar. After the change I made, the bookmark bar is no longer part of the content area so the find bar now renders on the content area.

If you search "gmail" in the find bar now, and it is currently covering the content, it will move over and all content is searchable.

Right now, this regression is only on the NTP when full-screen so it would be a one off band-aid fix for it to go back to the way it was before (if fullscreen and detached bookmark then count bookmark bar as part of the content area).

Comment 2 by pbos@chromium.org, Aug 16 

Note that the change made the code simpler and if we don't find this regression terrible (which as far as we know only affects find in NTP in fullscreen with detached bookmarks bar), then we'd prefer to keep the code simpler.

Comment 3 by aiman.an...@etouch.net, Nov 14

Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIValid
***Mass UI Triage***

Hi,

Just to update:

Issue is still reproducible on Windows(7,8,8.1,10), Mac(10.13.1, 10.14.2, 10.13.6) and Linux(14.04) OS using Latest canary #72.0.3610.0

Please find the screen-cast for reference.

markchang@: Could you please take a look in to this issue.

Thank You!
Canary Behaviour.mp4
453 KB View Download
►

Sign in to add a comment