New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 874779 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
OOO Jan 14 - 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug


Participants' hotlists:
NTP-Birthday-Polish


Sign in to add a comment

[NTP] Unnecessary 'Remove' button appears selected even when focus is shifted.

Reported by rp...@etouch.net, Aug 16

Issue description

Chrome Version: 70.0.3524.0 (Official Build)Revision af89913d666a6f95572c04f15ab3a0752343ebf3-refs/branch-heads/3524@{#1}(32/64-bit)
OS: Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.14, 10.13.6) and Linux(14.04 LTs).

Pre-condition: Enable "Enable using the Google local NTP" and "New Tab Page Custom Links" flags from chrome://flags.

What steps will reproduce the problem?
1. Launch Chrome and navigate to NTP.
2. Click on 'Add shortcut' iron icon on chrome webstore thumbnail to open 'Add shortcut' overlay.
3. Now press 'Tab' key to bring focus on 'Remove' button and press and hold 'Space bar' and then press 'Tab' key to move focus,observe 'Remove' button

Actual: Unnecessary 'Remove' button appears selected even when focus is shifted.
Expected: 'Remove' button shouldn't appear selected when focus is shifted.

This is a non-regression issue, seen from M-70 series as 'Add shortcut' iron icon is introduced from build #70.0.3508.0

NOTE: This issue is also reproducible on Dev #70.0.3521.2

Kindly review the attached screen-cast for reference.

Thank you.
 
Actual_video.mp4
428 KB View Download
Actual_screenshot.png
72.4 KB View Download

Comment 1 Deleted

Owner: sweilun@chromium.org
This is super low priority but Weilun, would you mind taking a look. Basically if you hold space the CSS gets applied and never gets removed.
Status: Started (was: Assigned)
Could you verify the issue still exists? I can not reproduce the same problem in my Linux machine as well as MacOS

Screencast:
https://screencast.googleplex.com/cast/NjY1NTM2ODAwMDE3NjEyOHw4NWJlM2NjZC04Zg
Labels: zine-triaged
Status: WontFix (was: Started)
With response to comment #3 and #5 :
Rechecked this issue on Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.14, 10.13.6) and Linux(14.04 LTs) using latest Canary chrome version : 70.0.3535.0 the issue is still reproducible.Kindly refer the attached screen cast for your reference.

Thank you..!!
Actual_Canary_70.0.3535.0_behavior.mp4
259 KB View Download
Status: Started (was: WontFix)
Cc: kristip...@chromium.org
Labels: Needs-Feedback
This is the default behavior of the space bar on a button. This is not only for the Remove button but all the other buttons. One way to fix this is to make all the button to listen on the keydown event. But I don't think it's worth to do that for such obscure case. I would like to leave it as it be. wdyt?
Labels: -Target-70 Target-71

Comment 10 Deleted

Labels: -OS-iOS O-Robust-NTP KR-GAR4 OS-Chrome

Comment 12 Deleted

Labels: -Target-72 Target-73
NextAction: 2019-01-08
The NextAction date has arrived: 2019-01-08
NextAction: ----

Sign in to add a comment