New issue
Advanced search Search tips

Issue 874768 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Sep 14
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Missing include in ui/accessibility/ax_modes.h

Project Member Reported by ckulakow...@opera.com, Aug 16 
Chrome Version: 70.0.3521.2

There is missing include of cstdint in ui/accessibility/ax_modes.h (this file uses type uint32_t defined in cstdint). There are also two missing includes in chrome/browser/notifications/notification_platform_bridge_linux.cc. Lack of this includes causes compilation errors on non-jumbo builds in our project (Opera).

Comment 1 by ckulakow...@opera.com, Aug 16

Description: Show this description

Comment 2 by ckulakow...@opera.com, Aug 16

Description: Show this description

Comment 3 by dtapu...@chromium.org, Aug 28

Components: UI>Accessibility

Comment 4 by dmazz...@chromium.org, Sep 14

Status: Archived (was: Untriaged)
FYI, ax_modes.h was recently renamed:

https://chromium-review.googlesource.com/c/chromium/src/+/1207353

I believe that any compile error not caught by Chromium's builders is supported on a best effort basis. I'm an owner for ax_mode.h, you have my permission to get a review from any Chromium committer and TBR me to land any change to fix the jumbo build.

Closing as archived, but please feel free to reopen or reach out if you'd like help with a build fix.
►

Sign in to add a comment