New issue
Advanced search Search tips

Issue 874752 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Attach Accept: signed-exchange headers for prefetch

Project Member Reported by kinuko@chromium.org, Aug 16

Issue description

Something like: Accept: application/signed-exchange;v=b2;q=0.9,*/*;q=0.8

Final plan might change, but for OT we will use Accept header for feature detection both for navigations and prefetch.

We can't know when a site might want to use SXG (because it can be any resource) so we probably need to always attach / modify Accept header for prefetch when the feature is enabled. (E.g. check the existing Accept header and if it equals to the default one, i.e. network::kDefaultAcceptHeader, add signed-exchange as an acceptable type. This can be done either in Blink code or in content/browser/loader/prefetch_url_loader.cc.

This could potentially be a time-limited plan for OT/CDS.  Spec issue is also filed here: https://github.com/WICG/webpackage/issues/289
 
Components: Blink>Loader
Labels: SignedExchange-b2
Owner: ksakamoto@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e52eda37754c557cf5d3edc929d536a7906eb88

commit 0e52eda37754c557cf5d3edc929d536a7906eb88
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Thu Aug 23 09:53:23 2018

Attach Accept: signed-exchange headers for prefetch

This patch adds "Accept: application/signed-exchange;v=b1;q=0.9, */*;q=0.8"
request header to prefetch requests when the SignedHTTPExchange feature is
enabled.

The header is added in Blink side, so this patch wires up the
SignedHTTPExchange feature to a blink runtime flag.

Bug:  874752 
Change-Id: I25c15e3ebaf64455638f93e353fd9e91086ac223
Reviewed-on: https://chromium-review.googlesource.com/1184722
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585442}
[modify] https://crrev.com/0e52eda37754c557cf5d3edc929d536a7906eb88/content/browser/loader/prefetch_browsertest.cc
[modify] https://crrev.com/0e52eda37754c557cf5d3edc929d536a7906eb88/content/child/runtime_features.cc
[modify] https://crrev.com/0e52eda37754c557cf5d3edc929d536a7906eb88/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/0e52eda37754c557cf5d3edc929d536a7906eb88/third_party/blink/renderer/core/loader/link_loader.cc
[modify] https://crrev.com/0e52eda37754c557cf5d3edc929d536a7906eb88/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/0e52eda37754c557cf5d3edc929d536a7906eb88/third_party/blink/renderer/platform/runtime_enabled_features.json5

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03168d86dfe524a9e90f38fb27f3b5f01c29eded

commit 03168d86dfe524a9e90f38fb27f3b5f01c29eded
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Aug 24 09:05:35 2018

Update sxg version of prefetch accept: header to b2

and add a link to the mime-type definition.

Bug:  874752 , 876968 
Change-Id: I63be125a714e716fa83becc23e812db453fa1a9d
Reviewed-on: https://chromium-review.googlesource.com/1188163
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585770}
[modify] https://crrev.com/03168d86dfe524a9e90f38fb27f3b5f01c29eded/content/browser/loader/prefetch_browsertest.cc
[modify] https://crrev.com/03168d86dfe524a9e90f38fb27f3b5f01c29eded/third_party/blink/renderer/core/loader/link_loader.cc

Status: Fixed (was: Started)

Sign in to add a comment