New issue
Advanced search Search tips

Issue 874750 link

Starred by 1 user
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Aug 23
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Blue focus ring is not seen on radio button in permission bubble on pressing 'Tab' key.

Reported by avsha...@etouch.net, Aug 16 
Chrome Version : 70.0.3524.0 (Official Build) af89913d666a6f95572c04f15ab3a0752343ebf3-refs/branch-heads/3524@{#1} 32/64 bit
OS : Windows (7, 8, 8.1, 10), Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, open NTP, click on 'Microphone' icon in NTP search box and allow the permission.
2. Open 'Microphone' bubble in omnibox and hit 'Tab' key.
3. Observe the first radio button.

Actual Result : Blue focus ring is not seen on radio button in permission bubble on pressing 'Tab' key.

Expected Result : Focus ring should be seen on first radio button in permission bubble on pressing 'Tab' key.

This is a regression issue broken in ‘M-70’ and below is the bisect info:
Good Build : 70.0.3521.0 (Revision : 582484)
Bad Build : 70.0.3522.0 (Revision : 582755)

Narrow bisect URL :
https://chromium.googlesource.com/chromium/src/+log/33435161ac4c3672000d4375da19093889e4faf6..5cfa6e512bba02b84bd2239490d086257e0906ea

Suspect : r582646 ?

ellyjones@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1. Issue is also seen for a checkbox in 'Chrome un-installation' dialog.

2. This issue is not observed in Mac(10.12.6, 10.13.1, 10.13.6, 10.14) OS.

3. Issue not observed in Dev build #70.0.3521.2

4. Unable to provide bisect using per-revision script on Windows machines as it is giving trace back error. Tried on other machines (Win 7,10) and got the same trace back error.

5. Hence provided the suspect through Narrow bisect.

Thank You..!
Actual_Result.mp4
641 KB View Download
Expected_Result.mp4
530 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/784139a9d51b27eade1299f28be09f4ba9594b96

commit 784139a9d51b27eade1299f28be09f4ba9594b96
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Thu Aug 16 16:16:35 2018

views: always use focus rings on checkbox and radio buttons

These use focus rings even on platforms that normally use the ink drop effect to
indicate focus.

Bug:  874750 
Change-Id: I1a531126b348b8d910998778caa5abd40e87a898
Reviewed-on: https://chromium-review.googlesource.com/1177681
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583680}
[modify] https://crrev.com/784139a9d51b27eade1299f28be09f4ba9594b96/ui/views/controls/button/checkbox.cc

Comment 2 by avsha...@etouch.net, Aug 17

Labels: TE-Verified-70.0.3525.0 TE-Verified-M70
Update :
---------
Tested above issue in latest Canary build #70.0.3525.0 on Windows (7, 8, 8.1, 10) and Linux(14.04 LTS) OS and the issue is fixed. 
Focus ring for radio button appears as expected after pressing Tab Key, hence adding TE-Verified labels. Kindly review an attached screen-cast for reference.

Thank you..!
latest_results.mp4
473 KB View Download

Comment 3 by ellyjo...@chromium.org, Aug 23

Status: Fixed (was: Assigned)
Fix landed and baked :)
►

Sign in to add a comment