Regression: [NTP] Unwanted space is observed on 'Select a collection' overlay.
Reported by
db...@etouch.net,
Aug 16
|
||||||||
Issue descriptionChrome Version:69.0.3497.42 Revision 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}(32/64 bit) OS: Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS) OS Pre-condition: Enabled 'Enable using the Google local NTP' and 'New Tab Page Background Selection' flag from chrome://flags What steps will reproduce the problem? (1) Launch chrome, open NTP and click on gear icon then select 'Choose background' option ('Select a collection' overlay opened) (2) Press Cmd-- and observe on 'Select a collection' overlay. Actual: Unwanted space is observed on Select a collection' overlay. Expected: No such a space should seen on Select a collection' overlay. This is a regression issue,broken in 'M69', below is bisect info: Good Build:69.0.3457.0(Revision: 566679) Bad Build: 69.0.3460.0(Revision: 567312) You are probably looking for a change made after 575755 (known good), but no later than 575756 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/f1717d24eb02cbe374d01ef29dff42199bd636de..9b0efaf66eb7329309a36179e8c07cb508f04977 Suspect: https://chromium.googlesource.com/chromium/src/+/9b0efaf66eb7329309a36179e8c07cb508f04977 kmilka@: ould you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank you.
,
Aug 16
I can't repro this on Mac with 69Beta, but can repro on Windows & Linux with 69Beta. Weilun - this might be a tricky one to figure out, would you mind taking a look? Lowering the priority as it'd be nice to support this with zoom, but the UI is still usable.
,
Aug 16
The problem for this bug is in the scroll bar. The scroll bar takes up space on glinux and resizes in different ratio than the collection tile. One possible solution is to resize the dialog according to zooming the window. wdyt?
,
Aug 17
Worth trying but make sure it doesn't introduce other issues.
,
Aug 21
,
Aug 23
This issue appears in both windows and linux. By default the scrollbar will be resized according to the window size. However, it resizes itself in a different ratio than the collection tile. One way to solve it is fixing the size of the scroll bar. But this will need Joel to decide how the scroll bar looks.
,
Aug 23
+Joel: is there any specific style guideline to be followed here when zooming?
,
Sep 19
,
Sep 20
With respect to comment 7:
There is no any specific guideline to be followed here when zooming, issue is reproducible on latest build #71.0.3557.0 with following steps:
(1) Launch chrome, open NTP and click on gear icon then select 'Choose background' option ('Select a collection' overlay opened)
(2) Press Cmd-- and observe on 'Select a collection' overlay.
Thank you.
,
Sep 20
The needs feedback was for Joel.
,
Sep 20
In a perfect world, we wouldn't do anything custom with the scroll bar, but if making it fixed is the only way to keep the grid from breaking, I think its a reasonable compromise. Is it not possible to just treat the 3-up grid percentage based like the scroll bar so it doesn't break? How is the width/grid of the thumbnails defined?
,
Sep 20
Gottcha. Yeah, my general thought was "could we call it 1/3 of width minus the margin"? Not suggesting we implement differently, just thinking about how we could maintain the layout at different scales. Can we dig into this more? Seems like a reasonable option.
,
Sep 20
The width of the grid is 517, width for each tile is 156 with 8px margin-right. I don't know if that's possible to set the width to a certain percentage eg. 33%, 66%, 100%. However, the number of column in a row will change depends on the window size.
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c95c6af2d0d93f7cd103fd0282795fdc60d01bb4 commit c95c6af2d0d93f7cd103fd0282795fdc60d01bb4 Author: Weilun Shi <sweilun@chromium.org> Date: Fri Sep 21 03:59:36 2018 [NTP] Custom background dialog unwanted space caused by scrollbar Using percentage width instead of constant number width for the collection/image tiles. Leaving one percent width for the scrollbar. Screencast: https://screencast.googleplex.com/cast/NDYwMjgyNjA0NzA5NDc4NHxmNTgxMjYyOC0yNQ Bug: 874742 Change-Id: I54f303a3ec294502669b26f0a6d31388e67b35dc Reviewed-on: https://chromium-review.googlesource.com/1237515 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#593074} [modify] https://crrev.com/c95c6af2d0d93f7cd103fd0282795fdc60d01bb4/chrome/browser/resources/local_ntp/custom_backgrounds.css [modify] https://crrev.com/c95c6af2d0d93f7cd103fd0282795fdc60d01bb4/chrome/browser/resources/local_ntp/custom_backgrounds.js
,
Sep 21
,
Sep 24
The change is not applied to official build yet. Please check it with the latest chromium. Thank you!
,
Sep 25
With respect to comment 19: Issue is fixed on latest chromium build #71.0.3562.0 (Developer Build) Revision 8cde4ece69e1be0b92ff4f7bb87af6a1bd9f1af4-refs/heads/master@{#593877} OS. Kindly refer attached screencast: Thank you. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by kmilka@chromium.org
, Aug 16