New issue
Advanced search Search tips

Issue 874737 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Layout Test animations/animation-shorthand-overriding.html etc are crashing on WebKit Android (Nexus4)

Project Member Reported by nhiroki@chromium.org, Aug 16

Issue description

The following layout test is failing on WebKit Android (Nexus4)

- animations/animation-shorthand-overriding.html
- animations/interpolation/border-image-slice-interpolation-stability.html
- animations/responsive/interpolation/offset-rotate-responsive.html
- animations/stability/empty-keyframes.html
- animations/svg-attribute-composition/svg-bias-composition.html
- animations/svg-attribute-interpolation/svg-numOctaves-interpolation.html

These failures started from:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Android%20%28Nexus4%29/81613

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4117b35a4bcec8888cd4bf502df237c4ebfe191c

commit 4117b35a4bcec8888cd4bf502df237c4ebfe191c
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Thu Aug 16 06:37:25 2018

Sheriff: Mark animations/animation-shorthand-overriding.html etc with Crash on Android

Bug:  874737 
Change-Id: I11c23cf99defa75625cd14284b010e28bb297c72
Tbr: nhiroki@chromium.org
Notry: true
Reviewed-on: https://chromium-review.googlesource.com/1177219
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583565}
[modify] https://crrev.com/4117b35a4bcec8888cd4bf502df237c4ebfe191c/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium
FYI: Looks like these tests started running on the Android bots recently:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=animations%2Fanimation-shorthand-overriding.html
Components: -Blink>Animation Internals>GPU
The failure seems to indicate that the GPU process failed to initialize:

[26716:26732:0815/173724.601554:FATAL:gpu_data_manager_impl_private.cc(866)] GPU process isn't usable. Goodbye.

In all of these failures it looks to me like a large list of tests (animation and non animation) are failing for the same reason. I'm moving component to GPU pending a reason to suspect the failures are specifically related to blink animations.
Cc: cblume@chromium.org khushals...@chromium.org
Owner: ericrk@chromium.org
Status: Assigned (was: Untriaged)
Is the crash only happening on this bot?
This appears to have been resolved on the bots. My guess (looking at the CLs from the initial regression) is that this was due to https://chromium-review.googlesource.com/c/chromium/src/+/1161601 which has since been reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1181585

Unfortunately, a second issue seems to have broken the tests in the meantime, making it tricky to confirm the fix. However, everything is green now.

We should probably just restore the tests disabled in #1.

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6c5048eebea39c525acc8b48f14a0fefb442069

commit b6c5048eebea39c525acc8b48f14a0fefb442069
Author: Eric Karl <ericrk@chromium.org>
Date: Sat Aug 25 01:48:51 2018

Revert "Sheriff: Mark animations/animation-shorthand-overriding.html etc with Crash on Android"

This reverts commit 4117b35a4bcec8888cd4bf502df237c4ebfe191c.

Reason for revert: The issue which was leading to the original crashes here has been addressed.

Original change's description:
> Sheriff: Mark animations/animation-shorthand-overriding.html etc with Crash on Android
> 
> Bug:  874737 
> Change-Id: I11c23cf99defa75625cd14284b010e28bb297c72
> Tbr: nhiroki@chromium.org
> Notry: true
> Reviewed-on: https://chromium-review.googlesource.com/1177219
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583565}

TBR=nhiroki@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  874737 
Change-Id: I44fa371cdc4d2ee1b1d513484643372774c6943f
Reviewed-on: https://chromium-review.googlesource.com/1188495
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586100}
[modify] https://crrev.com/b6c5048eebea39c525acc8b48f14a0fefb442069/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)

Sign in to add a comment