New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 874722 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Move chromium-build-stats to go/src/infra/appengine

Project Member Reported by tikuta@chromium.org, Aug 16

Issue description

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1

commit 7ddaab860a1f08ebbead6f00253d0d7ab9e122a1
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Aug 17 05:48:56 2018

Move chromium_build_stats to go/src/infra/appengine

This CL moves chromium_build_stats to under go/src/infra/appengine directory.
* Remove some unnecessary files
* Update deps
* Fix a few typos
* Change import path
* Add coverage config

I will do some followup work for this location change.

This move is to follow other appengine services written in golang.
Currently, golang's pkgs for chromium_build_stats are managed by DEPS, but this makes difficult to manage pkgs imported by dependent packages.
infra's other golang's services are managed by glide via deps.py. So it will make package management easier.

Bug:  874722 
Change-Id: Ie42c77c5828190544f16c0f4cb94784a4070d0c2
Reviewed-on: https://chromium-review.googlesource.com/1177281
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

[add] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/logstore/logstore.infra_testing
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/compilerproxylog/glog_test.go
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/app.yaml
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/ninjalog/testdata/ninja_log
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/OWNERS
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/static/robots.txt
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/ninja_log_test.go
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/ninjalog/ninjalog.proto
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/logstore/logstore.go
[add] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/ninjalog/ninjalog.infra_testing
[add] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/cmd/ninja_log_trace_viewer/ninja_log_trace_viewer.infra_testing
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/compilerproxylog/compiler_proxy_log_test.go
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/logstore/fetch.go
[add] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/compilerproxylog/compilerproxylog.infra_testing
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/logstore/logstore_test.go
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/app.go
[delete] https://crrev.com/1a2dc3958d2251accaac30bd18302bf1a7762fb3/appengine/chromium_build_stats/.expect_tests_pretest.py
[delete] https://crrev.com/1a2dc3958d2251accaac30bd18302bf1a7762fb3/appengine/chromium_build_stats/PRESUBMIT.py
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/compilerproxylog/glog.go
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/cmd/diagnose_goma_log/diagnose_goma_log.go
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/static/favicon.ico
[delete] https://crrev.com/1a2dc3958d2251accaac30bd18302bf1a7762fb3/appengine/chromium_build_stats/default/tmpl/dummy.json
[add] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/cmd/diagnose_goma_log/diagnose_goma_log.infra_testing
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/compiler_proxy_log.go
[delete] https://crrev.com/1a2dc3958d2251accaac30bd18302bf1a7762fb3/appengine/chromium_build_stats/goenv.sh
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/tmpl/trace-viewer.html
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/ninjalog/trace_test.go
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/ninjalog/traceviewer/traceviewer.go
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/compiler_proxy_log_test.go
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/ninjalog/trace.go
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/auth.go
[add] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/chromium_build_stats.infra_testing
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/ninjalog/ninjalog.go
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/README.md
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/ninjalog/gen.go
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/logstore/upload.go
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/file.go
[add] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/ninjalog/traceviewer/traceviewer.infra_testing
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/Makefile
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/compilerproxylog/doc.go
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/ninjalog/ninjalog_test.go
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/ninja_log.go
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/ninjalog/doc.go
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/cmd/ninja_log_trace_viewer/ninja_log_trace_viewer.go
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/ninjalog/ninjalog.pb.go
[rename] https://crrev.com/7ddaab860a1f08ebbead6f00253d0d7ab9e122a1/go/src/infra/appengine/chromium_build_stats/compilerproxylog/compiler_proxy_log.go

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7b573a04dfca34c48f0796b1d9480b82fe55230b

commit 7b573a04dfca34c48f0796b1d9480b82fe55230b
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Aug 17 08:19:25 2018

Specify nobuild_files to app.yaml

Due to import path confliction, current directory layout failed to deploy app engine.
By specifying nobuild_files, appengine go runtime does not look subdirectory when deploying and this fixes deployment error.

This solution is written in
https://godoc.org/golang.org/x/tools/cmd/present
I found from https://motemen.hatenablog.com/entry/2016/11/gae-go-building#go-app-builder-Failed-parsing-input-app-file-xxxgo-conflicts-with-same-file-imported-from-GOPATH (this is written in japanese)

Bug:  874722 
Change-Id: I9c2b89830d13ae17c3d000db76c029c438820c78
Reviewed-on: https://chromium-review.googlesource.com/1179543
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

[modify] https://crrev.com/7b573a04dfca34c48f0796b1d9480b82fe55230b/go/src/infra/appengine/chromium_build_stats/app.yaml

Status: Fixed (was: Untriaged)

Sign in to add a comment