browser_tests failing on chromium.mac/Mac10.13 Tests (dbg) |
|||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of nhiroki@chromium.org browser_tests failing on chromium.mac/Mac10.13 Tests (dbg) Builders failed on: - Mac10.13 Tests (dbg): Failures: OneClickSigninDialogControllerTest.LearnMore OneClickSigninDialogControllerTest.Close OneClickSigninDialogControllerTest.Advanced MediaGalleriesDialogBrowserTest.Close OneClickSigninDialogControllerTest.OK OneClickSigninDialogControllerTest.Undo https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29
,
Aug 16
The "mac-cocoa-rel" bot is also failing: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-cocoa-rel/898
,
Aug 16
,
Aug 16
Speculative revert: https://chromium-review.googlesource.com/c/chromium/src/+/1177021
,
Aug 16
The speculative revert didn't work and I relanded it: https://chromium-review.googlesource.com/c/chromium/src/+/1177103
,
Aug 16
(I'm now handling other failures)
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3fbd268b75c69b6c755cfcf59fab7ec731116b4b commit 3fbd268b75c69b6c755cfcf59fab7ec731116b4b Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Thu Aug 16 07:02:08 2018 Revert "Whitelist the run loop mode that AppKit uses to animate the menu in fullscreen." This reverts commit b22ea1fa7081741279cfffeed61c0c19da4c0a23. Reason for revert: Let me speculatively revert for test failures on the mac bots. https://crbug.com/874716 Apparently this CL passes all try bots on the review page, but it fails some experimental fyi tests. See "browser_tests on (none) GPU on Mac (with patch, experimental)": https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/118766 I'll reland this CL if this is not relevant. Bug: 874716 Original change's description: > Whitelist the run loop mode that AppKit uses to animate the menu in fullscreen. > > This stops UI animation and video from freezing during the animation. > Also move some constants to test-accessible location and delete the > duplicates in the tests. > > Bug: 554993 > Change-Id: Ie4585fa405b32e8bdae984d5a4ffac700c1375ab > Reviewed-on: https://chromium-review.googlesource.com/1166169 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Sidney San MartÃn <sdy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583361} TBR=sdy@chromium.org,mark@chromium.org Change-Id: I3fc77024fb7d82a8c79bad1b357475fb900d87d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 554993 Reviewed-on: https://chromium-review.googlesource.com/1176903 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#583568} [modify] https://crrev.com/3fbd268b75c69b6c755cfcf59fab7ec731116b4b/base/message_loop/message_pump_mac.h [modify] https://crrev.com/3fbd268b75c69b6c755cfcf59fab7ec731116b4b/base/message_loop/message_pump_mac.mm [modify] https://crrev.com/3fbd268b75c69b6c755cfcf59fab7ec731116b4b/base/message_loop/message_pump_mac_unittest.mm
,
Aug 16
I'm back :) I landed the speculative revert and now I'm monitoring the tree...
,
Aug 16
New sheriff here. :) I tested the revert locally on MacOS 10.13 and can confirm that it fixes the problem. Still waiting for the bots to confirm.
,
Aug 16
Issue 874765 has been merged into this issue.
,
Aug 16
No longer failing on the bots. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nhiroki@chromium.org
, Aug 16