New issue
Advanced search Search tips

Issue 874700 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 19
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Use cros_mark_as_stable --buildroot and --overlay-type

Project Member Reported by dgarr...@chromium.org, Aug 16

Issue description

These two CLs modified cros_mark_as_stable to accept --buildroot instead of --srcroot, and --overlay-type, instead of --overlay with an explicit list of overlays.

https://crrev.com/c/1176729
https://crrev.com/c/1176730

We need to update our build stages to use the new options.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/5a571a1d27ef0227021f657463805afac2543c91

commit 5a571a1d27ef0227021f657463805afac2543c91
Author: Don Garrett <dgarrett@google.com>
Date: Thu Aug 23 14:37:21 2018

commands: Use cros_mark_as_stable --buildroot.

Switch cros_mark_as_stable usage from --srcroot to --buildroot, now
that --srcroot is deprecated in favor of --buildroot.

See https://crrev.com/c/1171906

BUG= chromium:874700 
TEST=run_tests

Change-Id: I2443164815794c9cd29d12130b44505ad17ba85a
Reviewed-on: https://chromium-review.googlesource.com/1176729
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/5a571a1d27ef0227021f657463805afac2543c91/cbuildbot/commands.py

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/33afbdd64a185d5acaa1b2cca401069c81ed526d

commit 33afbdd64a185d5acaa1b2cca401069c81ed526d
Author: Don Garrett <dgarrett@google.com>
Date: Thu Aug 23 19:09:17 2018

commands: cros_mark_as_stable overlay-type support.

Add support for passing --overlay-type values to cros_mark_as_stable,
instead of explicit overlay lists.

BUG= chromium:874700 
TEST=run_tests

Change-Id: I86697868a42b9545806785aceb8deedf6c8e71f1
Reviewed-on: https://chromium-review.googlesource.com/1176730
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/33afbdd64a185d5acaa1b2cca401069c81ed526d/cbuildbot/commands.py
[modify] https://crrev.com/33afbdd64a185d5acaa1b2cca401069c81ed526d/cbuildbot/commands_unittest.py

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b7396aeb3faeba5a11ddabad4c4b3754e10c9a87

commit b7396aeb3faeba5a11ddabad4c4b3754e10c9a87
Author: Don Garrett <dgarrett@google.com>
Date: Thu Aug 23 19:09:17 2018

workspace_stages: Use overlay_type for workspace uprevs.

Use new cros_mark_as_stable feature for finding overlays to uprev.

BUG= chromium:874700 
TEST=run_tests

Change-Id: Iaef3f09a8ca1579efd51fafab8d826da0132665b
Reviewed-on: https://chromium-review.googlesource.com/1176731
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/b7396aeb3faeba5a11ddabad4c4b3754e10c9a87/cbuildbot/stages/workspace_stages.py

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b825d5923d5e3d0adfd16cc77e522e689734d12e

commit b825d5923d5e3d0adfd16cc77e522e689734d12e
Author: Don Garrett <dgarrett@google.com>
Date: Tue Sep 18 21:03:43 2018

UprevStage: Use overlay_type instead of explict overlays list.

Let the cros_mark_as_stable script figure out the list of overlays to
use, instead of passing in an explicit list.

BUG= chromium:874700 
TEST=run_tests

Change-Id: Ifc537a2b60ba021b1cdbd2a63fef8f08fa96ae3a
Reviewed-on: https://chromium-review.googlesource.com/1226176
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/b825d5923d5e3d0adfd16cc77e522e689734d12e/cbuildbot/stages/build_stages.py

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/54168940d56d7c6cce2b08730239242fa05333aa

commit 54168940d56d7c6cce2b08730239242fa05333aa
Author: Don Garrett <dgarrett@google.com>
Date: Tue Sep 18 21:03:43 2018

PublishUprevChangesStage: Use overlay_type for UprevPackages.

Let the cros_mark_as_stable script figure out the list of overlays to
use when uprevving, instead of passing in an explicit list.

BUG= chromium:874700 
TEST=run_tests

Change-Id: I4689e9d255eb8ded591c995654a33bccac9db80b
Reviewed-on: https://chromium-review.googlesource.com/1226177
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/54168940d56d7c6cce2b08730239242fa05333aa/cbuildbot/stages/completion_stages_unittest.py
[modify] https://crrev.com/54168940d56d7c6cce2b08730239242fa05333aa/cbuildbot/stages/completion_stages.py

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/76f0f753db9d32e5ff4754d4cd5e6f2ff8697421

commit 76f0f753db9d32e5ff4754d4cd5e6f2ff8697421
Author: Don Garrett <dgarrett@google.com>
Date: Wed Sep 19 22:40:18 2018

PublishUprevChangesStage: Use overlay_type for UprevPush.

Let the cros_mark_as_stable script figure out the list of overlays to
use when pushing uprevs, instead of passing in an explicit list.

BUG= chromium:874700 
TEST=run_tests

Change-Id: Ic360c004ae9f564637504418002c38ad6e987ace
Reviewed-on: https://chromium-review.googlesource.com/1226178
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/76f0f753db9d32e5ff4754d4cd5e6f2ff8697421/cbuildbot/stages/completion_stages_unittest.py
[modify] https://crrev.com/76f0f753db9d32e5ff4754d4cd5e6f2ff8697421/cbuildbot/stages/completion_stages.py

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/2320f32d05a98b72bec975f4e022101b4a1842a4

commit 2320f32d05a98b72bec975f4e022101b4a1842a4
Author: Don Garrett <dgarrett@google.com>
Date: Wed Sep 19 22:40:19 2018

commands: Remove overlay args to UprevPackages and UprevPush.

The overlays argument has been replaced with overlay_type argument for
all callers of both UprevPackages and UprevPush functions, so remove
the deprecated argument.

BUG= chromium:874700 
TEST=run_tests

Change-Id: I921453a2f8c067e6d2fa85d81bdf1600e096ca4f
Reviewed-on: https://chromium-review.googlesource.com/1226179
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/2320f32d05a98b72bec975f4e022101b4a1842a4/cbuildbot/commands.py
[modify] https://crrev.com/2320f32d05a98b72bec975f4e022101b4a1842a4/cbuildbot/commands_unittest.py

Status: Fixed (was: Started)

Sign in to add a comment