New issue
Advanced search Search tips

Issue 874696 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

[VR Browsing] Automated test case needed for opening Omnibox keyboard and clicking on a key.

Project Member Reported by dbbrooks@chromium.org, Aug 16

Issue description

A recent crasher, bug 874671, was found during a manual test pass where Chrome crashed when clicking on a key from Omnibox text entry mode. 

It would be nice for this issue to be covered by automation.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0c12063dc7d5c52830f2a60c4c087850a054cd0

commit a0c12063dc7d5c52830f2a60c4c087850a054cd0
Author: bsheedy <bsheedy@chromium.org>
Date: Thu Aug 23 00:00:50 2018

Add VR browser omnibox keyboard input test

Modifies an existing test that brings up a keyboard so that it also
inputs text via the keyboard. This is to catch future occurances of
https://crbug.com/874671 where inputting text into the VR Browser's
omnibox would cause a browser crash.

Also installs the latest VR Keyboard APK as part of pre-test setup
in test suites that could potentially use the keyboard.

Bug: 874671,  874696 
Change-Id: Ic04d678e14de918fbf159078422c9d5459e8d98d
Reviewed-on: https://chromium-review.googlesource.com/1176876
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585321}
[modify] https://crrev.com/a0c12063dc7d5c52830f2a60c4c087850a054cd0/chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrBrowserDialogTest.java
[modify] https://crrev.com/a0c12063dc7d5c52830f2a60c4c087850a054cd0/testing/buildbot/chromium.android.json
[modify] https://crrev.com/a0c12063dc7d5c52830f2a60c4c087850a054cd0/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/a0c12063dc7d5c52830f2a60c4c087850a054cd0/testing/buildbot/test_suites.pyl

Status: Fixed (was: Assigned)

Sign in to add a comment